Donald Sharp
32b8321167
Merge pull request #2840 from opensourcerouting/snap-bfdd
...
snapcraft: Add bfdd to snap package
2018-08-15 07:54:50 -04:00
Donald Sharp
c4a811668d
Merge pull request #2843 from LabNConsulting/working/lb/doc-solo
...
bgpd: document how to avoid reflecting advertised information back to originator
2018-08-15 07:54:08 -04:00
Lou Berger
199ad5c47f
user: document neighbor ... solo config
...
Signed-off-by: Lou Berger <lberger@labn.net>
2018-08-14 23:58:25 -04:00
Rafael Zalamena
1608496459
bfdd: fix alpine build
...
Move `recvmsg` parameter option initialization to function, initialize
the parameter struct with zeroes and access field by name.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-08-14 17:52:14 -03:00
Rafael Zalamena
98ef9c165c
bfdd: fix downtime display
...
BFD peer status show command was using the wrong variable to display the
downtime counter.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-08-14 17:52:14 -03:00
Martin Winter
64a6fb039b
snapcraft: Add bfdd to snap package
...
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2018-08-14 13:31:54 -07:00
Quentin Young
c957f7d979
ospf6d: sanity check refcount correctness
...
Coverity warns about a possible double free; add an assert to make sure
we never hit it, and hopefully silence Coverity.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:08:50 +00:00
David Lamparter
633fc9b133
*: frr_elevate_privs whitespace fixes
...
(... and one superfluous variable removed)
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-08-14 20:02:05 +00:00
David Lamparter
8d2dcc85dd
zebra: fix warnings from frr_elevate_privs()
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-08-14 20:02:05 +00:00
David Lamparter
6bb30c2cba
*: use frr_elevate_privs() (2/2: manual)
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-08-14 20:02:05 +00:00
David Lamparter
01b9e3fd0d
*: use frr_elevate_privs() (1/2: coccinelle)
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-08-14 20:02:05 +00:00
David Lamparter
6017c3a2e7
lib: add frr_elevate_privs() wrapper
...
Used as:
frr_elevate_privs(&my_privs) {
... code ...
}
and handles privilege raise/lower automatically in conjunction with the
C expression block. This makes it impossible to accidentally exit a
function with privileges raised (and then running a whole bunch of other
code with privs.)
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-08-14 20:02:05 +00:00
Quentin Young
09c866e34d
*: rename ferr_zlog -> flog_err_sys
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
85cd2f9f9a
*: rename ferr_ref -> log_ref
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
af4c27286d
*: rename zlog_fer -> flog_err
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
fa8b3ca66a
lib: remove still reachable blocks in ferr.c
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
af4d3437ce
lib, vtysh: fixup style nits for error refs
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
98c15db655
zebra: add missing include
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
5e1e0166cb
*: correct typos in error reference cards
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
67aeb55414
zebra: Cleanup compile issues discovered by ci
...
Include a couple of missed headers.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
164ffab251
*: remove \n from error code texts
...
Should be handled by pager
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
ed8841d3fb
lib: add 'show error all json'
...
* Add 'all' option
* Add 'json' option
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
fc5031bc33
babeld: fix erroneous lib init
...
Babel was screwing up lib initialization causing double inits of many
things.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
5ad4c39ce4
*: stop double initialization of ferr
...
* Stop double init of ferr
* Fixup bugs in zebra ferr
* Add missing init in ospfd
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
247dcce2b5
*: fix source file headers & includes for errcodes
...
* Use the correct license header
* Stop headers from including themselves
* Use uniform relative include conventions
* Ensure that sources include what they use
* Turn off clang-format around struct array blocks
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Chirag Shah
313d7993a3
ospfd: zlog_ferr facility
...
Ticket:CM-21333
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
b87478cb3e
lib: Convert zlog_err for clippy build
...
The clippy code does not need to log the error messages
as errors as that it is only run as part of the build
itself and as long as we see the notifications we are good.
So convert zlog_err to zlog_notice so that we do not think
we have any zlog_err's in lib anymore
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
30b0312cc1
lib: Remove unnecessary zebra.h include
...
lib_errors.c does not need to include zebra.h, so remove
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
518e377f39
ripd: Add RIP_ERR_XXX to move from zlog_err to zlog_ferr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
b647dc2aec
watchfrr: Add WATCHFRR_ERR_XXX for zlog_err to zlog_ferr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
0f41a2628d
lib: Fix Spelling mistake
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
8b0a80f120
eigrpd: Add EIGRP_ERR_XXX for zlog_err to zlog_ferr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
aed0701124
nhrpd: Add NHRP_ERR_XXXX for zlog_err to zlog_ferr conversion
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
4f3be6672f
bgpd: Add some FLowspec specific Error Codes.
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
02705213b1
bgpd: Convert to using LIB_ERR_XXX where possible
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
43e52561b4
zebra, lib: error references for zebra
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
b72002107f
isisd: Cleanup compile issue
...
cleanup compile with missnamed enum usage.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
54ece69899
isisd: Add isis_errors and generate custom Error Codes
...
Generate appropriate error codes for ISIS.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
38937bd540
isisd: Convert to use LIB_ERR_XXX
...
Where an obvious choice could be made about converting
to a LIB_ERR_XXX function do so.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
e33b116cdf
babeld: Convert all zlog_err to zlog_ferr and add appropriate info
...
Convert babeld to use zlog_ferr and add appropriate BABEL_ERR_XXX
information.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
f135ba5272
babeld: Add BABEL_ERR_XXX error messages.
...
Add some BABEL_ERR_XXX error messages and convert over to using
zlog_ferr instead of zlog_err.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
d9ff430273
pimd: Add pim_errors and define some pim specific errors
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
def31c1305
bgpd: Cleanup initialization of bgp_errors.c
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Don Slice
14454c9fdd
bgpd: implement zlog_ferr facility for enhance error messages in bgp
...
Signed-off-by: Don Slice <dslice@cumulusnetworks.com<
2018-08-14 20:02:05 +00:00
Donald Sharp
1e40409931
ldpd: Convert to using LIB_ERR_XXX and zlog_ferr
...
convert ldpd over to using zlog_ferr and LIB_ERR_XXX
where appropriate.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
6ae7ed45ff
eigrpd: Convert to use LIB_ERR_XXX for zlog_err
...
Convert, where appropriate, to using LIB_ERR_XXX for zlog_ferr
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
ad9921dbd8
lib: Update error ranges to include all daemons
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
3613d89844
pimd: Convert over to use LIB_ERR_XXX for zlog_err
...
Convert, where appropriate, the zlog_err functions to zlog_ferr
for the LIB_ERR_XXX enums
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
7f9a4fd701
ripngd: Convert over to using LIB_ERR_XXXX for zlog_ferr
...
Convert over those zlog_err functions to zlog_ferr that
are appropriate for the LIB_ERR_XXX.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
77cbe4a1b3
ripd: Convert zlog_err to zlog_ferr for LIB_ERR_XXX
...
For those errors that can be traced to LIB_ERR_XXX
convert to using those in ripd.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00