Igor Ryzhov
6c75f4b3c7
Revert "bgpd: vtysh commands for peer/group dampening profiles"
...
This reverts commit 0221327c75
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Igor Ryzhov
5979fde0d8
Revert "bgpd: Do not output peer doppleganger dampened output"
...
This reverts commit 783492c7cd
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Igor Ryzhov
75caa18cef
Revert "bgpd: Consolidate dampening show run output with the rest of that code"
...
This reverts commit 39d8dd2d17
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Igor Ryzhov
a5c1e10386
Revert "doc: user doc for route-flap dampening commands"
...
This reverts commit 54b34709f8
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Igor Ryzhov
c499bf64d0
Revert "tests: topotests for route-flap dampening"
...
This reverts commit cd32a1a4ee
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Igor Ryzhov
003cae8534
Revert "bgpd: clear ip bgp dampening was not triggering the route calculation for the prefix"
...
This reverts commit c8ddbd4804
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
22632386ac
Revert "bgpd: Remove useless reuselist_node assignment before while loop"
...
This reverts commit 53048d33d1
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
3d20a370fc
Revert "bgpd: Do not test against bdc again since we already validated"
...
This reverts commit 63fc789a10
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
7ab05c74ad
Revert "bgpd: fix double free in dampening code"
...
This reverts commit 96d6b8cc29
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
814f07b2e7
Revert "bgpd: Drop double-pointer for bgp_damp_info_free()"
...
This reverts commit 19971c9a92
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
303b8d24d2
Revert "bgpd: fix missing list add in dampening"
...
This reverts commit cd58568b18
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
aa95cf73a4
Revert "bgpd: fix incorrect usage of slist in dampening"
...
This reverts commit 5054cfcbbc
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
5c8846f6e8
Revert "bgpd: cleanup bgp_damp_info_free"
...
This reverts commit 97766ac8aa
.
2021-08-03 21:54:47 +03:00
Igor Ryzhov
2dcaf18149
Revert "bgpd: fix missing damp info free when cleaning bgp path"
...
This reverts commit 4538f89552
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Russ White
efadadc1b6
Merge pull request #9264 from ak503/nhrp_fix
...
nhrp: fix display of nhs command.
2021-08-03 13:42:48 -04:00
Russ White
67831eeebb
Merge pull request #9164 from pguibert6WIND/flowspec_vrflite_shortcut
...
bgpd: flowspec redirect vrf uses vrf table instead of allocated table id
2021-08-03 09:31:17 -04:00
Russ White
cdc549b51a
Merge pull request #9191 from idryzhov/rip-auth
...
ripd: fix authentication key length
2021-08-03 09:29:09 -04:00
Russ White
11093fc905
Merge pull request #9231 from idryzhov/zebra-rmap-set-src
...
zebra: remove checks for src address existence when using "set src"
2021-08-03 09:22:18 -04:00
Russ White
f61a950acf
Merge pull request #9239 from idryzhov/ospf-passive-fix
...
ospfd: fix "no ip ospf passive" command
2021-08-03 09:21:14 -04:00
Russ White
f041fe620d
Merge pull request #9243 from ton31337/fix/revert_db0e636dc45f9bd2c76528a8368332c56f2c8f1e
...
bgpd: Revert a couple of BGP dampening related commits
2021-08-03 09:20:16 -04:00
Russ White
26d7f8b285
Merge pull request #9249 from ton31337/fix/dont_capability
...
bgpd: Use strict AS4 capability when processing parsing/generating pkts
2021-08-03 09:14:27 -04:00
Russ White
1358f9d10a
Merge pull request #9259 from opensourcerouting/moar-json
...
*: can't get enough JSON
2021-08-03 09:13:12 -04:00
Dmitrii Turlupov
7a807a20d9
nhrp: fix display of nhs command.
...
Before:
ip nhrp nhs dynamicnbma 192.168.1.1
After:
ip nhrp nhs dynamic nbma 192.168.1.1
Signed-off-by: Dmitrii Turlupov <dturlupov@factor-ts.ru>
2021-08-03 14:10:54 +03:00
Russ White
04cfc0a3a8
Merge pull request #9056 from askorichenko/test-dont-capability
...
bgpd: Clear capabilities field when resetting a bgp neighbor
2021-08-03 06:59:56 -04:00
Donatas Abraitis
71c06f610f
Merge pull request #9258 from mjstapp/fix_rule_strlcpy
...
zebra: use strlcpy in dplane_rule_init
2021-08-03 09:12:38 +03:00
Renato Westphal
488599bfa2
Merge pull request #9232 from idryzhov/interface-node-cleanup
...
*: cleanup interface node installation
2021-08-02 21:13:29 -03:00
Renato Westphal
58e2857d23
lib: add "json" option to "show ip[v6] prefix-list"
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-08-02 17:19:45 -03:00
Renato Westphal
c15dc24f79
zebra: add "json" option to "show interface"
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-08-02 17:19:45 -03:00
Renato Westphal
856ed18ae9
lib: add "json" option to "show route-map"
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-08-02 16:05:44 -03:00
Renato Westphal
068ab9018b
lib: add "json" option to "show ip[v6] access-list"
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-08-02 16:05:44 -03:00
Renato Westphal
b15e836067
bgpd: add "json" option to "show bgp as-path-access-list"
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-08-02 15:53:02 -03:00
Mark Stapp
bc86b347db
zebra: use strlcpy in dplane_rule_init
...
Use strlcpy for safety in dplane rule init api.
Signed-off-by: Mark Stapp <mjs.ietf@gmail.com>
2021-08-02 12:35:50 -04:00
Donald Sharp
b22928a117
Merge pull request #9255 from ton31337/fix/bgp_max_packet_size_no_capabilities
...
bgpd: Set extended msg size only if we advertised and received capability
2021-08-02 12:11:24 -04:00
Igor Ryzhov
1f74d96c41
zebra: remove checks for src address existence when using "set src"
...
1. This check is absolutely useless. Nothing keeps user from deleting
the address right after this check.
2. This check prevents zebra from correctly reading the user config with
"set src" because of a race with interface startup (see #4249 ).
3. NO OPERATIONAL DATA USAGE ON VALIDATION STAGE.
Fixes #7319 .
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-02 18:35:30 +03:00
Igor Ryzhov
72928fa1aa
Merge pull request #9238 from leonshaw/fix/netns-delete
...
lib, zebra: Preserve user-configured VRF on netns deletion
2021-08-02 18:12:19 +03:00
Quentin Young
41d3d77496
Merge pull request #8982 from dlqs/lua-func-stack
2021-08-02 13:51:35 +00:00
Mark Stapp
08bbca7511
Merge pull request #9211 from donaldsharp/revert_logic_changes
...
lib: prevent crash in make check in some situations
2021-08-02 08:34:55 -04:00
Donatas Abraitis
8d976b0e2b
bgpd: Set extended msg size only if we advertised and received capability
...
If we don't advertise any capabilities (dont-capability-negotiate), we
shouldn't set msg size to 65k only if received this capability from another
peer.
Before:
```
~/frr# vtysh -c 'show ip bgp update-group' | grep 'Max packet size'
Max packet size: 65535
```
After:
```
~/frr# vtysh -c 'show ip bgp update-group' | grep 'Max packet size'
Max packet size: 4096
```
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-02 09:34:43 +03:00
Philippe Guibert
7afeaffa12
bgpd: flowspec redirect vrf uses vrf table instead of allocated table id
...
Until now, when bgp flowspec entry action was to redirect to a vrf, a
default route was installed in a specific table. that route was a vrf
route leak one. The process can be simplified, as vrf-lite already
has a table identifier. Actually, because policy routing is used to
redirect traffic to a defined table (with ip rule command), use
the table identifier of the VRF.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2021-08-01 14:38:13 +02:00
Donatas Abraitis
ecec984b2f
tests: Check if BGP connection established if using no capabilities adv
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-01 09:58:26 +03:00
Donatas Abraitis
8cff42add5
bgpd: Use strict AS4 capability when processing parsing/generating pkts
...
PeerA sets `dont-capability-negotiate` for PeerB. It does not send any
capabilities to PeerB. This leads to situation when PeerA received AS4 cap,
while it doesn't send AS4 to PeerB and tries parsing AS_PATH using 32bits.
[GTTPK-RX2GP][EC 33554436] Malformed AS path from 192.168.0.2, length is 4
[SM0KX-WXMGK] bgp_attr_malformed: attributes: , origin ?
[P7TRR-4J6XT][EC 33554487] 192.168.0.2: Attribute AS_PATH, parse error - treating as withdrawal
[WX70K-6XXVF][EC 33554454] 192.168.0.2 rcvd UPDATE with errors in attr(s)!! Withdrawing route.
[Z2KFR-ZGJC8] 192.168.0.2 rcvd UPDATE w/ attr: , origin ?
[P9VY3-5B6NX] 192.168.0.2 rcvd UPDATE wlen 0 attrlen 80 alen 73
[QMZ79-K2DH7][EC 33554454] 192.168.0.2 [Error] Update packet error (wrong prefix length 64 for afi 1)
[P9SYB-54XRZ][EC 33554454] 192.168.0.2 [Error] Error parsing NLRI
[V1CHF-JSGRR] %NOTIFICATION: sent to neighbor 192.168.0.2 3/10 (UPDATE Message Error/Invalid Network Field) 0 bytes
[HTHRX-GQYGJ][EC 33554454] bgp_process_packet: BGP UPDATE receipt failed for peer: 192.168.0.2
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-01 09:56:48 +03:00
Donald Sharp
a76301c11c
Merge pull request #9244 from LabNConsulting/chopps/fix-bgp-list-test
...
tests: add early interface config for topojson and fix test
2021-07-31 21:37:22 -04:00
Donatas Abraitis
41a6c1a32a
Merge pull request #9246 from mjstapp/fix_doc_bgp_colons
...
doc: fix bgp user doc colons
2021-07-31 20:16:39 +03:00
Christian Hopps
845b234a8d
tests: add early interface config for topojson and fix test
...
- A more general fix for the bgp listener test which requires interfaces be
configured in the kernel when the bgpd daemons are launched.
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-07-31 14:09:24 +00:00
David Lamparter
00908959ed
Merge pull request #9228 from LabNConsulting/chopps/scapy-sendpkt
...
tests: add scapy_sendpkt.py util, replace arping use with it
2021-07-31 12:09:40 +02:00
Christian Hopps
002e6825c1
tests: add scapy_sendpkt.py util, replace arping use with it
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-07-30 21:01:22 +00:00
Mark Stapp
05653f497b
doc: fix bgp user doc
...
Too many colons in the bgp doc source file.
Signed-off-by: Mark Stapp <mjs.ietf@gmail.com>
2021-07-30 13:54:01 -04:00
Donatas Abraitis
8c834868dc
Merge pull request #9196 from donaldsharp/test_queued
...
tests: Increase timeout for loaded systems
2021-07-30 18:05:45 +03:00
Donatas Abraitis
d8e496242e
Revert "bgpd: fix memory leak in dampening"
...
This reverts commit 322e1085fe
.
2021-07-30 16:50:37 +03:00
Donatas Abraitis
253b4c5fd4
Revert "bgpd: fix missing delete from the list in dampening"
...
This reverts commit 755a977b8a
.
2021-07-30 16:50:05 +03:00