proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-28 19:43:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,818 Commits 4 Branches 191 Tags 125 MiB
66964cf6bf
Commit Graph

26818 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donald Sharp
2d73a32668 bfdd: Clean up some white space snafu's 
Found some extra spaces during code inspection.  Let's
get them cleaned up.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-01-08 07:11:07 -05:00
Donald Sharp
d91df4d7b7
Merge pull request #10305 from mobash-rasool/minor-fixes 
pimd: remove redundant header inclusion
 2022-01-08 07:08:59 -05:00
anlan_cs
8b3fd12cda lib: small debug adjustment for bfd 
Just use `__func__` to display function name.

Signed-off-by: anlan_cs <anlan_cs@tom.com>
 2022-01-08 06:01:08 -05:00
Mobashshera Rasool
78d2e63169 pimd: remove redundant header inclusion 
Just found while code inspection, pim_str.h is included twice.

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
 2022-01-07 23:21:00 -08:00
Donatas Abraitis
c5aef655d8 tests: Adopt bgp_shutdown_message test to a proper encoding 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-07 22:35:38 +02:00
Donatas Abraitis
cd9d1a366c doc: Add rfc9003 to supported BGP RFCs 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-07 22:35:38 +02:00
Donatas Abraitis
202a171144 bgpd: Use correct encoding before printing shutdown msg 
Using `bgp shutdown message MSG...`.

Length should be decoded from the first byte, but it's decoded from the data
instead.

Before:

```
%NOTIFICATION: sent to neighbor 192.168.0.2 6/2 (Cease/Administratively Shutdown) 70 bytes 5b 54 49 43 4b 45 54 2d 31 2d 31 34 33 38 33 36 37 33 39 30 5d 20 73
```

After:

```
%NOTIFICATION: sent to neighbor 192.168.0.2 6/2 (Cease/Administratively Shutdown) "[TICKET-1-1438367390] software upgrade; Expected downtime for 2 hours;"
```

On receiving side:

```
"[TICKET-1-1438367390] software upgrade; Expected downtime for 2 hours;"
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-07 22:35:38 +02:00
Donatas Abraitis
b776f48c36 bgpd: Limit shutdown message size to max 255 characters 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-07 22:35:38 +02:00
Donatas Abraitis
9f33eea39a bgpd: Increase administrative shutdown message size to 255 
Extended BGP Administrative Shutdown Communication (rfc9003):

Basically, shutdown message size is increased to 255 from 128.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-07 22:35:38 +02:00
Donatas Abraitis
cc413e2ade bgpd: Add a warning if we try to use the last reserved ASN 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-07 22:35:04 +02:00
Jafar Al-Gharaibeh
541b51a5a3
Merge pull request #10301 from donaldsharp/pim_multicast_fix 
tools: Give longer for interface traffic in pim to work
 2022-01-07 14:18:08 -06:00
Jafar Al-Gharaibeh
23b43aac0f
Merge pull request #10290 from donaldsharp/nhrp_topo_queries 
Nhrp topo queries
 2022-01-07 14:00:50 -06:00
Jafar Al-Gharaibeh
c514ba5e66
Merge pull request #10300 from donaldsharp/support_bundle_fix 
tools: Run formatter over generate_support_bundle.py
 2022-01-07 13:13:14 -06:00
Donald Sharp
758999b3e0 tests: Ensure packets have a chance to arrive in test_multicast_pim_sm_topo4.py 
The test is doing this:

a) gather interface data about packets sent
b) shut interface
c) no shut interface
d) gather interface data about packets sent
e) compare a to d and fail if packets sent/received has not incremented

The problem is, of course, that under heavy system load insufficient time
might not have passed for packets to be sent between c and d.  Add up to
35 seconds of looking for packet data being incremented else heavily
loaded systems may never show that data is being sent.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-01-07 11:03:15 -05:00
Donald Sharp
715d3774aa test: Cleanup via black the test_multicast_pim_sm_topo4.py 
The test needed some cleanup via black formatting.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-01-07 11:03:15 -05:00
Donald Sharp
0b01a0bbc4 tests: Rename poorly named function 
verify_pim_interface_traffic *fetches* the pim
traffic data.  Rename the function to what it
actually does

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-01-07 11:03:15 -05:00
Mark Stapp
9f9efe7efa
Merge pull request #10286 from ton31337/fix/rfc6938 
bgpd: Deprecate DPA, ADVERTISER and RCID_PATH path attributes
 2022-01-06 12:18:30 -05:00
Donatas Abraitis
812a20dc57 bgpd: Deprecate DPA, ADVERTISER and RCID_PATH path attributes 
rfc6938

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-06 17:10:31 +02:00
Donatas Abraitis
dd6c4dc371
Merge pull request #10283 from sworleys/Alpline-Git-Rev 
docker: update alpine build enable set own version
 2022-01-06 15:37:34 +02:00
Donald Sharp
667cfdc824 tools: Run formatter over generate_support_bundle.py 
The generate_support_bundle.py script needs some
reformating to meet our standards

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-01-06 08:18:30 -05:00
Donald Sharp
45a4f371eb
Merge pull request #10226 from bisdn/jogo_fix_support_bundle_backup 
tools: fix backing up previous logs in generate_support_bundle.py
 2022-01-06 08:17:12 -05:00
Donald Sharp
3d162a6950
Merge pull request #10284 from ton31337/fix/adjust_rfc4486 
bgpd: Adjust symbolic names for cease notifications according to rfc4486
 2022-01-06 07:49:00 -05:00
anlan_cs
fc539216ce build: add "--with-service-timeout" in configure.ac 
On lower CPU with lots of static routes, it will cost more than 2
minutes.

2 minutes is the default timeout value, we can adjust it by configure:
./configure --with-service-timeout=<digit>

Signed-off-by: anlan_cs <anlan_cs@tom.com>
 2022-01-06 07:42:36 -05:00
Donald Sharp
7747e99cf4
Merge pull request #10287 from ton31337/fix/rfc7196 
bgpd: Increase maximum supress threshold for dampening to 50,000
 2022-01-06 07:34:45 -05:00
Donald Sharp
60b5ff877a tests: Fixup output that was incorrect in nhrp_topo 
The nhrp_topo test sets up some infrastructure and
was displaying the commands it was outputting
incorrectly.  Fix this.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-01-06 07:33:11 -05:00
Donald Sharp
168c2922e0
Merge pull request #10296 from anlancs/fix-doc-version 
doc: minor grammar correction
 2022-01-06 07:26:28 -05:00
Donald Sharp
dca7ea2e02
Merge pull request #10297 from ton31337/fix/gr_can_be_0 
bgpd: Graceful Restart restart-time can be 0
 2022-01-06 07:26:03 -05:00
Donatas Abraitis
dcbebfd3ff bgpd: Graceful Restart restart-time can be 0 
Using with LLGR, this should be allowed setting GR restart-time timer to 0,
to immediately start LLGR timers.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-06 11:24:48 +02:00
anlan_cs
fa60c38863 doc: minor grammar correction 
Need one empty line.

Signed-off-by: anlan_cs <anlan_cs@tom.com>
 2022-01-06 03:28:55 -05:00
Donatas Abraitis
4f5b13b504
Merge pull request #10291 from mjstapp/fix_topo_doc_reqs 
docs: clarify topotest requirements
 2022-01-06 10:14:32 +02:00
Donatas Abraitis
a30fec23f8 bgpd: Increase maximum supress threshold for dampening to 50,000 
rfc7196 recommends:

In addition, BGP implementations have an internal constant, which we
   will call the 'maximum penalty', and the current computed penalty may
   not exceed it.

Router Maximum Penalty:  The internal constant for the maximum
      penalty value MUST be raised to at least 50,000.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-06 10:09:05 +02:00
Donatas Abraitis
0ac7452334 bgpd: Adjust symbolic names for cease notifications according to rfc4486 
The following subcodes are defined for the Cease NOTIFICATION
   message:

      Subcode     Symbolic Name

         1        Maximum Number of Prefixes Reached
         2        Administrative Shutdown
         3        Peer De-configured
         4        Administrative Reset
         5        Connection Rejected
         6        Other Configuration Change
         7        Connection Collision Resolution
         8        Out of Resources

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2022-01-06 10:07:41 +02:00
Christian Hopps
d76a3c5165
Merge pull request #10294 from opensourcerouting/topotests-nhrp-require-5.0 
topotests: require Linux 5.0 for NHRP
 2022-01-05 22:25:07 -05:00
David Lamparter
fbfdb4f23a topotests: require Linux 5.0 for NHRP 
It fails on 4.19, so let's go minimum 5.0 for the time being.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2022-01-05 21:00:40 +01:00
Mark Stapp
fd23ce2c01 docs: clarify topotest requirements 
The developer docs weren't clear about some pre-reqs.

Signed-off-by: Mark Stapp <mstapp@nvidia.com>
 2022-01-05 10:27:17 -05:00
Russ White
cd764511e6
Merge pull request #10208 from adrianomarto/master 
Babel configuration parameter fixes
 2022-01-05 10:10:23 -05:00
Russ White
d962e875fe
Merge pull request #10260 from ton31337/feature/bgp_llgr_helper_mode 
bgpd: Implement LLGR helper mode
 2022-01-05 10:08:31 -05:00
Stephen Worley
3728cc8e12 docker: update alpine build enable set own version 
Add ability to set your own env for the version of the docker
container alpine image. This is useful for applications like GNS3
who pin a specific version to look for when they boot up. When you build
locally to test your code you can just set the version to 0 so you don't
have to update configs/scripts looking for a specific image version.

Also fix a shebang in docker start for alpine.

Signed-off-by: Stephen Worley <sworley@nvidia.com>
 2022-01-04 13:14:51 -05:00
Donald Sharp
3f6548c542
Merge pull request #10274 from anlancs/fix-spell-error-bfd 
bfdd: correct one spelling error of comment
 2022-01-02 17:57:46 -05:00
anlan_cs
5498a9f13d bfdd: correct one spelling error of comment 
Signed-off-by: anlan_cs <anlan_cs@tom.com>
 2021-12-31 05:32:49 -05:00
anlan_cs
9dee14bdb8 tools: cleanup route convertion from null0/Null0 to blackhole 
Signed-off-by: anlan_cs <anlan_cs@tom.com>
 2021-12-31 00:59:22 -05:00
Russ White
074ad7cb59
Merge pull request #10219 from donaldsharp/l3vpn_to_bgp_vrf_fixes 
tests: Further fix bgp_l3vpn_to_bgp_vrf
 2021-12-30 18:42:21 -05:00
Donatas Abraitis
dabca69ee7 tests: Add basic BGP Long-lived Graceful restart tests 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-12-28 16:35:57 +02:00
Donatas Abraitis
7f8a9a24a9 bgpd: Change default long-lived graceful restart stale timer to 0 seconds 
That means the feature is off by default.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-12-28 16:08:00 +02:00
Donatas Abraitis
1479ed2fb3 bgpd: Implement LLGR helper mode 
Tested between GoBGP and FRR (this commit).

```
┌───────────┐             ┌────────────┐
│           │             │            │
│ GoBGPD    │             │ FRRouting  │
│ (restart) │             │            │
│           │             │            │
└──────┬────┘             └───────┬────┘
       │                          │
       │                          │
       │                          │
       │     ┌───────────┐        │
       │     │           │        │
       │     │           │        │
       └─────┤ FRRouting ├────────┘
             │ (helper)  │
             │           │
             └───────────┘

// GoBGPD
% cat /etc/gobgp/config.toml
[global.config]
    as = 65002
    router-id = "2.2.2.2"
    port = 179

[[neighbors]]
    [neighbors.config]
        peer-as = 65001
        neighbor-address = "2a02🔤:123"
    [neighbors.graceful-restart.config]
        enabled = true
        restart-time = 3
        long-lived-enabled = true
    [[neighbors.afi-safis]]
        [neighbors.afi-safis.config]
            afi-safi-name = "ipv6-unicast"
        [neighbors.afi-safis.mp-graceful-restart.config]
            enabled = true
        [neighbors.afi-safis.long-lived-graceful-restart.config]
            enabled = true
            restart-time = 10
    [[neighbors.afi-safis]]
        [neighbors.afi-safis.config]
            afi-safi-name = "ipv4-unicast"
        [neighbors.afi-safis.mp-graceful-restart.config]
            enabled = true
        [neighbors.afi-safis.long-lived-graceful-restart.config]
            enabled = true
            restart-time = 20

% ./gobgp global rib add -a ipv6 2001:db8:4::/64
% ./gobgp global rib add -a ipv6 2001:db8:5::/64 community 65535:7
% ./gobgp global rib add -a ipv4 100.100.100.100/32
% ./gobgp global rib add -a ipv4 100.100.100.200/32 community 65535:7
```

1. When killing GoBGPD, graceful restart timer starts in FRR helper router;
2. When GR timer expires in helper router:
   a) LLGR_STALE community is attached to routes to be retained;
   b) Clear stale routes that have NO_LLGR community attached;
   c) Start LLGR timer per AFI/SAFI;
   d) Recompute bestpath and reannounce routes to peers;
   d) When LLGR timer expires, clear all routes on particular AFI/SAFI.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-12-28 16:07:59 +02:00
Donald Sharp
5086cc1c66
Merge pull request #10254 from ton31337/fix/typo 
bgpd: Fix typo in bgp_aggr_community_hash_alloc()
 2021-12-27 08:21:49 -05:00
Igor Ryzhov
5af4491693
Merge pull request #10261 from ton31337/fix/remove_if0 2021-12-24 01:09:41 +03:00
Donatas Abraitis
b7f0afa9a9
Merge pull request #10259 from anlancs/add-assert-ospf6 
ospf6d: clean coverity warning of possible null pointer
 2021-12-23 14:50:47 +02:00
Donatas Abraitis
f5827f3689 bgpd: Drop if 0 blocks 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-12-23 14:41:11 +02:00
Igor Ryzhov
63011ec1c5
Merge pull request #10256 from anlancs/cleanup-zebra_evpn_mac_add 
zebra: cleanup checking zebra_evpn_mac_add function's return value
 2021-12-23 13:10:18 +03:00