Commit Graph

5311 Commits

Author SHA1 Message Date
Russ White
35f8fe3b32 Merge pull request #489 from donaldsharp/sudoers
*: Remove ability to install frr_sudoers for 2.0
2017-05-09 19:48:33 -04:00
Donald Sharp
5490641755 *: Remove ability to install frr_sudoers
If the user were to uncomment last line
and allow VTYSH_SHOW to be used as a non-root
account, this would allow arbitrary command completion
inside of vtysh via multiple -c ... -c .... lines

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-09 16:18:04 -04:00
Lou Berger
399598bf6b bgpd: add back unicast option to 'address-family vpnv(4&6)' Issue #459 2017-05-09 14:52:54 -04:00
Jafar Al-Gharaibeh
fba10244ef Merge pull request #461 from donaldsharp/poll_2.0
Poll 2.0
2017-05-04 13:09:25 -05:00
David Lamparter
ff871f86e1 pimd: fix clang warning
pimd/pim_sock.c:178:13: error: implicit conversion from
	'int' to 'char' changes value from 148 to -108
	[-Werror,-Wconstant-conversion]
    ra[0] = 148;

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-05-04 10:26:12 -04:00
Donald Sharp
a03d3c8040 lib: Rename HAVE_POLL to prevent conflicting #defines
Rename HAVE_POLL to HAVE_POLL_CALL, when compiling with
snmp and poll enabled this was causing issues.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 10:24:25 -04:00
Sam Tannous
7e5e32b62f Remove uncalled function causing compiler error
Ticket: CM-16086
Reviewed By: sharpd
Testing Done: Built debs and tested on hardnode

With snmp enabled, this function was causing compiler
errors since it was not being called.  Removed it.

Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com>
2017-05-04 10:19:57 -04:00
Donald Sharp
c0fee6efb6 Merge pull request #429 from hwchiu/fix_clang_sa
Fix some warnings by clang static analyzer
2017-05-02 11:45:42 -04:00
Hung-Weic Chiu
4da93320c7 Revert "Fix the "Use-after-free" of clang SA."
- This's the wrong way to fix this problem.
- Since the "TAILQ_FIRST()" always return diferent pointer as we call "TAILQ_REMOVE()", the clang static analyzer can't detect this behavior.
- Ignore this warning and keep files identical to its original one.

This reverts commit 5d6cc38ca3.

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-05-02 00:33:15 +00:00
Hung-Weic Chiu
c604467a08 Fix the "Uninitialized argument value" of clang SA.
Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-04-29 15:35:32 +00:00
Hung-Weic Chiu
3a6570a1f1 Fix the "Dead assignment" of clang SA.
- Remove duplicated assignemt.
- Remove unused initialized.

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-04-29 15:25:32 +00:00
Hung-Weic Chiu
5d6cc38ca3 Fix the "Use-after-free" of clang SA.
- Set the pointer to NULL after free it, otherwise the pointer will be accessed again. (since not null)

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-04-29 15:02:31 +00:00
Hung-Weic Chiu
d8d58e9839 Fix the memory leak
- free the memory for all cases.

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-04-29 14:20:15 +00:00
Martin Winter
bedc9ac10f Merge pull request #2 from silasm/rpm-fixes-2.0
redhat: use %initsystem check that works when chrooted
2017-04-28 14:03:40 -07:00
Donald Sharp
650532d3d5 Merge pull request #419 from hwchiu/update-the-docs-of-ubuntu
Update the docs of ubuntu 12.04/14.04
2017-04-28 11:10:47 -04:00
smccroskey
20701ca33a redhat: use %initsystem check that works when chrooted
`systemctl' returns different, non-useful output while in a chroot.
Switch to checking if /sbin/init is a symlink to the systemd binary.
With this change the build works in a mock chroot.

Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
2017-04-28 03:04:50 -07:00
Hung-Wei Chiu
362de4a621 update doc of ubuntu 12.04
1. modify the prefix to /usr (which is hard-code in /etc/init.d/frr)
2. install init.d related files.
2017-04-27 23:30:56 +08:00
Hung-Wei Chiu
500e13fea3 Update 14.04 docs to support init.d service
1. Configure the prefix to /usr  (frr script hard-code those path in /etc/init.d/frr)
2. Install the service file to /etc/init.d
2017-04-27 23:14:23 +08:00
Donald Sharp
e12ff52ab3 Merge pull request #415 from hwchiu/fix_ubuntu16.04
Update Building_FRR_on_Ubuntu1604 to make it support systemd
2017-04-27 08:31:16 -04:00
Hung-Wei Chiu
8a77d75b8a Update Building_FRR_on_Ubuntu1604.md
Fix typo
2017-04-27 11:22:15 +08:00
Hung-Wei Chiu
8399fd9d36 Update Building_FRR_on_Ubuntu1604.md
1.  Modify the configure prefix (since there some hard coded path in **/usr/lib/frr/fr**
2.  Install the systemd service config
2017-04-27 11:10:36 +08:00
Martin Winter
f9e0332e10 redhat: fix README for rpm package build
- correct requirements
- add comment on bison 2.7 installation on CentOS 6

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-19 18:45:03 -07:00
Martin Winter
6dc47763f4 redhat: redirect reload function in frr init script to restart if reload script is not installed (fixes systemctl restart)
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-19 18:41:45 -07:00
Martin Winter
362bca980c redhat: fix duplicate Requires: line in spec file
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-19 18:39:49 -07:00
Martin Winter
b387c334d4 redhat: Fix BuildRequires for FRR/2.0 and duplicate /etc/frr/daemons
- add make & gcc
- remove autoconf and automake (not needed to build from src.rpm)
- fix texi2html version detection for case when no texi2html is installed (broke yum-builddep)
- fix duplicate listing of /etc/frr/daemons

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-19 18:12:10 -07:00
Martin Winter
3630ef2d24 redhat: Update documentation for RPM build and usage
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-17 18:45:50 -07:00
Martin Winter
19ced9a4b8 redhat: fix upgrade script (%postun), remove invalid mpls package selection (it's always built and auto detected), add ldpd
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-17 18:34:32 -07:00
Martin Winter
2cdd3d94fc redhat: Add frr.service file for redhat based systemd systems (using init script)
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-17 18:17:16 -07:00
Martin Winter
6491e6303e Merge pull request #370 from donaldsharp/as_path_fix
bgpd: Fix 'set as-path prepend last-as 10'
2017-04-17 14:46:28 -07:00
Martin Winter
178b92ceb1 redhat: /etc/frr/daemons needs to be marked as no replace config to be save from overwriting
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-15 03:29:34 -07:00
Martin Winter
c2953ac5d6 redhat: Add (combined) init.d script for FRR with daemon selection based on /etc/frr/daemons
- Provide new frr init script
- Remove separate per-deamon init.d scripts

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-15 03:13:07 -07:00
Martin Winter
36d85ca8e3 watchfrr: Remove the HAVE_CUMULUS around the watchfrr.started file. It's always useful
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-15 02:00:15 -07:00
Donald Sharp
5cf5f2033b bgpd: Fix 'set as-path prepend last-as 10'
The route-map compilation function was comparing < 10
instead of <= 10.  While the cli was accepting 1-10.

Fix:
!
route-map FOO permit 44
 set as-path prepend last-as 10
!

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-14 20:05:48 -04:00
Martin Winter
4d3bac5b14 redhat: Add python2 build requirement to pythontools sub package
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-14 02:21:44 -07:00
Martin Winter
df1a7ae4ce redhat: Fix previously added centos6/redhat6 check
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-14 02:20:31 -07:00
Martin Winter
33fdbd5efb redhat: Fix install (daemon selection) and make postun scripts compatible with fedora
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-14 01:28:13 -07:00
Martin Winter
41b86ba421 redhat: Always disable PIMd on CentOS 6 and RedHat 6 systems as they are too old to correctly support the protocol
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 18:54:58 -07:00
Martin Winter
386fcd12a4 redhat: Move frr-reload python script to it's own sub package to avoid the python2 requirement for main frr package
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 17:34:26 -07:00
Martin Winter
a88f3f42f9 redhat: Don't set file attributes for symlinks
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 17:33:24 -07:00
Martin Winter
1b2b123042 redhat: Fix ospf6d typo in frr.spec.in
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 15:00:16 -07:00
Martin Winter
6e38a83973 Merge pull request #366 from pichuang/fixed_add_group
Fixed some document typo
2017-04-13 14:52:16 -07:00
Phil Huang
be9665641d Clean installation guide with Debian/Ubuntu
Signed-off-by: Phil Huang <phil_huang@edge-core.com>
2017-04-13 21:20:53 +08:00
Phil Huang
7caef08c84 Add user frr into group frrvty
Signed-off-by: Phil Huang <phil_huang@edge-core.com>
2017-04-13 19:16:11 +08:00
Martin Winter
58f20b90ee redhat: Fix dependencies for rpm package
- Add bison, flex & autoconf
- Remove systemd for systems without it (i.e. CentOS 6)
- Update doc to reflect dependencies

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 20:23:18 -07:00
Martin Winter
9a581ae412 redhat: Remove tab's with spaces in frr.spec.in to make it better readable
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 19:10:35 -07:00
Martin Winter
94c0033565 redhat: Replace tab's with spaces in README
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 18:54:40 -07:00
Donald Sharp
81a37d8911 Merge pull request #365 from opensourcerouting/snap-doc-fixes
snapcraft: Improve README.usage.md based on feedback received
2017-04-12 21:12:26 -04:00
Martin Winter
2a3a819a9c snapcraft: Improve README.usage.md based on feedback received
- Fix snap connect (it's now called core, not ubuntu-core)
- Add section on MPLS configuration
- Add FAQ topic on ospfd/ospf6d crashing before privs are assigned to snap
- Add pointer to official webpage

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 16:00:43 -07:00
Donald Sharp
902726b81f doc: Cleanup 'Build the Software'
The frrouting.org web page:
https://frrouting.org/manual/Build-the-Software.html#Build-the-Software
is built from doc/install.texi.  The output on this page is a bit
missleading, let's clean it up some.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-07 17:20:32 -04:00
Martin Winter
3e71b5d907 Release: FRR-2.0
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-01 22:22:47 -07:00