David Lamparter
b37ccace1e
tests: properly locate files in builddir
...
test_cli.refout is written by configure into the build directory, thus
we need a little special glue to find it correctly.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:19 +02:00
David Lamparter
74dc19a2f5
build: move vtysh & manpage listings to subdir.am
...
Since we're now building through one large Makefile, we can easily put
things with their daemons and crossreference nicely.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:19 +02:00
David Lamparter
aad24c5ba6
build: remove common.am
...
Fold things into where they make sense.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:26:54 +02:00
David Lamparter
f8948c1e02
build: include helper Makefiles in dist
...
Need these to have "make" work in subdirectories.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:26:54 +02:00
David Lamparter
a1286a3245
build: non-recursive tests
...
May SUBDIRS rest in pieces... er, peace.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:26:54 +02:00
David Lamparter
8b7668ecce
build: non-recursive vtysh
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:26:54 +02:00
David Lamparter
84d837b75d
build: non-recursive bgpd & rfp
...
Note: no more --with-rfp-path on configure - badly messing with the
build system like this really isn't how to do a conditional external
dependency.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:25:59 +02:00
David Lamparter
e10cfdaf51
bfdd: fix garbage "port" string
...
bfd_recv_ipv4() is getting an uninitialized buffer passed in as port,
and then checks it without clearing it first. Thus we can end up
leaving garbage data in it.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 20:34:35 +02:00
David Lamparter
4f4060f6ab
*: fix clang-6 SA warnings
...
I don't see these in CI, but my local clang-6 does emit warnings for
these.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 20:34:35 +02:00
David Lamparter
f70247febe
lib: fix SA warning in skiplist code
...
Clang was thinking the random level could be negative. (And, no, I
couldn't figure that out by reading its output... trial and error this
was.)
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 20:34:35 +02:00
David Lamparter
a43ad4fef8
lib, ldpd: fix SA warnings from TAILQ oddness
...
Add a TAILQ_POP_FIRST so Clang understands it's the same item that is
getting removed from the list.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 20:34:32 +02:00
Donald Sharp
714e135429
Merge pull request #2875 from opensourcerouting/fabricd
...
OpenFabric support
2018-09-08 13:48:48 -04:00
David Lamparter
37258ed97f
Merge pull request #2991 from donaldsharp/mac_compiling
...
Mac compiling cleanups
2018-09-08 19:45:18 +02:00
David Lamparter
3be6e41147
isisd: silence SA warnings
...
As suggested by Renato Westphal.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 18:25:45 +02:00
Donald Sharp
7c70dc57e0
vtysh: Actually make the new_completion function match
...
The new_completion function was not declared the same
way the rl_attempted_completion_function pointer was.
The only difference was a 'const char *' -vs- 'char *'
So convert it over.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-08 12:00:17 -04:00
Donald Sharp
8860ffdc09
vtysh: Add code to isolate append_history
...
The append_history function in lib readline appears to
not be universally available across all of the esoteric
platforms we may want to compile on. As such
provide a way to gracefully do nothing.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-08 12:00:17 -04:00
Donald Sharp
afc9534f67
lib: Detect if pthread_condattr_setclock is available
...
Auto-detect if pthread_condattr_setclock is available and if
it is not allow the code to compile around the issue.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-08 12:00:17 -04:00
Donald Sharp
7b90f00cce
lib: Cleanup include of link.h
...
We need link.h for the HAVE_DLINFO_LINKMAP, so include
it if we need it for that code path.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-08 12:00:17 -04:00
David Lamparter
6317894ef3
Merge pull request #2989 from donaldsharp/static_debug
...
Static debug
2018-09-08 17:38:48 +02:00
David Lamparter
d1490fb796
Merge pull request #2988 from donaldsharp/more_debugs
...
zebra: Modify nexthop checks to report inactive a bit more
2018-09-08 17:36:18 +02:00
David Lamparter
18b43e554e
Merge pull request #2981 from donaldsharp/v6_vxlan_bug
...
zebra: Fix RB-Tree storage comparison function for v6
2018-09-08 17:35:20 +02:00
David Lamparter
5af18c4126
Merge pull request #2982 from donaldsharp/smux_h
...
lib: Add missing smux.h to `make distrib` results
2018-09-08 17:13:45 +02:00
Martin Winter
248c86da11
bgpd: Fix for large AS paths which are split into segments
...
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2018-09-07 14:43:11 -07:00
Martin Winter
cb50f399db
Merge pull request #2949 from donaldsharp/removal
...
ospf6d: Remove deprecated code after 1 year
2018-09-07 19:04:51 +02:00
Quentin Young
dfeef149e9
Merge pull request #2987 from pacovn/Coverity_1473088_ovf_array_index_write
...
lib: array index check (Coverity 1473088)
2018-09-07 11:40:31 -04:00
Donald Sharp
aaf8c96fa9
sharpd: Fix missing 'show debug' command
...
The sharp daemon was not properly handling 'show debug'
commands. Fix.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-07 07:05:35 -04:00
Donald Sharp
e60b527e66
staticd: Fix 'show debug static" command
...
'show debugging' is returning a Command incomplete
error message as that it is being sent to staticd
and staticd has no knowledge of it, fix this.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-07 07:01:19 -04:00
F. Aragon
aa1bac3039
lib: array index check (Coverity 1473088)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-09-07 11:20:45 +02:00
Donald Sharp
34815ea334
zebra: Modify nexthop checks to report inactive a bit more
...
Debugging inactive nexthops in zebra can be quite difficult
and non-obvious what has gone wrong. Add detailed rib
debugs for the cases where we decide that a nexthop is
inactive so that we can more easily debug a reason
for the failure.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:24:00 -04:00
Quentin Young
364fed6b07
zebra: fix includes
...
Add and remove error related includes as necessary.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-06 20:56:41 +00:00
Quentin Young
c98d5ce810
bgpd: remove duplicate log_ref_add()
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-06 20:56:41 +00:00
Quentin Young
5e1343f671
lib: PRIu32 in log.h
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-06 20:56:41 +00:00
Quentin Young
ade6974def
*: style for flog_warn conversions
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-06 20:56:41 +00:00
Quentin Young
9df414feeb
zebra: flog_warn conversion
...
Convert Zebra to user error subsystem.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-06 20:56:38 +00:00
Donald Sharp
dbb93f1b90
ospfd: Convert ospf_sr.c to use error-card subsystem.
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
668e8a1183
ospfd: Modify ospf_spf.c to use error-card subsystem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
239697e3b2
ospfd: Convert ospf_ri to use error-code subsystem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
14c5ef90b7
ospf_nsm.c: Convert warn->err and use error-code
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
ed59abd5c7
ospfd: Fix warn -> debug for neighbor add
...
If we detect we already have a neighbor, no need to
re-add so no need to warn since we do not do anything with
the data.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
13ab4921b1
ospfd: Convert ospf_lsa.c to use new error-card Syntax
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
78912b1f80
ospfd: Convert ospf_asbr.c to use error-codes subsystem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
733fb9177f
ospfd: Modify ospf_abr.c to use new error-code subsystem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
89f60109a7
ospfd: Convert ospf_ext.c to use new error-code subsystem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
542a208f3a
ospfd: Add OSPF_WARN_LSA_INSTALL_FAILURE error code
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
1dd58cc811
ospfd: Modify ospf_ri.c to use new error-code subsystem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
5578845690
ospfd: Convert opsfd.c to use new error-code subysstem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
2c72cf2af8
ospfd: Convert ospf_te.c to use new error-card subsystem
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
85c9b43949
ospfd: Add OSPF_WARN_OPAQUE_REGISTRATION
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
34f74c7a37
lib: Convert ospf_opaque.c to use the err-card system
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00
Donald Sharp
c9cc11f669
ospfd: Modify ospf_packet.c to use new error-cards subsystem
...
Signed-off-by: Donald sharp <sharpd@cumulusnetworks.com>
2018-09-06 20:50:58 +00:00