Commit Graph

13160 Commits

Author SHA1 Message Date
vishaldhingra
6d53d7b1af zebra: vrf aware routmap is missing in Zebra #2802(Part 2 of 4)
Function parameter replacement of using zvrf instead of vrf_id

Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:46:55 -07:00
vishaldhingra
ac6eebce50 zebra: vrf aware routmap is missing in Zebra #2802(Part 1 of 4)
Work to handle the route-maps, namely the header changes in zebra_vrf.h
 and the mapping of using that everywhere

 Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:44:55 -07:00
Lou Berger
b3c8d34291
Merge pull request #3032 from donaldsharp/bgp_info
`struct bgp_info` to `struct bgp_path_info`
2018-10-11 09:17:31 -04:00
Donatas Abraitis
1de2762153 bgpd: Check if route-map really exists before applying to the peer
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2018-10-11 10:56:12 +03:00
Donald Sharp
8f7bfe318b
Merge pull request #3153 from adharkar/frr-scount
bgpd: Incorrect sent prefix count for a split subgroup
2018-10-10 15:42:20 -04:00
Ameya Dharkar
0ab7b206a6 bgpd: Incorrect sent prefix count for a split subgroup
When a subgroup splits to form a new subgroup because of policy changes
for a peer, new subgroup copies adj out(state about advertised routes)
from the parent subgroup. At the same time, it should also copy
scount(advertised prefix count) to the new subgroup for the count to be
in sync with the adj_out for the subgroup.

Signed-off-by: Ameya Dharkar <adharkar@vmware.org>
2018-10-10 11:34:40 -07:00
Quentin Young
fa8875b922
Merge pull request #3155 from opensourcerouting/building_instructions
doc: update building instructions
2018-10-10 14:18:45 -04:00
Quentin Young
3f815a1ed1
Merge pull request #3159 from pguibert6WIND/doc_draft_bgp
doc: fix warning of doc compilation with bgp draft
2018-10-10 14:15:15 -04:00
Renato Westphal
e7fb64387c
Merge pull request #3154 from donaldsharp/bgp_mem_lem
Bgp mem issue with martian address interface strings
2018-10-10 13:08:28 -03:00
Renato Westphal
dde90f1e7c doc: simplify build instructions
Remove all --enable-xxx configuration flags for features that are enabled
by default.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Renato Westphal
345c140ec2 doc: update build instructions for Debian 9
The instruction to checkout to the stable/3.0 branch doesn't belong
here.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Renato Westphal
9580f50deb doc: remove LibXML from the list of dependencies
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Donald Sharp
8a7599cd27
Merge pull request #3145 from pguibert6WIND/ipv6nexthop
bgpd: in case nexthop is ipv6, set nh attribute flag in mpls vpn case
2018-10-10 10:08:01 -04:00
Philippe Guibert
75cd35c697 bgpd: in case nexthop is ipv6, set nh attribute flag in mpls vpn case
In mpls vpn import/export, the nexthop attribute should also be
recognised for ipv6 too.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-10 13:13:09 +02:00
Philippe Guibert
49606d5872 doc: fix warning of doc compilation with bgp draft
Some draft ietf are not handle by :rfc: keyword. A workaround is
proposed, like it has been done for flowspec.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-10 11:50:38 +02:00
Donald Sharp
b91299153d bgpd: Cleanup memory leak with the martian address intf string
When cleaning up a interface string, from the linked list we were
dropping the name pointer which held the allocated martian address
intf string.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 20:19:01 -04:00
Donald Sharp
330cec3de0 bgpd: Use a more appropriate memory type for a string
Track the memory type associated with the bartian address
interface a bit better, instead of using MTYPE_TMP.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 20:16:37 -04:00
Donald Sharp
121e245d4f bgpd: Cleanup warnings issued by CI system from these changes
Modify code to cleanup warnings issued by the CI system from
this series of changes.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:26:30 -04:00
Donald Sharp
40381db785 bgpd: Rename various variable names to something more appropriate
ri -> pi
bi -> bpi
info -> path
info -> rmap_path ( for routemap applications )

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:26:30 -04:00
Donald Sharp
9b6d8fcf29 bgpd: Convert binfo to path
Convert the binfo variable to path.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:26:30 -04:00
Donald Sharp
18ee831031 bgpd: Convert all bgp_info_XXX functions to bgp_path_XXX functions
Rename all bgp_info_XXX functions to bgp_path_XXX functions

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Donald Sharp
4b7e606625 bgpd: Convert struct bgp_info to struct bgp_path_info
Do a straight conversion of `struct bgp_info` to `struct bgp_path_info`.
This commit will setup the rename of variables as well.

This is being done because `struct bgp_info` is not descriptive
of what this data actually is.  It is path information for routes
that we keep to build the actual routes nexthops plus some extra
information.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Donald Sharp
1defdda8e8 bgpd: Convert BGP_INFO_XXX to BGP_PATH_XXX
Search and replace all BGP_INFO_XXX to BGP_PATH_XXX

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Donald Sharp
360660c643 bgpd: Rename some BGP_PATH_XXX to BGP_PATH_SHOW_XXX
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-09 14:14:25 -04:00
Olivier Dugeon
13894ce894
Merge pull request #3077 from rgirada/ospf_2980_fix
ospfd: Resolved the inconsistency behavior when “default-info origina…
2018-10-09 19:07:33 +02:00
Christian Franke
490a6fc716 isisd: don't add deprecated bfd command 2018-10-09 17:59:46 +02:00
Quentin Young
22bca40d60
Merge pull request #3037 from patrasar/2851
bgpd: remove ip prefix from as-path, <large,ext>community-list
2018-10-09 11:56:26 -04:00
Olivier Dugeon
c7aa8432f2
Merge pull request #3143 from rgirada/fix_3124
ospfd: default route got flushed after lsa refresh timer.
2018-10-09 17:52:49 +02:00
rgirada
1fb93326ad ospfd: issue with the "default-information originate always" command #2980
Made changes such that message wont be sent to zebra to validate default
route existence  if user configured with “always”.

Signed-off-by: rgirada <rgirada@vmware.com>
2018-10-09 02:52:27 -07:00
Quentin Young
3156b2d58d
Merge pull request #3132 from toreanderson/fix_routemap_prefixlist_match_doc
doc: correct route map match for prefix lists
2018-10-08 14:08:06 -04:00
rgirada
a6b4e1fded ospfd: default route got flushed after lsa refresh timer.
Default route type is not considered while  processing  lsa
refresh timer  expiry   which intern makes it flushed from lsdb.

Signed-off-by: rgirada <rgirada@vmware.com>
2018-10-07 23:22:58 -07:00
Russ White
4d43d33d25
Merge pull request #3125 from dslicenc/linklocal-nht
bgpd: allow nht registration on ipv6 link-local addresses
2018-10-07 21:47:01 -04:00
Russ White
62edc9c9e3
Merge pull request #3133 from qlyoung/bgp-fix-broken-show-community-cmds
fix broken bgp community show cmds
2018-10-07 21:45:33 -04:00
Donald Sharp
19bd3dffc1 bgpd: Do a bit better job of tracking the bgp->peerhash
When we add/remove peers we need to do a bit better job
of tracking them in the bgp->peerhash.

1) When we have the doppelganger take over, make sure the
winner is the one represented in the peerhash.

2) When creating the doppelganger, leave the current one
in place instead of blindly replacing it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-07 20:55:52 -04:00
Donald Sharp
cc4d4ce822 bgpd: Cleanup peer->su handling
Cleanup calls where we were passing in the su for
peer creation a tiny bit.

Creating a peer from the cli will always have a conf_if *or*
a su but not both. While a doppelganger will have both.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-07 20:55:52 -04:00
Donald Sharp
825d98347d bgpd: Add ability to dump the bgp peerhash
The bgp->peerhash is a secretive bit of data that we use
to quickly lookup data about peers.  Unfortunately
since we had not way to look at it, we had no way
of knowing if it had gotten in or out of sync.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-07 20:55:52 -04:00
Jafar Al-Gharaibeh
1c7e6ef3d8
Merge pull request #3135 from donaldsharp/zapi_handler_cabbage
zebra: Cleanup call parameters to some functions
2018-10-06 00:20:12 -05:00
Jafar Al-Gharaibeh
41df11abc7
Merge pull request #3119 from pacovn/Coverity_1465497_dead_code
zebra: dead code (Coverity 1465497)
2018-10-06 00:18:52 -05:00
Donald Sharp
a393281d47 zebra: Cleanup unused file
The zebra_vxlan_null.c file is never used.  Let's remove
from our build system.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-05 10:00:52 -04:00
Christian Franke
a5eba4e9a5 isisd: Track BFD state and take down adjacency on failure
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:08:34 +02:00
Christian Franke
2815f817e5 isisd: Add debugging for BFD
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:08:23 +02:00
Christian Franke
ab880eaf30 isisd: Implement BFD replay function
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:08:18 +02:00
Christian Franke
20a42f0194 isisd: Register/deregister BFD peers for adjacencies
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:07:51 +02:00
Christian Franke
3015e3d15e isisd: Write BFD config
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:07:45 +02:00
Christian Franke
d56afe53aa isisd: Add a hook when writing interface config
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:31 +02:00
Christian Franke
215eccb0b8 isisd: Add BFD configuration commands
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:30 +02:00
Christian Franke
a5b5e946ce isisd: Replace isis_event_adjacency_state_change with a hook
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:28 +02:00
Christian Franke
52df822874 isisd: Register as BFD client
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:26 +02:00
Christian Franke
ad10378940 isisd: Add forward declaration of struct isis_route_info
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:22 +02:00
Christian Franke
a0d5840bb7 zebra_ptm: Add IS-IS and OpenFabric as protocols supporting BFD
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:04:27 +02:00