proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-13 22:57:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
24,679 Commits 4 Branches 191 Tags 125 MiB
63f7a3b910
Commit Graph

24679 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Igor Ryzhov
91895b15a9
Merge pull request #8703 from donaldsharp/ospf_tab 
ospfd: New code adds newline to log files
 2021-05-20 10:36:58 +03:00
Donatas Abraitis
3532ab1ffb
Merge pull request #8697 from idryzhov/fix-zebra-con 
zebra: fix possible uninitialized value
 2021-05-20 09:31:02 +03:00
Donald Sharp
bd7fb46e5b tests: Speedup ospf_sr_topo1 by over 100 seconds 
Add some basic timer operations to speed up convergence.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-05-19 16:01:01 -04:00
Mark Stapp
e804e2597c
Merge pull request #8700 from idryzhov/coverity 
fix a couple of coverity warnings
 2021-05-19 15:56:17 -04:00
Igor Ryzhov
71cc0c88de Revert "bgpd: When deleting a neighbor from a peer-group the PGNAME is optional" 
This reverts commit 2cbd181ac9.

We also have "no neighbor WORD peer-group" command and it's impossible
to distinguish between those two commands if PGNAME is optional.
 2021-05-19 22:41:08 +03:00
Donald Sharp
55370b9564 ospfd: New code adds newline to log files 
FRR is not using newlines in log messages.  Remove them.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-05-19 15:10:48 -04:00
Donald Sharp
8c70a46b65 pimd: Fix rare crash situation 
When running pim on an interface and that interface has
state and we move that interface into a different vrf
there exists a call path where we have not created the pimreg
device yet.  Prevent a crash in this rare situation.

Ticket: #2552763
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-05-19 14:48:11 -04:00
Donald Sharp
262649bd05 pimd: When bind fails give some extra data 
When bind to a socket fails, let's give some color so we can
understand and fix the issue.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-05-19 14:48:11 -04:00
Donald Sharp
d516382e12
Merge pull request #8645 from idryzhov/ospf6-redistribute-fixes 
ospf6 redistribution fixes
 2021-05-19 14:42:54 -04:00
Donald Sharp
b5ca4a47d8
Merge pull request #8678 from achernavin22/bgp_confed_peer_sort 
bgpd: recalc peer's sort after changing confed peers
 2021-05-19 14:33:22 -04:00
Donald Sharp
8863a71845
Merge pull request #8684 from kuldeepkash/multicast-sm-topo1 
tests: Fix for multicast_pim_sm test failure
 2021-05-19 14:28:48 -04:00
Donatas Abraitis
9f977b2def doc: Show BGP prefixes by community alias 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-05-19 18:20:08 +03:00
Donatas Abraitis
b15be1605a tests: Show BGP prefixes by community alias 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-05-19 18:11:39 +03:00
Donatas Abraitis
a70a28a577 bgpd: Show BGP prefixes by community alias 
This includes both community/large-community.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-05-19 18:11:38 +03:00
Olivier Dugeon
e55ee4b9ed
Merge pull request #8690 from idryzhov/ospf-fix-tlv-size 
ospfd: fix SID/Label Sub TLV size
 2021-05-19 16:16:35 +02:00
Igor Ryzhov
1f25f6c768
Merge pull request #8408 from Orange-OpenSource/TE 
ospfd: Correct Coverity defects
 2021-05-19 17:04:48 +03:00
Patrick Ruddy
f334254982
Merge pull request #8677 from idryzhov/isis-snmp-build-warning 
isisd: fix build warning and simplify code
 2021-05-19 14:39:47 +01:00
Igor Ryzhov
3558b8b8b4 pbrd: fix coverity warning 
CID 1500586

There was an attempt to fix it in 920bb6f7 but the commit didn't
actually fix the warning.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-19 16:24:21 +03:00
Igor Ryzhov
f96c2b6dc2 lib: fix coverity warnings 
CID 1504894

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-19 16:22:24 +03:00
Rafael Zalamena
c4aa00a776
Merge pull request #8693 from idryzhov/fix-bgp-bfd-reg 
bgpd: fix zebra bfd registration
 2021-05-19 09:23:28 -03:00
Olivier Dugeon
587a1dfa39
Merge pull request #8665 from volta-networks/fix_pathd_coverity 
pathd: Clean coverity issues after merge pathd link state feature.
 2021-05-19 14:16:00 +02:00
Donald Sharp
8a2b922c34 tests: Fixup some pylint warnings in test_multicast_pim_sm_topo2.py 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-05-19 08:04:50 -04:00
Igor Ryzhov
389faf93b7 zebra: fix possible uninitialized value 
Found by Coverity.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-19 14:59:00 +03:00
Donald Sharp
942f6d35d3
Merge pull request #8682 from idryzhov/fix-default-originate 
ospfd, ospf6d: fix "default-information originate" in non-existing vrf
 2021-05-19 07:03:47 -04:00
Olivier Dugeon
ea217b376f
Merge pull request #8667 from volta-networks/fix_pathd_cli_affinity 
pathd: Fix affinity command to exclude options to match implementation.
 2021-05-19 12:28:28 +02:00
Olivier Dugeon
8db278b5e3 ospfd: Correct Coverity defects 
When browsing or parsing OSPF LSA TLVs, we need to use the LSA length which is
part of the LSA header. This length, encoded in 16 bits, must be first
converted to host byte order with ntohs() function. However, Coverity Scan
considers that ntohs() function return TAINTED data. Thus, when the length is
used to control for() loop, Coverity Scan marks this part of the code as defect
with "Untrusted Loop Bound" due to the usage of Tainted variable. Similar
problems occur when browsing sub-TLV where length is extracted with ntohs().

To overcome this limitation, a size attribute has been added to the ospf_lsa
structure. The size is set when lsa->data buffer is allocated. In addition,
when an OSPF packet is received, the size of the payload is controlled before
contains is processed. For OSPF LSA, this allow a secure buffer allocation.
Thus, new size attribute contains the exact buffer allocation allowing a
strict control during TLV browsing.

This patch adds extra control to bound for() loop during TLV browsing to
avoid potential problem as suggested by Coverity Scan. Controls are based
on new size attribute of the ospf_lsa structure to avoid any ambiguity.

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
 2021-05-19 09:48:54 +02:00
Donatas Abraitis
2794d40202
Merge pull request #8688 from idryzhov/bgp-vrf-bind-priv 
bgpd: raise privs for SO_BINDTODEVICE
 2021-05-19 10:02:20 +03:00
Igor Ryzhov
6bfcd0f14a bgpd: fix zebra bfd registration 
If there's no default router configured at the moment when bgpd is
connected to zebra, bgpd is not registered as a BFD client.

We should do the registration regardless of the config existence.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-18 23:31:52 +03:00
Mark Stapp
b1ffa01dcd
Merge pull request #8686 from idryzhov/fix-doc-index 
doc: remove redundant index directives
 2021-05-18 15:33:48 -04:00
Donald Sharp
11d557869c build: Update configure.ac to reflect new master version 
That we are building towards.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-05-18 14:41:39 -04:00
Igor Ryzhov
bc298f5d49 ospfd: fix SID/Label Sub TLV size 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-18 21:00:41 +03:00
Javier Garcia
ac57e2c9b9 pathd: Clean coverity issues after merge pathd link state feature. 
Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
 2021-05-18 19:50:41 +02:00
Javier Garcia
839e6ce560 pathd: Fix affinity command to exclude options to match implementation. 
Including documentation update.

Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
 2021-05-18 18:39:41 +02:00
Renato Westphal
0376f8a48c
Merge pull request #8608 from Fredi-raspall/pr_isis_sr_anycast 
isisd: clear the N-flag in ext. reachability TLVs
 2021-05-18 11:35:58 -03:00
Olivier Dugeon
365215dd4b
Merge pull request #8133 from gpnaveen/ospf_basic_testcases 
tests: adding ospf basic 2 testcases.
 2021-05-18 16:26:12 +02:00
Donald Sharp
cd43ad3ea9
Merge pull request #8673 from LabNConsulting/chopps/ly2-again 
lib: libyang2 add missed conversion
 2021-05-18 10:21:51 -04:00
Igor Ryzhov
0def0c9fa3 bgpd: raise privs for SO_BINDTODEVICE 
The priv raise was incorrectly dropped in 97896a9.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-18 17:07:06 +03:00
Igor Ryzhov
dc47f2e726 doc: remove redundant index directives 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-18 15:29:59 +03:00
Patrick Ruddy
4006e41baf
Merge pull request #8646 from chiragshah6/mdev 
zebra: evpn check vni oper state in svi up/down event
 2021-05-18 11:45:56 +01:00
Fredi Raspall
249c445783 isisd: simplify node Sid handling 
Centralize the n-flag-clear processing to a single point.

Signed-off-by: Fredi Raspall <fredi@voltanet.io>
 2021-05-18 10:54:54 +02:00
Fredi Raspall
8f6a0d6402 isisd: clear the N-flag in ext. reachability TLVs 
If the n-flag-clear option is set in the configuration of a prefix
segment, clear the flag in the extended ip reachability TLVs.

RFCs 7794 and 8667 are not too strict on the setting / clearing the
N-flag in prefix SIDs. However, if there exists a cmd line option
to clear it, it should be cleared in the TLVs announced, as other
vendors do.

Signed-off-by: Fredi Raspall <fredi@voltanet.io>
 2021-05-18 10:54:11 +02:00
Donatas Abraitis
82689214b5
Merge pull request #8535 from opensourcerouting/zlog-rnode 
zebra: replace _rnode_zlog with %pZN ext
 2021-05-18 09:50:42 +03:00
nguggarigoud
bcce695415 tests : Adding 2 ospf asbr summary testcases. 
Test suite execution time is ~1 minutes.

Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
 2021-05-17 19:52:54 -07:00
nguggarigoud
8694dd78db tests: adding ospf basic 2 testcases. 
Test cases included are 1 ospf cost, 1 ospf mtu.

Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
 2021-05-17 19:23:15 -07:00
Christian Hopps
af1b88e990 lib: libyang2 add missed conversion 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-05-17 22:13:59 -04:00
Kuldeep Kashyap
f0cbb887f1 tests: Fix for multicast_pim_sm failure 
Test case test_verify_mroute_when_5_different_receiver_joining_same_sources_p0
is failing intermittently in master. Fixed the issue.

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2021-05-17 18:52:55 -07:00
Renato Westphal
5e6f6c964d
Merge pull request #8680 from idryzhov/rip-ripng-fix-crash 
ripd, ripngd: fix interface wakeup after shutdown
 2021-05-17 22:47:27 -03:00
Kuldeep Kashyap
ba00df52eb tests: Add bgp_gshut_topo1 suite 
1. Automated test cases to verify BGP Graceful Shutdown community functionality,
   with 2 different topologies.

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2021-05-17 17:49:10 -07:00
Igor Ryzhov
23929ec918 ospf6d: free "default-information originate" config when removing router 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-18 01:27:16 +03:00
Igor Ryzhov
c84bbb2ad0 ospf6d: fix crash when removing router from vrf that doesn't exist 
`listgetdata(listhead(list))` crashes for an empty list.

Reproducible with:
```
router ospf6 vrf doesntexist
 default-information originate always
 exit
no router ospf6 vrf doesntexist
```

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-05-18 01:27:16 +03:00