David Lamparter
f43cd318b2
Merge pull request #711 ("Coverity munging")
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-15 16:22:42 +02:00
David Lamparter
68fc8f1f26
ospfd: fix typo in error message
...
... and print the invalid input value
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-15 16:21:58 +02:00
Lou Berger
ffef22509f
Merge pull request #705 from dwalton76/bgpd-show-neighbor-community
...
bgpd: "no neighbor x.x.x.x send-community" not displayed correctly
2017-06-15 09:21:44 -04:00
Timothy Redaelli
a1cfe67557
redhat/frr.spec.in: Avoid expand when possible
...
expand + running shell commands doesn't work very well when building on mock
2017-06-15 12:15:30 +02:00
Martin Winter
661666525e
Merge pull request #720 from donaldsharp/arm_2.0
...
bgpd: Fix arm warn -> werror issue
2017-06-14 18:48:57 -07:00
Donald Sharp
7dad948cbb
bgpd: Fix arm warn -> werror issue
...
Fixes #719
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-14 20:34:16 -04:00
Chirag Shah
87c64b029d
ospfd: correct typo in zebra trace
...
added comment around which bw value used.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-06-14 13:32:42 -07:00
David Lamparter
4f138a3e82
lib: fix protocol name array size
...
Oops. Fixes #715 .
Reported-by: Daniel Walton <dwalton@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 15:56:14 -04:00
David Lamparter
1c2596c15f
Merge pull request #716 from dwalton76/show-route-map
...
lib: "show route-map" is missing from the parser
2017-06-14 21:07:24 +02:00
Daniel Walton
6d2729e3d7
lib: "show route-map" is missing from the parser
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-06-14 18:21:17 +00:00
David Lamparter
4d85f868a5
lib: fix CLI parser memleak
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:27 +02:00
David Lamparter
f787d7a0b3
bgpd: (demo) apply some DEFPY()
...
(This was intended as further demonstration of the DEFPY code, but it
might as well go into the tree.)
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
6cdff32196
lib: use DEFPY() for plist.c
...
Shorten lib/plist.c by combining the various command variants...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
ae56903ca7
doc: CLI: document DEFPY() usage
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
169e541c28
tests: cli: unit test DEFPY() + clidef.py
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
5578a14d94
python: clidef.py
...
Adds "DEFPY()" which invokes an additional layer of preprocessing, so
that we get pre-parsed and named function arguments for the CLI.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
29ad6f6882
lib: clippy the assistant
...
Wraps the command parsing code for Python, so we can use it to do fancy
preprocessing and replace extract.pl.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:23 +02:00
Quentin Young
6196c77a4f
zebra: fix divide-by-zero
...
x % 0 = FPE
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-14 15:08:58 +00:00
David Lamparter
92e5026146
build: fix some cross-compilation issues
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 15:46:36 +02:00
Donald Sharp
93f855c24a
Merge pull request #712 from opensourcerouting/fix-issue-683
...
Fix srcdest blackhole routes
2017-06-14 06:51:06 -04:00
Christian Franke
59b28c4523
zebra: fix ipv6 route command description strings
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-06-14 09:23:40 +02:00
Christian Franke
2664233e71
zebra: pass srcdest information also when creating blackhole routes
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-06-14 09:23:36 +02:00
Donald Sharp
03793b7abb
zebra: Remove unused testzebra and ancillary files
...
The testzebra command was unused as well as unmaintained.
The NS and VRF changes never made into testzebra so when
you actually ran testzebra it would just crash due to
uninitialized assumptions.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 14:23:52 -04:00
Donald Sharp
8089cd1062
eigrpd: Fix integer overflow possibility
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:33:25 -04:00
Donald Sharp
71007eab71
pimd: Cleanup ifp->info setup
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:28:20 -04:00
Donald Sharp
5125997a8a
ospfclient: Free up leaked resources in error path
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:15:01 -04:00
Donald Sharp
e6fda497d3
*: Clean up call into inet_aton
...
In the few places where we were not checking the return code
for inet_aton, do so.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:10:32 -04:00
Renato Westphal
0e3451e5cf
ldpd: fix issues with dual-stack adjacencies
...
Handling configuration changes from single-stack mode to dual-stack mode
(and vice-versa) is tricky. This patch attempts to solve all issues that
might happen on such circumstances.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-06-13 13:21:16 -03:00
David Lamparter
645bb0b10e
Merge branch 'stable/3.0'
...
Dropped:
redhat/README.rpm_build.md
redhat/daemons
redhat/frr.init
redhat/frr.logrotate
redhat/frr.spec.in
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:37:58 +02:00
David Lamparter
98f65fda88
Merge pull request #681 (ASAN warnings)
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:16:24 +02:00
Donald Sharp
97f653d0e2
tools: Fix startup to include babel
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 10:43:20 -04:00
David Lamparter
fb82c3dbb2
Merge pull request #687 (nexthop refactoring)
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:22:29 +02:00
David Lamparter
e885ed85bb
Merge pull request #624 "Babel"
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:11:32 +02:00
David Lamparter
e763afa507
babeld/eigrpd: flip VTY ports & fix rpm
...
babeld was 2609 previously, and this was still marked in SERVICES.
Let's flip it back before we have a release out with it.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 14:36:55 +02:00
David Lamparter
5da670a08b
Merge pull request #703 from donaldsharp/nl_pid
...
zebra: When calling netlink, set the nl_pid as appropriate
2017-06-13 10:08:43 +02:00
David Lamparter
063221b5ad
Merge pull request #700 "Coverity high"
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 10:05:51 +02:00
David Lamparter
ea00fb03f0
Merge pull request #678
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 10:03:01 +02:00
David Lamparter
3565d9ac83
babeld: install directly connected IPv4 as such
...
babeld would install "1.2.3.4 on eth0" as "1.2.3.4 via 1.2.3.4 on eth0".
Remove the superfluous nexthop and send to zebra as directly-connected
route.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 09:45:16 +02:00
David Lamparter
97bd5c48de
Merge remote-tracking branch 'frr/master' into pull-624
2017-06-13 09:18:14 +02:00
Chirag Shah
3eb7a8495e
ospfd: ospf bandwidth handling
...
Handle proper indent and insert missing not statement.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-06-12 13:17:28 -07:00
Daniel Walton
62d8f9a842
bgpd: "no neighbor x.x.x.x send-community" not displayed correctly
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
We would only diplay one "no neighbor 2.2.2.2 send-community XYZ" but
there might be multiple that need to be displayed.
2017-06-12 20:09:09 +00:00
Donald Sharp
a55ba23ff7
zebra: When calling netlink, set the nl_pid as appropriate
...
This will allow us to further know that we originated the message.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-12 13:38:51 -04:00
Chirag Shah
05b15adcc2
ospfd: ospf bandwidth handling
...
if bandwidth is not set from Zebra use speed as bandwidth
for ospf route.
Testing Done:
Verfied over bond which has aggregated speed of all member interfaces,
cost is reflected in ospf route and ip route.
Manually changed interface bandwidth which replaces speed as bw, instead
uses cli entered value as bw, verifid output of ospf route and ip route.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-06-12 09:55:56 -07:00
Donald Sharp
d722f26e09
zebra: Fix memory leak
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:39:41 -04:00
Donald Sharp
43cb4d1106
zebra: Fix uninitialized memory access with src_p
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:36:32 -04:00
Donald Sharp
4dfa484627
eigrpd: Correctly size the dump data
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:31:49 -04:00
Donald Sharp
73d11e2ec1
eigrpd: Use correct memory operation
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:18:54 -04:00
Donald Sharp
d52ecaa1de
eigrpd: Fix leak of ep
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:13:51 -04:00
Donald Sharp
60805e322e
eigrpd: Cleanup leaked dest_addr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:09:29 -04:00
Donald Sharp
4af0ab6d7d
eigrpd: Fix use after free
...
Signed-off-by: Donald Sharp <sharpd@Cumulusnetworks.com>
2017-06-10 15:53:27 -04:00