mobash-rasool
46d0674da0
Merge pull request #13588 from sri-mohan1/srib-ldpd1
...
ldpd: changes for code maintainability
2023-05-30 21:02:31 +05:30
Donald Sharp
63e04998a7
Merge pull request #13414 from LabNConsulting/chopps/no-mgmtd-nowrite-on-off
...
rework messaging, resource handling in mgmtd with bug fix and code hardening
2023-05-30 10:48:32 -04:00
Christian Hopps
ff6b14a658
zebra: use ifindex vs ifp to avoid use-after-free on shutdown
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 04:09:29 -04:00
Christian Hopps
8cfe36bc7e
zebra: avoid unneeded vxlan work on shutdown
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 04:09:29 -04:00
Christian Hopps
7cd87abc5e
tests: add unified config tests
...
- simple unified test
- unified test with late backend startup test
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 04:09:29 -04:00
Christian Hopps
51941c1916
mgmtd: address review comments
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:10:20 -04:00
Christian Hopps
8611886d52
mgmtd: fix clang uninit warning
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:10:20 -04:00
Christian Hopps
e3c4bd2472
tests: add some more mgmtd tests
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:10:20 -04:00
Christian Hopps
0327be91d1
mgmtd: cleanup BE xpath subscription and matching code
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:10:20 -04:00
Christian Hopps
52a50ca1d7
lib: mgmtd: fix memleaks
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:10:20 -04:00
Christian Hopps
5ba5613077
lib: mgmtd: add manual vty server start option and use it
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:10:20 -04:00
Christian Hopps
e13a5c4165
lib: mgmtd: fixes for startup config file processing
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:10:19 -04:00
Christian Hopps
7a0894b532
mgmtd: Add note to SETCFG_REQ and debug logging
...
- convert impossible situation into assert
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:09:51 -04:00
Christian Hopps
acd7aea00e
mgmtd: simplify early config build removing unused code
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:09:51 -04:00
Christian Hopps
a1d8c7a36e
mgmtd: fix reading of config file[s]
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-30 02:09:44 -04:00
Donald Sharp
2fccc9fa10
Merge pull request #13602 from opensourcerouting/fix/reuse_subgroup_process_announce_selected
...
bgpd: Refactor subgroup_announce_table() to reuse an existing helpers
2023-05-28 07:11:43 -04:00
Christian Hopps
edafa64c30
lib: enable short circuit for FE client/adapter connection
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
43f7196f3a
staticd: remove connect notify function, not needed
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
218625aa43
mgmtd: lib: cleanup error and debug messages
...
- always use IDs not a mix of IDs and pointers.
- always use PRIu64 not a mix of hex and decimal for IDs
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
42f4bb2b1a
mgmtd: lib: move INIT to after client registers
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
9405278ef2
mgmtd: send reply to SUBSCR_REQ with success or not
...
since we don't actually handle xpath subscriptions, reply with fail
if they are requested.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
5f05ff5821
lib: add short-circuit operation between same process
...
- Use a socketpair for connection, and direct (no event loop)
message sending and handling.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
08e8019c65
lib: mgmtd: add a identifying tag to the debug message
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
d6665cf63f
lib: dont be tricky with session_id just make it a session_id
...
- Previously was substituting a pointer to local allocated session for the
session_id returned from the FE adapter. This complexity isn't needed.
- Get rid of "%llu" format and the casts that came with it, instead use PRIu64
and the actual (uint64_t) type.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
bcc350971f
mgmtd: fix cleanup of cleanup in FE adapter code
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
c193194905
mgmtd: eliminate unused state
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
e3cacd9643
mgmtd: cleanup/fix BE adapter deletion code
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
6dad9b53e7
mgmtd: convert BE/FE adapter to use allocated connections
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
99564edc43
lib: mgmtd: add server-side connection code to mgmt_msg
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
070c5e7a91
lib: msg: refactor common connection code from mgmtd
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
528b326616
lib: mgmt msg: add version to messages
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
fff34d7274
lib: remove write-on-off, just requeue to the back of the queue
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Christian Hopps
898499a50f
tests: python-foo assure foo[0] is on a list not dict_values object
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-28 05:13:22 -04:00
Donatas Abraitis
5773954be9
Merge pull request #13611 from donaldsharp/logger_warn
...
tests: Convert to using logger.warning
2023-05-27 20:05:50 +03:00
Donatas Abraitis
607c84f406
Merge pull request #13608 from donaldsharp/pam_wrong
...
vtysh: Give actual pam error messages
2023-05-27 15:35:25 +03:00
Donald Sharp
780a8a10e6
tests: Convert to using logger.warning
...
Use the non deprecated format.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-05-26 16:00:42 -04:00
Donald Sharp
618a9f0592
Merge pull request #13607 from LabNConsulting/chopps/fixospftest
...
tests: ospfapi: fix non-determinism in test
2023-05-26 15:09:38 -04:00
Donald Sharp
8495b425bd
vtysh: Give actual pam error messages
...
Code was was written where the pam error message put out
was the result from a previous call to the pam modules
instead of the current call to the pam module.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-05-26 07:44:11 -04:00
Donald Sharp
145acbb3bb
Merge pull request #13599 from LabNConsulting/chopps/analyze-search
...
tests: allow selecting test results by regexp match
2023-05-26 07:20:17 -04:00
Christian Hopps
054d6bdc48
tests: selecting results by regexp and ragnes, add container support
...
- Allow selecting results using a regexp
- Allow selecting results using commasep range specs
- Add support for getting and saving results from a docker/podman
container.
- update docs
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-26 06:32:24 -04:00
Donatas Abraitis
91ac217356
Merge pull request #13594 from LabNConsulting/chopps/uniconfig
...
tests: cleanup unified config and config arg
2023-05-26 13:16:06 +03:00
Christian Hopps
39e1f084b5
tests: ospfapi: fix non-determinism in test
...
fixes #13584
The test had the ospf client injecting multiple opaque LSAs on 5s pace,
but the test itself verified and advanced on an LSA in the middle of
that sequence and not the last one. Then the test reset the ospf client
and originating router. If a later injected LSA managed to get in to the
router and flooded prior to the client/router reset then the opaque data
or sequence number could differ from the expected value.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-26 05:09:13 -04:00
Christian Hopps
27c6bfc217
tests: cleanup the config file specification and default code
...
Also, add a new warning for missing configuration files when user is
expecting them.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-26 00:33:07 -04:00
Igor Ryzhov
b570e9ce28
Merge pull request #13598 from opensourcerouting/fix/typo_vtysh
...
vtysh: Fix typo in warning message for `-b -f ...`
2023-05-25 17:09:41 +03:00
Donatas Abraitis
be393ade4a
bgpd: Refactor subgroup_announce_table() to reuse an existing helpers
...
Reuse subgroup_process_announce_selected(). It does the same as we do here
duplicating the logic.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-05-25 17:04:47 +03:00
Donatas Abraitis
0b7d911ec3
vtysh: Fix typo in warning message for -b -f ...
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-05-25 10:20:53 +03:00
Quentin Young
254feba0a5
Merge pull request #13592 from LabNConsulting/chopps/newmunet
...
munet: import 0.13.5 w/ nicer cmd logging
2023-05-24 12:20:41 -04:00
Christian Hopps
8aba44e3a7
munet: import 0.13.5 w/ nicer cmd logging
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-24 02:48:35 -04:00
sri-mohan1
bcffa75902
ldpd: changes for code maintainability
...
these changes are for improving the code maintainability and readability
Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
2023-05-23 23:20:01 +05:30
Russ White
575a0c5e3c
Merge pull request #13555 from LabNConsulting/aceelindem/ospf-p2mp-delayed-reflooding-config
...
ospfd: OSPF P2MP Delayed Reflooding configuration
2023-05-23 11:41:35 -04:00