Commit Graph

12030 Commits

Author SHA1 Message Date
Lou Berger
3c29c38d25 user: add 'Linux sysctl settings and kernel modules' installation considerations
Signed-off-by: Lou Berger <lberger@labn.net>
2018-06-23 12:08:44 -04:00
Lou Berger
f90115c560 user: minor tweaks to bgp VRF documentation
Signed-off-by: Lou Berger <lberger@labn.net>
2018-06-23 10:47:32 -04:00
paco
74e7158c06
lib: null check (Coverity 1470150)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-22 23:03:24 +02:00
Jafar Al-Gharaibeh
3a743cb7ec
Merge pull request #2520 from donaldsharp/privs_smivs
lib: Fix privs when using HAVE_CAPABILITIES
2018-06-22 14:19:13 -05:00
paco
a6a87d63d0
lib: uninitialized variable (2) (Coverity 1469898)
Previous correction (2c2d5cb397) was not enough,
so now it is ensured that the argument shift is not negative nor zero.

Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-22 21:18:35 +02:00
paco
45981fda06
zebra: untrusted array index (2) (Coverity 1470113)
This is a correction over 7f61ea7bd4 in order
to avoid the TAINTED_SCALAR Coverity warning (ending in "Untrusted array
index read"). This is equivalent to the previous commit, but avoiding
pointer arithmetic with tainted variables.

Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-22 21:10:50 +02:00
Quentin Young
5caa3ad34f
Merge pull request #2512 from pacovn/Coverity_1399200_Unchecked_return_value_from_library
vtysh: return value check (Coverity 1399200)
2018-06-22 14:11:09 -04:00
paco
0961ea934f
ripd: out-of-bounds read (Coverity 1399295)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-22 19:16:52 +02:00
Lou Berger
ec446a4673
Merge pull request #2449 from donaldsharp/lib_delayed_read
Lib delayed read
2018-06-22 13:13:05 -04:00
paco
764f689bcf
lib: out-of-bounds access (Coverity 1452539)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-22 00:06:07 +02:00
paco
1a40fad568
vtysh: return value check (Coverity 1399200)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-22 00:01:42 +02:00
Quentin Young
0a8990d5f8
Merge pull request #2501 from pacovn/infer_unused1
bgpd isisd ldpd lib ospfd pimd: redundancy (infer, grouped)
2018-06-21 15:12:33 -04:00
Quentin Young
7c25948eca
Merge pull request #2505 from pacovn/Coverity_1143220_Argument_cannot_be_negative
tools: return check (2) (Coverity 1143220)
2018-06-21 15:02:31 -04:00
Quentin Young
390cc01007
Merge pull request #2511 from pacovn/Coverity_1452287_et_al_Explicit_null_dereferenced
ldpd, lib: null check (Coverity 1452287 and 20 alike)
2018-06-21 15:00:12 -04:00
Quentin Young
772b852662
Merge pull request #2408 from ajones-rvbd/ajones-issue-2403
tests: use BUILT_SOURCES in tests/Makefile.am for automake 1.16.1
2018-06-21 14:43:16 -04:00
Quentin Young
c3fdecefb4
Merge pull request #2502 from pacovn/Coverity_1221459_Use_after_free
ospf6d: fix use after free (2) (Coverity 1221459)
2018-06-21 14:38:47 -04:00
Quentin Young
132880ad0a
Merge pull request #2513 from pacovn/Coverity_1455334_et_al_Dereference_null_return_value
eigrpd: null check (Coverity 1455334 and 4 alike)
2018-06-21 14:34:56 -04:00
Quentin Young
277781a778
Merge pull request #2518 from pacovn/Coverity_23106_Explicit_null_dereferenced
bgpd: null check (Coverity 23106)
2018-06-21 14:24:11 -04:00
Quentin Young
dfc5d40e91
Merge pull request #2519 from pacovn/Coverity_1399238_Logically_dead_code
bgpd: dead code (Coverity 1399238)
2018-06-21 14:20:48 -04:00
Quentin Young
1337a02851
Merge pull request #2522 from pacovn/Coverity_1399277_Explicit_null_dereferenced
lib: null check (Coverity 1399277)
2018-06-21 14:18:47 -04:00
Quentin Young
cc05c430b3
Merge pull request #2523 from pacovn/Coverity_1455380_Dereference_null_return_value
bgpd: null check (Coverity 1455380)
2018-06-21 14:17:58 -04:00
paco
990f4f9112
bgpd: null check (Coverity 1455380)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-21 18:51:52 +02:00
paco
d1f92e454c
lib: null check (Coverity 1399277)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-21 17:35:38 +02:00
Donald Sharp
38e72ffa9a sharpd: Does not need any special priv's
Remove the unnecessary privs that we were requesting
for the sharp daemon.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-06-21 11:28:16 -04:00
paco
d87ff2ddf4
bgpd: dead code (Coverity 1399238)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-21 17:22:55 +02:00
Donald Sharp
8e04538cae lib: Fix privs when using HAVE_CAPABILITIES
If your daemon does not need any special privileges
and you are compiling with HAVE_CAPABILIES, the
zprivs->change pointer will end up NULL due
to the way zprivs_caps_init.  So as a check
let's add a NULL check for zprivs->change
and set it to a function that will do nothing.

This change prevents a crash if you raise privileges
when your daemon needs no special privileges.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-06-21 11:22:51 -04:00
Renato Westphal
aa74131957
Merge pull request #2510 from donaldsharp/extended_ack
zebra: Add extended Ack error parsing to FRR
2018-06-21 12:16:53 -03:00
paco
0cfbff749e
zebra: flow control (Coverity 1462467 1465497)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-21 17:09:04 +02:00
Ruben Kerkhof
1a629db7a1 redhat: cleanup %pre snippet a bit
Based on https://fedoraproject.org/wiki/Packaging:UsersAndGroups

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
0e3daa4df6 redhat: add option to enable Cumulus extensions
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
b8b18c064b redhat: quote %name macro
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
4f20eab14c redhat: replace hardcoded path with variable
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
4aa7422e82 redhat: remove some superflous %attr calls
These are the default

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
bc1dc4fe04 redhat: remove macro from changelog
rpmlint warns about this:
macro-in-%changelog %{version}

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
95c16f4c20 redhat: add some newlines between sections
Makes the spec slightly easier to read

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
1eca28ffdc redhat: more indentation
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
ff00e18d2d redhat: sort options
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
1dc5a0dc3c redhat: quote a few macros
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
d1ef2aafc8 redhat: unversioned libs belong in -devel package
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:41 +02:00
Ruben Kerkhof
5c3ad1d46a redhat: remove support for static builds
This just doesn't work as RHEL doesn't ship static libs for the
dependencies.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:05:37 +02:00
Ruben Kerkhof
7bd661a2b5 redhat: remove superflous defattr lines
They are the default since RHEL5:
https://pagure.io/packaging-committee/issue/77

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
35a1688ab9 redhat: remove obsolete %clean section
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
e0c875f1b2 redhat: remove obsolete BuildRoot tag
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
5ebf96721a redhat: use one BuildRequires per line
Makes for easier diffing

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
7eec5b4c38 redhat: remove BuildRequires for patch
Nothing seems to need it

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
ec59a1559c redhat: don't Requires initscript on systemd based distros
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
772d418a8b redhat: remove superfluous Requires for json-c
json-c-devel is already a BuildRequires, and rpm will add the Requires
itself.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
5f371d0bdf redhat: indent some stuff in spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
98a2aecb7b redhat: replace hardcoded directory
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Ruben Kerkhof
515a8ee8f5 redhat: use 'service' command to restart frr
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00