Russ White
|
fc89ac9846
|
Merge pull request #2470 from chiragshah6/mdev
zebra: Hide default vrf instance of l3vni cmd
|
2018-06-19 07:29:13 -04:00 |
|
Russ White
|
efd1d76673
|
Merge pull request #2474 from donaldsharp/vty_thread_cancel_writes
Add 'show thread poll'
|
2018-06-19 07:28:18 -04:00 |
|
Russ White
|
e3ea4f7acb
|
Merge pull request #2478 from pacovn/Coverity_1408766_Dereference_after_null_check
bgpd: null check (Coverity 1408766)
|
2018-06-19 07:21:42 -04:00 |
|
Russ White
|
0ddc9a2d9d
|
Merge pull request #2479 from dslicenc/zebra-vrf-statics
zebra: re-install static routes needed vrf when the vrf intf comes up
|
2018-06-19 07:19:39 -04:00 |
|
Russ White
|
f071d8b36a
|
Merge pull request #2481 from pacovn/security_vpn_null_check
bgpd: vpn null check
|
2018-06-19 07:19:00 -04:00 |
|
Russ White
|
9635a16a36
|
Merge pull request #2483 from pacovn/clang_scan_bgpd_updgrp_deref
bgpd: null check (Clang scan-build)
|
2018-06-19 07:18:13 -04:00 |
|
Russ White
|
5e51ae9816
|
Merge pull request #2491 from pacovn/cppcheck_no_effect
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
|
2018-06-19 07:15:07 -04:00 |
|
Russ White
|
aa13697bb0
|
Merge pull request #2492 from pacovn/cppcheck_security1
eigrpd, lib, tests, vtysh: security (cppcheck)
|
2018-06-19 07:14:19 -04:00 |
|
paco
|
6d10727ac1
|
eigrpd, lib, tests, vtysh: security (cppcheck)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-19 10:40:56 +02:00 |
|
paco
|
5f18adf01b
|
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
Assignment of function parameter has no effect outside the function.
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-19 10:19:05 +02:00 |
|
Ruben Kerkhof
|
0cff191d5c
|
redhat: fix else cases in spec file
As pointed out during review, disable the options when the macros are
false.
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
2d2ab69937
|
redhat: spec file: specify file only once
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
07a138ecab
|
redhat: spec file: no need for custom attr for service file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
95624f7b34
|
redhat: add missing dependencies on chkconfig in spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
c88a52f4df
|
redhat: remove a few superfluous Requires from spec file
rpm adds these automatically
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
ccb9b8f6c0
|
redhat: remove a few superfluous BuildRequires from spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
501c136231
|
redhat: depend on info package instead of binary in specfile
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
fadbc6e7fe
|
redhat: install-info is not called from %pre in spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
54c059f1cb
|
redhat: remove wrong comment from spec file
systemd support needs watchfrr
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
a999f98cc5
|
redhat: spec file: all supported Fedora versions use systemd
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
7ca1f62ca9
|
redhat: use default permissions for logrotate file in spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
6ad17a64c1
|
redhat: spec file: we ship only one logrotate file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
c9cad8766e
|
redhat: be consistent in adding ./configure options in spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
c410a86130
|
redhat: use Github for SOURCE0 in spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
e1ff824635
|
redhat: Use https for URL in spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
150e7c7eb3
|
redhat: remove trailing whitespace from spec file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:52 +02:00 |
|
Ruben Kerkhof
|
fe99b0153a
|
redhat: fix tabs vs spaces in spec file
rpmlint reports:
redhat/frr.spec:282: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 282)
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
|
2018-06-19 09:57:45 +02:00 |
|
Lou Berger
|
ed892e530d
|
Merge pull request #2476 from pacovn/Coverity_1433544_Explicit_null_dereferenced
bgpd: null check (Coverity 1433544, 1433543, 1433542)
|
2018-06-18 16:59:26 -04:00 |
|
Donald Sharp
|
b5e3687b1d
|
Merge pull request #2482 from pacovn/clang_scan_bgpd_bgp_rpki_deref
bgpd: null check (Clang scan-build)
|
2018-06-18 16:09:56 -04:00 |
|
paco
|
d3e51db069
|
bgpd: null check (Clang scan-build)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 21:37:35 +02:00 |
|
Donald Sharp
|
e8609f7950
|
Merge pull request #2484 from pacovn/cppcheck_unused_vars
eigrpd, lib: unused vars (cppcheck)
|
2018-06-18 15:27:11 -04:00 |
|
Donald Sharp
|
6f32955ec3
|
Merge pull request #2486 from pacovn/cppcheck_fmt_validation
babeld, lib, ospfd, tests: fmt fixes (cppcheck)
|
2018-06-18 15:23:49 -04:00 |
|
Donald Sharp
|
2daa80f0c0
|
Merge pull request #2489 from pacovn/cppcheck_reduntant_pointer_op
ldpd: redundant pointer operation (cppcheck)
|
2018-06-18 15:16:55 -04:00 |
|
Donald Sharp
|
cfa38db146
|
Merge pull request #2488 from pacovn/cppcheck_nhrpd_limit_check
nhrpd: array limit check (cppcheck)
|
2018-06-18 15:16:34 -04:00 |
|
Donald Sharp
|
b49bc6b010
|
Merge pull request #2487 from pacovn/cppcheck_redundant_memset
ospfd, pimd: redundant memset (cppcheck)
|
2018-06-18 15:15:46 -04:00 |
|
Donald Sharp
|
162deb7dfb
|
Merge pull request #2490 from pacovn/cppcheck_unsigned_check
babeld, eigrpd, ospfd: unsigned negative check (cppcheck, grouped)
|
2018-06-18 15:14:07 -04:00 |
|
Donald Sharp
|
c0662bb478
|
Merge pull request #2417 from pacovn/Coverity_1399373_Structurally_dead_code
bgpd: dead code (Coverity 1399373)
|
2018-06-18 14:29:27 -04:00 |
|
paco
|
0e8d7233e3
|
ldpd: redundant condition (cppcheck)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 19:40:39 +02:00 |
|
paco
|
d11c6941dc
|
babeld, eigrpd, ospfd: unsigned negative check
After Cppcheck 1.72 feedback
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 19:07:24 +02:00 |
|
paco
|
e83c042a88
|
ldpd: redundant pointer operation (cppcheck)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 18:41:57 +02:00 |
|
paco
|
0e3d32f1c9
|
nhrpd: array limit check (cppcheck)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 18:13:41 +02:00 |
|
paco
|
1a36dd60fd
|
ospfd, pimd: redundant memset (cppcheck)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 18:01:59 +02:00 |
|
Donald Sharp
|
36de1d53b8
|
Merge pull request #2457 from pacovn/Coverity_1465491_Untrusted_value_as_argument
pimd: Untrusted val as argument (Coverity 1465491)
|
2018-06-18 11:55:53 -04:00 |
|
Donald Sharp
|
7c75247f66
|
Merge pull request #2464 from pacovn/Coverity_1399309_Out-of-bounds_access
isisd: out-of-bounds access (Coverity 1399309)
|
2018-06-18 11:55:16 -04:00 |
|
paco
|
2ec42b858c
|
babeld, lib, ospfd, tests: fmt fixes (cppcheck)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 17:52:56 +02:00 |
|
paco
|
029a775e43
|
eigrpd, lib, vtysh: unused vars (cppcheck)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 17:23:38 +02:00 |
|
paco
|
18b91526fa
|
bgpd: null check (Clang scan-build)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 16:27:02 +02:00 |
|
paco
|
c37a11ad72
|
bgpd: null chk (Coverity 1433544 1433543 1433542)
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 16:07:43 +02:00 |
|
paco
|
73aed5841a
|
bgpd: vpn null check
Can be reproduced with following vtysh sequence (an intentionaly wrong
sequence):
['configure terminal\n router bgp 255 vrf l3vrf-6\n',
'configure terminal\n router bgp 255 vrf l3vrf-6\nbgp router-id 10.255.255.1\n',
'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nlabel vpn export 45000\n',
'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrd vpn export 255:5\n',
'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute isis\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute ospf\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute connected\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nimport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nexport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn import 255:1\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn export 255:1\n'
]
Signed-off-by: F. Aragon <paco@voltanet.io>
|
2018-06-18 15:52:57 +02:00 |
|
Lou Berger
|
2868e293e7
|
Merge pull request #2466 from pacovn/clang_scan_bgpd_dereference1
bgpd: null check (Clang scan-build)
|
2018-06-18 08:16:01 -04:00 |
|