Commit Graph

7112 Commits

Author SHA1 Message Date
Donald Sharp
0b4b83800c redhat: Remove references to cumulus directory
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 12:22:50 -04:00
Donald Sharp
56bdfe7d2a *: Remove cumulus Directory
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 12:20:29 -04:00
Donald Sharp
adce2bc26a debian: Remove reference of cumulus directory
Use the tools/etc... directory for packaging now
not the cumulus/etc since it is going away

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 12:11:03 -04:00
Donald Sharp
423ca47c18 tools: Proper file name is frr.conf
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 12:10:18 -04:00
Donald Sharp
993eafddcb *: Move etc/frr into tools
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 12:09:22 -04:00
Donald Sharp
1f64e4d935 *: Move default/frr into tools directory
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 12:07:45 -04:00
Donald Sharp
2db86748db *: Move sudoers file into tools
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 12:06:11 -04:00
Donald Sharp
cd9fad823d *: Move ssd from cumulus to tools directory
As discussed on the mailing list, the cumulus directory should
be going away.  This commit moves the ssd from cumulus to tools

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 11:58:36 -04:00
Donald Sharp
10bfc1ef23 doc: Update Documentation to let compilers know about new option
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 11:52:49 -04:00
Donald Sharp
df970aa6ef *: Add --enable-datacenter to turn on datacenter defaults
Compile in DataCenter Defaults if --enable-datacenter
is configured instead of --enable-cumulus

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 11:52:45 -04:00
Donald Sharp
e6d700e33b pimd: Note when a S,G stream should be a FHR as well
When we have a S,G being created, that it might
also be a FHR router as well.  This happens
when the FHR is in the path of the RP->LHR
for when it builds it's SPT tree for the S,G.

Ticket: CM-16056, CM-15836
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 11:11:57 -04:00
Donald Sharp
bacf3d12dd pimd: Only compare the actual IIF of the *,G to S,G
Now that pim has the ability to use ecmp, the Group
path to the RP, may be different than what is choosen
for the *,G IIF.  As such when we are making the
spt switchover decision, compare the S,G IIF to the
*,G IIF.

Ticket: CM-15870
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 11:11:20 -04:00
Donald Sharp
704ef00bb5 lib: Rename HAVE_POLL to prevent conflicting #defines
Rename HAVE_POLL to HAVE_POLL_CALL, when compiling with
snmp and poll enabled this was causing issues.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-04 10:32:41 -04:00
Donald Sharp
e1a1b2edde ospf6d: Allow some route-map commands to work
The generic callbacks need to be enabled in order
for some route-map commands to properly work.

I've tried to match up to what is programmed to work
within ospfv3.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-03 14:39:21 -04:00
Donald Sharp
09b3c32838 ospf6d: Fix redistribution debug knowledge
When redistributing into ospfv3 specify that the
route is add or delete correctly.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-03 14:33:28 -04:00
Daniel Walton
596c17ba57 bgpd: hide "router bgp" commands also under "address-family ipv4 unicast"
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by:   Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-03 16:45:14 +00:00
Jafar Al-Gharaibeh
b3d28d8f8a Merge pull request #451 from opensourcerouting/ospfd-fix-cmdstr
ospfd: fix small problem in the redistribute command
2017-05-03 10:04:59 -05:00
Donald Sharp
090ba7ca15 vtysh: Fix _ instead of - usage for labeled_unicast
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-03 10:24:04 -04:00
Donald Sharp
f5374e95dc doc: Add systemd dev package to doc
Add the systemd dev package to the list of items to install

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-03 09:35:06 -04:00
Hung-Weic Chiu
2a3886acd5 Fix the error message when execute ldpd with --enable-tcp-zebra
- If we use the option "--enable-tcp-zebra " to configure, the zclient will use the tcp socket instead of unix domain socket.
- The ldpd will pass the "-z path" options to `frr_opt` and that will execute zclient_serv_path_set to check the domain socket.
- Add the define to ldpd, if the "HAVE_TCP_ZEBRA" has been define, don't pass the "-z path" to `frr_opt`.

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-05-03 13:30:46 +00:00
Daniel Walton
d088b27ebd Add valgrind_enable option to /etc/frr/debian.conf
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

This allows you to start all daemons via valgrind so you can catch
memory leaks, etc.
2017-05-03 13:18:20 +00:00
Donald Sharp
ae9b0e11f6 bgpd: Fix crashes with '[no] neighbor ... shutdown ..' command
This fixes two crashes:

1) When we enter a 'neighbor shutdown..' command for a peer
group or interface based peer we were not properly looking
up the peer.

2) When we we enter 'no neighbor shutdown..' command for
a peer group or interface based peer we were not properly
lookup up the peer.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-03 09:13:12 -04:00
Renato Westphal
6cf3661ddf ospfd: fix small problem in the redistribute command
The use of {<>} is unnecessary and not correct.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-03 10:08:03 -03:00
Donald Sharp
1c72f1a08d zebra: Fix leaked memory in label manager code
When we fail to properly setup we can leak some memory.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-03 08:11:38 -04:00
Donald Sharp
78472fc8a0 doc: Fix systemd build instructions
Fix the build/install instructions for Ubuntu 16.04 and
systemd.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-03 07:06:20 -04:00
Donald Sharp
9402b9f648 bgpd: Fix crash associated with aggregate command
The cli rework created this issue

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-02 22:34:29 -04:00
Donald Sharp
0ce5d20e46 bgpd: When receiving a route set the label to invalid
When we are receiving a route the attr->extra->label_index
is being set to 0.  This should be BGP_INVALID_LABEL_INDEX
instead since we cannot rely on 0 to be correct for labels.

I believe that there are probably other spots that need this
type of fix, but I will let testing snuggle-bump them out.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-02 22:34:29 -04:00
Donald Sharp
5ce77b2b1e bgpd: Fix 'show bgp ... summary json' to have empty {}
When we have no output for a json command we should have
an empty {} displayed.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-02 22:34:21 -04:00
Donald Sharp
5503498dda Merge pull request #442 from Jafaral/pim-hello-fix
Fix: Off by one error, correct index for hold timer
2017-05-02 19:49:13 -04:00
Jafar Al-Gharaibeh
b063aa2139 Fix: Off by one error, correct index for hold timer
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2017-05-02 17:23:34 -05:00
Donald Sharp
05ba625af7 Merge remote-tracking branch 'origin/stable/3.0' 2017-05-02 15:52:09 -04:00
Hung-Wei Chiu
826fe613f9 update doc of ubuntu 12.04
1. modify the prefix to /usr (which is hard-code in /etc/init.d/frr)
2. install init.d related files.
2017-05-02 15:23:38 -04:00
Hung-Wei Chiu
6aebd5f532 Update 14.04 docs to support init.d service
1. Configure the prefix to /usr  (frr script hard-code those path in /etc/init.d/frr)
2. Install the service file to /etc/init.d
2017-05-02 15:23:38 -04:00
Jafar Al-Gharaibeh
6a8badfb9b Merge pull request #440 from donaldsharp/afi_safi3
Afi safi3
2017-05-02 14:20:30 -05:00
Donald Sharp
df581cd3e1 Merge remote-tracking branch 'origin/stable/2.0' 2017-05-02 15:11:46 -04:00
Donald Sharp
2763d23486 Merge pull request #439 from Jafaral/pim_rpgrp-fix
Fix: reverse logic of when to pass the supplied group address
2017-05-02 14:31:55 -04:00
Donald Sharp
8f5f5e1ad3 Merge pull request #438 from hwchiu/fix_nhrpd_privs
Fix the error when execute nhrpd
2017-05-02 14:20:43 -04:00
Donald Sharp
ebe9474310 pimd: Fix cli uplift mistakes
When we uplifted the cli from old -> new, I did not properly
handle the switch from <1-3> to (1-3) for number ranges.

Also fix some minor variable renaming that happened?

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-02 13:58:07 -04:00
Donald Sharp
f4d78586df ospfd: Fix a variant of the ospf redistribute command
Fix 'redistribute (ospf|table) ....' command

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-02 13:56:41 -04:00
Chirag Shah
c645ca8177 pimd: fix compilation failure.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-05-02 10:31:10 -07:00
Chirag Shah
07d7a7641c pimd: fix extra space at the end
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-05-02 10:19:32 -07:00
Chirag Shah
17d86e5038 pimd: fix help string for intf cntrs show cmd
Fix show interface traffic single command help string.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-05-02 10:15:23 -07:00
Jafar Al-Gharaibeh
846ef66292 Fix: reverse logic of when to pass the supplied group address
This was causing a crash when no group address was passed
   because a garbage pointer valuse was used. It also was ignoring
   the group address when passing one.

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2017-05-02 12:15:06 -05:00
Donald Sharp
c0fee6efb6 Merge pull request #429 from hwchiu/fix_clang_sa
Fix some warnings by clang static analyzer
2017-05-02 11:45:42 -04:00
Russ White
382cb45532 Merge pull request #412 from dwalton76/draft-ietf-idr-bgp-prefix-sid-05
Update to draft-ietf-idr-bgp-prefix-sid-05
2017-05-02 11:43:50 -04:00
Martin Winter
fdb33a50e1 Merge pull request #410 from dslicenc/rdnbrd-vrr
zebra: fix attempt to install a second rib from imported table entries
2017-05-02 08:42:38 -07:00
Hung-Weic Chiu
54b7b88bf5 Fix the wrong user/group for nhrpd.
- Modify the defince from quagga to frr

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
2017-05-02 15:42:31 +00:00
Donald Sharp
b46be72b4a Merge branch 'master' into EIGRP 2017-05-02 11:38:06 -04:00
Russ White
b2ab6b282c Merge pull request #377 from qlyoung/frr-pthreads
lib: MT-safe thread.c + add pthread manager
2017-05-02 11:26:20 -04:00
Renato Westphal
5a9a82b8ec Merge pull request #426 from donaldsharp/afi_safi2
Afi safi2
2017-05-02 12:09:17 -03:00