Commit Graph

10264 Commits

Author SHA1 Message Date
Donald Sharp
513c846203 pimd: Fix multicast boundary command
1) Fix missing newlines
2) Write the correct cli out.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-05 10:31:59 -04:00
Donald Sharp
445c24803d bgpd: Fixup json with RouteDistinguishers
The json option for displaying a bgp table
with route Distinguishers in it was not properly
working.  This code cleans this issue up.

Additionally attempt to make the code a bit
easier to read and handle.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-05 10:12:00 -04:00
Donald Sharp
98ce9a06b4 bgpd: Cleanup bgp_show_table to be easier on the eyes
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-05 10:11:49 -04:00
Lou Berger
af8528faa0 bgpd: fix 'show bgp ipvX vpn rd' command
Signed-off-by: Lou Berger <lberger@labn.net>
2017-10-05 10:11:49 -04:00
Lou Berger
3d7c4cd734 bgpd: fix show bgp ipvX vpn all rd
Signed-off-by: Lou Berger <lberger@labn.net>
2017-10-05 10:11:49 -04:00
Lou Berger
24345e82e8 bgpd: remove old/broken vpnv4 from of show bgp
Signed-off-by: Lou Berger <lberger@labn.net>
2017-10-05 10:11:49 -04:00
Lou Berger
1ae44dfcba bgpd: unify 'show bgp' with RD with normal unicast bgp show
Signed-off-by: Lou Berger <lberger@labn.net>
2017-10-05 10:11:49 -04:00
Renato Westphal
ad183f047c Merge pull request #1244 from donaldsharp/flush_routes
tools: Fix route flush
2017-10-05 11:05:43 -03:00
Renato Westphal
bb7b7c0054 Merge pull request #1280 from donaldsharp/eigrp_interface
Eigrp interface cleanup
2017-10-05 11:03:54 -03:00
Christian Franke
e5973ce5b6 isisd: fix issue with lsp queueing logic in lsp_tick 2017-10-05 16:02:33 +02:00
Renato Westphal
b7801b99c4 Merge pull request #1292 from chiragshah6/mdev
ospf6d: add debug ospf6 route memory to config
2017-10-05 10:43:35 -03:00
Donald Sharp
6977eb91c6 *: Add some documentation about how to handle new daemons
Add some breadcrumbs for when we add a new routing daemon
so things `just work`.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-05 08:54:03 -04:00
Donald Sharp
92bd13d762 tools: Add NHRP to route flushing
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-05 08:27:31 -04:00
Donald Sharp
91effb395a tools: Fix babel RT_PROT #
We had mistakenly created another RT_PROT # for babel.
This is incorrect.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-05 08:23:27 -04:00
Donald Sharp
a6487ff6b5 tools: Fix route flush
This commit does two things:

1) Flush by proto number not string
   This is useful because not all systems might have the proto
   values installed, or a version of iproute2 that they might
   be installed with.
2) Flush missing routes that might have been installed( eigrp
   and nhrp )

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-05 08:12:44 -04:00
Donald Sharp
c1c41b0458 Merge pull request #1286 from opensourcerouting/isis-lsp-queue-improv
isisd: optimize per interface lsp send-queue creation
2017-10-05 08:06:57 -04:00
Donald Sharp
7be1117a28 Merge pull request #1291 from sebageek/debian-pkg-add-iproute2-alternative
Add iproute2 as dependency alternative in Debian package
2017-10-04 18:38:41 -04:00
Donald Sharp
b3c84c1db1 Merge pull request #1288 from donaldsharp/1287
doc: Added python-ipaddr dependancy
2017-10-04 18:37:11 -04:00
Chirag Shah
6f7af48c12 ospf6d: add debug ospf6 route memory to config
vty config write to display 'debug ospf6 route memory'.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-04 14:35:54 -07:00
Quentin Young
bb0470088d Merge pull request #1289 from sebageek/fix-defualt-typo
Fix defualt-default typo in bgp evpn help text
2017-10-04 17:31:45 -04:00
Sebastian Lohff
591fa044c9 debian: Add iproute2 as dependency alternative in Debian package
iproute has been a transitional package that only depends on iproute2
since Debian Jessie or Ubuntu 14.04. To avoid installing this transitional
dummy package on newer installations we add iproute2 as a dependency
alternative to iproute. The iproute dependency can be dropped when
wheezy / 12.04 support is no longer needed.

Signed-off-by: Sebastian Lohff <seba@someserver.de>
2017-10-04 22:18:01 +02:00
Sebastian Lohff
078af92eac bgpd: Fix defualt-default typo in bgp evpn help text
Signed-off-by: Sebastian Lohff <seba@someserver.de>
2017-10-04 22:15:01 +02:00
Quentin Young
53c2f1b73a
doc: add docs for commit message format
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-10-04 15:41:34 -04:00
Will McLendon
7e83b2ef13 doc: Added python-ipaddr dependancy
Added python-ipaddr apt requirement to documentation.
Added clarification to install systemd service section
as commands assume are in frr directory.

Signed-off-by: Will McLendon <wimclend@gmail.com>
2017-10-04 14:58:35 -04:00
Lou Berger
a04a5db1df Merge pull request #1283 from donaldsharp/ldp_bite_me
ldpd: Fix compiler warning about uninitialized rt
2017-10-04 07:46:04 -04:00
Donald Sharp
7f6778408b ldpd: Fix compiler warning about uninitialized rt
Certain compilers cannot recognize that rt is
actually being init'ed, but let's set it to
NULL 'till we get them updated.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-03 21:32:32 -04:00
Donald Sharp
c996743b78 Merge pull request #1282 from opensourcerouting/ldpd-minor-issues
ldpd minor issues
2017-10-03 20:19:11 -04:00
Donald Sharp
e6b0b03763 Merge pull request #1267 from opensourcerouting/ldpd_cli_show
ldpd: add more filtering options in some "show" commands
2017-10-03 16:23:28 -04:00
Renato Westphal
547322cb0f ldpd: detach stdin/stdout/stderr from the child processes
Doing a "ssh user@node 'ldpd -d'" was making the SSH session hang. In
the original OpenBSD's ldpd(8) daemon, the daemon function takes care
of connecting stdin/stdout/stderr to /dev/null. In the FRR port, this
only happens in the frr_run() function, after all children have been
forked. Ideally we could try to rearrange libfrr.c and ldpd.c in a way
that start_child() is called only after the parent connects the standard
I/O streams to /dev/null. But since this issue needs an immediate
fix, let's do this workaround for now. Note: even when running on the
foreground, all log messages from the child processes are sent to the
parent process, which then prints the messages to stdout/stderr and/or
to a log file.

Reported-by: Martin Winter <mwinter@opensourcerouting.org>
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-10-03 17:16:32 -03:00
Renato Westphal
3b2d98c58e ldpd: fix issue when displaying the running configuration
More than a cosmetic fix, this should prevent issues with frr-reload.py.

Before:

mpls ldp
 router-id 1.1.1.1
 !
 address-family ipv4
  discovery transport-address 1.1.1.1
  !
  interface rt1-eth0
   discovery hello holdtime 10
   discovery hello interval 3
 exit-address-family
 !
!

After:

mpls ldp
 router-id 1.1.1.1
 !
 address-family ipv4
  discovery transport-address 1.1.1.1
  !
  interface rt1-eth0
   discovery hello holdtime 10
   discovery hello interval 3
  !
 exit-address-family
 !
!

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-10-03 16:31:37 -03:00
Renato Westphal
16cd3d9d4a ldpd: remove the "discovery targeted-hello" commands from the interface node
These commands belong only in the global LDP node and in the LDP
address-family nodes.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-10-03 16:30:11 -03:00
Renato Westphal
7991dc323e ldpd: fix wrong indentation in the help menu
The -n option was not aligned with the other ones:

% ldpd --help
[snip]
  -A, --vty_addr     Set vty's bind address
  -P, --vty_port     Set vty's port number
      --ctl_socket   Override ctl socket path
-n,   --instance     Instance id

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-10-03 16:30:07 -03:00
Jafar Al-Gharaibeh
5efddfb813 Merge pull request #1111 from chiragshah6/mdev
ospfd: OSPFv2 VRF Support
2017-10-03 13:09:59 -05:00
Jafar Al-Gharaibeh
f93a3c71d8 Merge pull request #1281 from donaldsharp/boo_memset
lib: Fix memset usage
2017-10-03 11:59:19 -05:00
Chirag Shah
f1a0393033 ospfd: OSPFv2 VRF remove iflist from master
Remove instances of ospf master's iflist and use vrf_list
with ospf vrf_id.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:22:47 -07:00
Chirag Shah
e1b18df1ea ospfd: fix vrf bind sock non-linux system
For non GNU_LINUX like open Bsd avoid sending packet
to non vrf aware device using in_pktinfo.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:22:47 -07:00
Chirag Shah
e7503eab31 ospfd: Bind socket to vrf device
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:22:47 -07:00
Chirag Shah
35955c14c2 ospfd: OSPFv2 VRF fixesI
Fix ospf interface running config to display vrf
fix clang warnings

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:22:47 -07:00
Chirag Shah
43b8d1d8a1 ospfd: OSPFv2 VRF Changes II
Accomodate review comments

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:15:20 -07:00
Chirag Shah
c0f3f7cdf8 ospfd: fix clang warning & ci-ospf test
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:15:19 -07:00
Chirag Shah
0d31e63e3e ospfd: OSPFv2 VRF, fix CLAN SA warning
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:15:19 -07:00
Chirag Shah
b5a8894de6 ospfd: OSPFv2 VRF Support
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-10-03 09:15:19 -07:00
Donald Sharp
7faf667af6 lib: Fix memset usage
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-03 12:03:56 -04:00
Jafar Al-Gharaibeh
cb64dec0d6 Merge pull request #1278 from chiragshah6/ospf_vrf_dev
ospfd: Fix maxage_lsa lookup key
2017-10-03 10:41:00 -05:00
Quentin Young
07fb10ad90 Merge pull request #1263 from vjardin6WIND/cleanup
Cleanup - scan-build
2017-10-03 11:39:59 -04:00
Jafar Al-Gharaibeh
09045d298d Merge pull request #1262 from dwalton76/vtysh-conft-available2
tools: frr-reload.py should exit(1) if vtysh config mode is locked
2017-10-03 10:34:33 -05:00
Christian Franke
58e1623702 isisd: optimize per interface lsp send-queue creation
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-10-03 14:20:30 +02:00
Donald Sharp
12e5c4abf1 eigrpd: Remove unnecessary macro definitions
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-02 21:29:08 -04:00
Donald Sharp
b748db674a eigrpd: Remove ei mapping to connected routes
We need one struct eigrp_interface per ifp structure
not a ifp->info structure with a ei per connected.

Some minor code cleanup as well with macros and
their weird usage.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-02 21:24:59 -04:00
Donald Sharp
79b3087675 eigrpd: Start fixing eigrp_interface
The EIGRP interface handling code created 2 levels
of interface information, the ei( created per *connected*
address?????) and the ifp->info pointer.

Start the combination of pushing these together and
cleaning up the weirdness that is these two data
structures.

This commit probably breaks eigrp's handling of
interfaces.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-10-02 19:51:49 -04:00