Philippe Guibert
6179d0d125
bgpd: evpn nexthop can be changed by default
...
There can be cases where evpn traffic is not meshed across various
endpoints, but sent to a central pe. For this situation, add the
configuration knobs to force nexthop attribute. Upon that change,
nexthop unchanged attribute is automatically disabled.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2020-09-11 18:25:12 +02:00
Philippe Guibert
9609fab712
zebra: zvni_map_to_vlan() adaptation for all namespaces
...
this change is needed when a MAC/IP entry is learned by zebra, and the
entry happens to be in a different namespace. So that the entry be
active, the correct vni match has to be found.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2020-09-11 18:02:50 +02:00
Martin Winter
a77bd0f4e6
Merge pull request #7075 from donaldsharp/snap_fix
...
snapcraft: Update libyang version
2020-09-11 15:40:00 +02:00
Rafael Zalamena
36273d9ffb
Merge pull request #7085 from donaldsharp/nhrpd-leafref-workaround
...
nhrpd: add frr-vrf to the list of implemented yang modules
2020-09-11 10:37:53 -03:00
Donald Sharp
1b741a01c6
nhrpd: add frr-vrf to the list of implemented yang modules
...
PR #6376 introduced a VRF leafref in the frr-interface YANG module.
That change exposed a bug in the northbound layer that is causing
nhrpd to crash under certain circumstances. Even though nhrpd wasn't
converted to the new northbound model yet, make it implement the
frr-vrf module in order to work around this problem. This is a
temporary fix until a better solution is available.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-09-11 08:51:05 -04:00
Jafar Al-Gharaibeh
79e75ac92e
Merge pull request #7078 from sworleys/RPM-Doc-Blurb
...
doc: add blurb for rpm package server in overview
2020-09-11 00:27:50 -05:00
Stephen Worley
7821a88d90
doc: add blurb for rpm package server in overview
...
Add a blurb about the rpm package server in the overview page
so its easier to know where it is. Should be with the debian
one anyway.
Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2020-09-10 17:16:11 -04:00
Donald Sharp
9841ca1dfc
snapcraft: Update libyang version
...
Update the snapcraft build of libyang to the version we
actually want to be using v1.0.184
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-09-10 09:13:36 -04:00
Donatas Abraitis
a68b613b09
Merge pull request #6827 from maduri111/bgpd-show-bgp-all
...
bgpd: show <ip> bgp <ipv4/ipv6> all
2020-09-10 15:11:14 +03:00
Donatas Abraitis
4c33bf263f
Merge pull request #7064 from donaldsharp/bgp_timings_faster
...
tests: Modify bgpd.conf to have faster keepalive/hold timers
2020-09-10 15:10:11 +03:00
David Schweizer
12488d7c8d
lib: fix negating set metric route-map command
...
Changed negating set metric route-map command to be usable in
conjunction with the affirming command.
Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>
2020-09-10 09:14:58 +02:00
Donald Sharp
63f5364377
Merge pull request #7070 from opensourcerouting/pbrd-leafref-workaround
...
pbrd: add frr-vrf to the list of implemented yang modules
2020-09-09 22:10:00 -04:00
Renato Westphal
a74b47f5ab
pbrd: add frr-vrf to the list of implemented yang modules
...
PR #6376 introduced a VRF leafref in the frr-interface YANG module.
That change exposed a bug in the northbound layer that is causing
pbrd to crash under certain circumstances. Even though pbrd wasn't
converted to the new northbound model yet, make it implement the
frr-vrf module in order to work around this problem. This is a
temporary fix until a better solution is available.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-09-09 22:45:28 -03:00
lynne
1cbf96a8ad
isisd: ldp-igp-sync feature: adding isis support
...
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-09-09 14:38:44 -04:00
lynne
132a782eb8
ospfd: ldp-igp-sync feature: adding ospf support
...
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-09-09 14:38:44 -04:00
Renato Westphal
add39cde9d
lib: fix the "set metric" route-map command
...
The "set metric" command wasn't processing metric additions and
subtractions (using + and -) correctly. Fix those problems.
Also, remove the "+metric" and "-metric" options since they don't
work and don't make any sense (they could be interpreted as unitary
increments/decrements but that was never supported).
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-09-09 14:53:26 -03:00
Karen Schoener
24e7c5c897
lib: adding support for LDP IGP Sync feature
...
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-09-09 11:12:02 -04:00
Karen Schoener
1fe192228b
ldpd: adding topotests for the LDP IGP Sync feature
...
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-09-09 11:12:02 -04:00
Karen Schoener
e1894ff70f
ldpd: Adding support for LDP IGP Synchronization
...
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-09-09 10:45:41 -04:00
Donald Sharp
c8a3405af8
*: Update version string
...
Update the version string to reflect work towards next release
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-09-09 10:10:54 -04:00
Mark Stapp
000ce30ee5
Merge pull request #7047 from qlyoung/fix-zlog-target-null-deref
...
lib: fix possible null dereference in zlog
2020-09-08 15:25:08 -04:00
Donatas Abraitis
28a54742ca
Merge pull request #7031 from dslicenc/global-bgp-update-delay
...
Global bgp update delay
2020-09-08 21:43:51 +03:00
Mark Stapp
46adfaff7a
Merge pull request #7032 from qlyoung/devdocs-libyang-hashtable
...
Dev docs update for libyang, hash table invariants
2020-09-08 13:03:16 -04:00
Donald Sharp
6a8a0f159a
tests: Modify bgpd.conf to have faster keepalive/hold timers
...
Modify bgpd.conf in all easily accessible topotests to use 3 10
as their timers du jour. This will allow the tests to converge
faster.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-09-08 12:58:26 -04:00
Quentin Young
42404aa0c0
doc: update libyang blurb for 1.x
...
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-09-08 12:10:34 -04:00
Quentin Young
5b72a1332b
doc: add notes about hash table invariants
...
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-09-08 12:10:10 -04:00
Donald Sharp
9dc0503345
Merge pull request #6376 from opensourcerouting/bump-libyang-req-version-1.x
...
build, yang: bump libyang minimum required version to 1.0.184
2020-09-08 12:06:10 -04:00
Quentin Young
589b5e4802
lib: fix possible null dereference in zlog
...
In some cases one or both of the zlog targets in use here can be null,
we need to check for that.
Interestingly it appears we don't crash even when this is the case.
Undefined behavior ftw
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-09-08 11:43:40 -04:00
Russ White
5ceb842f45
Merge pull request #6969 from ton31337/feature/autoshutdown_if_rtt_higher_than_specified
...
bgpd: Add `neighbor <neigh> shutdown rtt` command
2020-09-08 11:28:40 -04:00
Don slice
0922d2e56e
topotests: Add test for bgp update-delay configuration
...
Signed-off-by: Don Slice <dslice@nvidia.com>
2020-09-08 04:27:15 -07:00
Don slice
d70583f78d
bgpd: add global config for update-delay
...
Enhancement to update-delay configuration to allow setting globally
rather than per-instance. Setting the update-delay is allowed either
per-vrf or globally, but not both at the same time.
Ticket: CM-31096
Signed-off-by: Don Slice <dslice@nvidia.com>
2020-09-08 04:27:01 -07:00
Donatas Abraitis
91052810f9
doc: Add neighbor <x.x.x.x.> shutdown rtt <milliseconds>
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-09-07 22:30:20 +03:00
Donatas Abraitis
8336c896fd
bgpd: Add neighbor <neigh> shutdown rtt
command
...
This would be useful in cases with lots of peers and shutdown them
automatically if RTT goes above the specified limit.
A host with 512 or more IPv6 addresses has a higher latency due to
ipv6_addr_label(). This method tries to pick the best candidate address
fo outgoing connection and literally increases processing latency.
```
Samples: 28 of event 'cycles', Event count (approx.): 22131542
Children Self Command Shared Object Symbol
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] entry_SYSCALL_64_fastpath
+ 100.00% 0.00% ping6 [unknown] [.] 0x0df0ad0b8047022a
+ 100.00% 0.00% ping6 libc-2.17.so [.] __sendto_nocancel
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] sys_sendto
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] SYSC_sendto
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] sock_sendmsg
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] inet_sendmsg
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] rawv6_sendmsg
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] ip6_dst_lookup_flow
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] ip6_dst_lookup_tail
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] ip6_route_get_saddr
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] ipv6_dev_get_saddr
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] __ipv6_dev_get_saddr
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] ipv6_get_saddr_eval
+ 100.00% 0.00% ping6 [kernel.kallsyms] [k] ipv6_addr_label
+ 100.00% 100.00% ping6 [kernel.kallsyms] [k] __ipv6_addr_label
+ 0.00% 0.00% ping6 [kernel.kallsyms] [k] schedule
```
This is how it works:
```
~# vtysh -c 'show bgp neigh 192.168.0.2 json' | jq '."192.168.0.2".estimatedRttInMsecs'
9
~# tc qdisc add dev eth1 root netem delay 120ms
~# vtysh -c 'show bgp neigh 192.168.0.2 json' | jq '."192.168.0.2".estimatedRttInMsecs'
89
~# vtysh -c 'show bgp neigh 192.168.0.2 json' | jq '."192.168.0.2".estimatedRttInMsecs'
null
~# vtysh -c 'show bgp neigh 192.168.0.2 json' | jq '."192.168.0.2".lastResetDueTo'
"Admin. shutdown"
```
Warning message:
bgpd[14807]: 192.168.0.2 shutdown due to high round-trip-time (200ms > 150ms)
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-09-07 22:30:19 +03:00
Donatas Abraitis
e410d56307
bgpd: Update RTT on KEEPALIVE message
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-09-07 17:25:57 +03:00
Santosh P K
d6165cf543
Merge pull request #6982 from achernavin22/ospf_nssa_after_redist
...
ospfd: install Type-7 when NSSA enabled after redistribution
2020-09-07 18:24:41 +05:30
Donatas Abraitis
b164e7645d
Merge pull request #7040 from qlyoung/fix-evpn-attribute-hash-error
...
bgpd: modify attr fields before hash insert
2020-09-05 15:47:38 +03:00
Donatas Abraitis
5266cab359
Merge pull request #7037 from volta-networks/fix_traps_bgp
...
Fix bgpBackwardTransition traps
2020-09-05 08:28:19 +03:00
Donatas Abraitis
a8b517846c
Merge pull request #7051 from donaldsharp/ospf_test_speedup
...
Ospf test speedup
2020-09-05 08:17:31 +03:00
Donatas Abraitis
1da90d136a
Merge pull request #7054 from qlyoung/fix-bgp-mplsvpn-nlri-missing-length-checks
...
bgpd: fix mplsvpn nlri garbage heap read
2020-09-05 08:17:15 +03:00
Renato Westphal
dcdaabcede
Merge pull request #7046 from qlyoung/fix-various-integer-issues
...
Fix various integer signedness / overflow issues
2020-09-04 22:33:48 -03:00
Renato Westphal
c7b5a0ae3a
Merge pull request #7055 from qlyoung/fix-bgp-localpref-overflow
...
bgpd: fix asserting read of localpref
2020-09-04 18:56:46 -03:00
Renato Westphal
b686742e2b
Merge pull request #6934 from Niral-Networks/niral_dev_vrf_isis_core_pr4
...
isisd, yang, doc : Support for different VRF in ISIS.
2020-09-04 18:44:56 -03:00
Renato Westphal
4c13526b07
Merge pull request #6971 from volta-networks/fix_ldp_no_config
...
ldpd: Fix issue when starting up LDP with no configuration.
2020-09-04 16:39:16 -03:00
Donatas Abraitis
08194f561e
Merge pull request #6589 from NaveenThanikachalam/gr_fixes
...
bgpd: GR fixes
2020-09-04 18:39:26 +03:00
lynne
955357174f
ldpd: Fix issue when starting up LDP with no configuration.
...
LDP would mark all routes as learned on a non-ldp interface. Then
when LDP was configured the labels were not updated correctly. This
commit fixes issues 6841 and 6842.
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
2020-09-04 09:24:47 -04:00
Donatas Abraitis
f6af4aecf4
Merge pull request #6826 from pjdruddy/bgp-auth-vrf-frr
...
Bgp auth vrf frr
2020-09-04 16:03:47 +03:00
Donald Sharp
80334e5acf
Merge pull request #7053 from mjstapp/fix_ospf6_intf_sa
...
ospf6d: fix SA warning
2020-09-04 06:47:07 -04:00
Donald Sharp
dc01e6f3f4
Merge pull request #7052 from mjstapp/fix_stream_get_data
...
lib: remove unused stream_get_data api
2020-09-03 20:45:05 -04:00
Donald Sharp
0022cda07d
Merge pull request #6891 from opensourcerouting/feature/sr-te-bgpd
...
bgpd: Add support for SR-TE Policies in route-maps
2020-09-03 14:52:30 -04:00
Quentin Young
763a5d3c2d
bgpd: use stream_rewind_getp() to remove overflow
...
Passing a negative argument to a size_t parameter creates an overflow
condition
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-09-03 14:23:57 -04:00