Commit Graph

19881 Commits

Author SHA1 Message Date
Mark Stapp
cd4bb96f9d zebra: support backup nhlfes in LSPs
Handle backup nhlfes in LSP zapi messages. Capture backup info
with LSPs, capture backup info in the dataplane LSP processing.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-06-01 14:46:32 -04:00
Mark Stapp
665edffd1e sharpd: include backup nh info with lsps
If present in a configured nexthop_group, include
backup nexthop/nhlfe info with LSP zapi add/update
messages.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-06-01 14:46:32 -04:00
Mark Stapp
ae076fc276 lib: add zapi_nexthop2str()
Add a handy 2str api for zapi nexthop debugging.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-06-01 14:46:32 -04:00
Mark Stapp
daaeaa2150 zebra: init dest's list of routes
Use the dlist init api on the zebra dest object's list
of routes.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-06-01 14:46:32 -04:00
Mark Stapp
34f86754a2 lib: add backup nexthop/nhlfe to zapi label messages
Add backup nexthops/nhlfes to the zapi messages used
to convey LSPs to zebra.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-06-01 14:46:12 -04:00
Mark Stapp
ee70f62979 zebra: convert LSP nhlfe lists to use typesafe lists
Convert the embedded lists of nhlfes and snhlfes in zebra LSPs
and SLSPs to use typesafe dlists.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-06-01 14:46:12 -04:00
Karen Schoener
fd563cc7f3 ldpd: Relay data plane pseudowire status in LDP notification
Provide a way for the data plane to indicate pseudowire
status (such as: not forwarding, AC failure).

On a data plane pseudowire install failure, data plane
sets the pseudowire status.
Zebra relays the pseudowire status to LDP.
LDP includes the pseudowire status in the LDP notification
to the LDP peer.

Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-06-01 13:21:37 -04:00
Donald Sharp
88b5958e31
Merge pull request #6054 from sarav511/dr2ndr
pimd: When DR becomes non DR, Still sends register packets to RP
2020-06-01 07:58:32 -04:00
Russ White
b12b5d2097
Merge pull request #6442 from wesleycoakley/pbrd-showjson
pbrd: Optional JSON output for all `show pbr` directives
2020-06-01 07:44:36 -04:00
Donald Sharp
75e43de7a6
Merge pull request #6048 from sarav511/joinsup
pimd: In join suppression period, join is being sent
2020-06-01 07:36:24 -04:00
Donatas Abraitis
1f0628c7d8
Merge pull request #6467 from qlyoung/fix-bgp-logrotation
bgpd: avoid spamming bgp_accept() on bad vrf sock
2020-06-01 08:46:26 +03:00
Donatas Abraitis
a6796c4141
Merge pull request #6490 from qlyoung/fix-alpine-python3-build
alpine: update packages
2020-06-01 07:57:26 +03:00
Quentin Young
2f9db11bd8 bgpd: avoid spamming bgp_accept() on bad vrf sock
bgp_accept() gets called over and over again when a VRF device is
deleted out from under a bgp listener socket that is bound to it.
Prevent this by noting the error and cancelling ourselves, allowing the
vrf status code to clean up the mess when it receives word about the
change from Zebra.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-05-31 04:28:30 -04:00
Quentin Young
582f35c88c alpine: update packages
Alpine builds have been failing for some time as a consequence of only
installing python 2 development packages when we have build scripts that
require python 3.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-05-31 04:10:33 -04:00
Donatas Abraitis
e0281c9f2f
Merge pull request #6484 from kaloom/master
bgpd: Fix "malformed communities" for accept-own-nexthop
2020-05-31 10:33:57 +03:00
Donatas Abraitis
c6d47a7f02
Merge pull request #6488 from donaldsharp/more_useful_debug
More useful debug
2020-05-31 10:31:54 +03:00
Donald Sharp
450696226d bgpd: Improve connection rejection messages
Try to give a bit more useful data about where we
think the connection is trying to come in from.
Hopefully this will let us debug connection issues
a bit faster in cases where there are config issues.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-30 15:44:54 -04:00
Donald Sharp
1eaa9fc0e5 doc: Fix warning about incorrect underline length
The recent change for more snmp doc gave us a sphinx error.
Let's clean it up.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-30 15:43:30 -04:00
Renato Westphal
a3c669b9e1
Merge pull request #6482 from donaldsharp/update_snmp_rst
doc: Update snmp.rst
2020-05-30 00:17:11 -03:00
Renato Westphal
ca850f0094
Merge pull request #6479 from volta-networks/fix_isis_if_addr_te
isisd: fix issue with local address TE TLV
2020-05-29 23:59:33 -03:00
Donald Sharp
b1ab2bd2df tests: Add a basic test for pbr
Just add a basic test for pbr.  This code
does not actually test installation in the kernel at this
point in time.

What we do do is make sure pbr is in a sane state after
some very basic configuration.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-29 16:56:20 -04:00
Donald Sharp
223f87f4db tests: Setup very basic pbr tests for our topology tests
Just a simple setup for pbr to prove it starts.  Once the json
code for pbr gets in we can add more.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-29 16:56:14 -04:00
Appu Joseph
68f36a94da bgpd: Fix "malformed communities" for accept-own-nexthop
"set community accept-own-nexthop" returns "malformed communities"
error. This is because the token matching hits an earlier "accept-own"
and leaves "-nexthop" as a separate token to be processed.
Reorder the switch cases so that both are processed correctly.

Signed-off-by: Appu Joseph <apjo@kaloom.com>
2020-05-29 14:36:07 -04:00
Emanuele Di Pascale
d80e23f8d3 isisd: fix local address TE TLV
we were not correctly checking the MPLS-TE status of the area when
adding an IP address to a circuit, and this was preventing the local
address TLV to be populated after an interfaced flap.

Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2020-05-29 16:41:16 +02:00
Bart Vrancken
6f6d86069b doc: Update snmp.rst
Updated documentation for routers with a large route table, which breaks
SNMP/AgentX and in some conditions even crashes FRR. The documentation
proposal amends the SNMP configuration to exclude certain OID's that
are not needed in normal cases.

Format-fixed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Signed-off-by: Bart Vrancken <bart@abuse.io>
2020-05-29 08:06:33 -04:00
Renato Westphal
276b698a43
Merge pull request #6481 from donaldsharp/bgp_thread_cancel
bgpd: Use THREAD_CANCEL instead of thread_cancel
2020-05-28 20:28:31 -03:00
Renato Westphal
ca4f4a3660
Merge pull request #6416 from Orange-OpenSource/master
ospfd: Solve crash after removing and adding conf.
2020-05-28 20:03:43 -03:00
Donald Sharp
e2d409a88b bgpd: Use THREAD_CANCEL instead of thread_cancel
We are crashing in thread_cancel on shutdown because
the thread pointer is NULL.  Use the more appropriate
THREAD_CANCEL macro

Ticket: CM-29873
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-28 16:51:11 -04:00
Stephen Worley
c6a9c60f97
Merge pull request #6478 from mjstapp/dev_doc_more_const
doc: encourage const in the developer doc
2020-05-28 15:02:00 -04:00
Mark Stapp
6b2210021c
Merge pull request #6476 from wesleycoakley/zebra-debuglogfix
zebra, lib: bugfix for zebra packet debugging messages
2020-05-28 13:40:39 -04:00
Mark Stapp
7d68dd44ff doc: encourage const in the developer doc
Add a little text about using 'const' in the dev doc.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-05-28 12:37:51 -04:00
Wesley Coakley
f1bc75dac6 lib: stream_hexdump takes const struct
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-28 11:18:11 -04:00
Mark Stapp
5e5e7a6cde
Merge pull request #6466 from opensourcerouting/frr-reload-cleanup
tools/frr-reload: cleanup + `--vty_socket`
2020-05-28 11:06:20 -04:00
Mark Stapp
ef5c9dd6be
Merge pull request #6475 from donaldsharp/pim_thread_cancel
pimd: Fix crash on restart from thread_cancel
2020-05-28 11:02:57 -04:00
Wesley Coakley
9d72660d67 zebra, lib: bugfix on zebra packet debugging
`debug zebra packet detail` dumps the full message whereas
it had been dropping exactly 10 bytes, the size of the zebra header

Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-28 10:48:56 -04:00
Donald Sharp
5308f26738
Merge pull request #6474 from ton31337/fix/doc_bgp_community
doc: Update BGP show bgp (ext|large-)community-list commands
2020-05-28 08:55:16 -04:00
Donald Sharp
c58a47ea2e pimd: Fix crash on restart from thread_cancel
We were using thread_cancel() directly instead of
THREAD_OFF which correctly ensures the pointer is not NULL.

Ticket:CM-29866
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-28 08:53:13 -04:00
Donatas Abraitis
36dc43aae3 doc: Update BGP show bgp (ext|large-)community-list commands
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-05-28 12:34:24 +03:00
Donald Sharp
c0b664a187
Merge pull request #6469 from mjstapp/add_ubu_20_doc
doc: add dev doc for ubuntu 20.04
2020-05-27 10:43:05 -04:00
Donald Sharp
2011994ee6
Merge pull request #6447 from opensourcerouting/rename-bgp-vrf-leak
topotest: refactory BGP VRF leak basic test
2020-05-27 10:34:13 -04:00
Wesley Coakley
3e81618d0c pbrd, lib, doc: fix new show json key semantics
Revise new `show pbr` keys to be consistent with existing
json in other daemons

target->nexthop
id->tableId (where relevant)
isValid->valid
isInstalled->installed

Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
f9368f896b pbrd, doc: pbr map json sequences -> policies
Semantics

Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
144fd50f64 doc: document json for remaining show pbr cmds
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
9667c597e9 doc: document show pbr interface directive
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
dadba1a23f pbrd: show directives give arrays where appropos
The new json output for the `show pbr` directives return arrays instead
of associative arrays, which are more meaningful in this context

Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
81c0078ef4 pbrd, lib: verbosity++ for json show directives
Increased the verbosity of the json keys and flattened the returned
structure by removing superfluous keys.

Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
010dd8edcb pbrd, lib: opt. json for show pbr nexthop-group
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
1a8cafe19c pbrd: optional json for show pbr map
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Wesley Coakley
7a7b0c13f9 pbrd: json added to show pbr interface [json]
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
2020-05-27 10:28:02 -04:00
Mark Stapp
252ca75b61 doc: add dev doc for ubuntu 20.04
Add a doc for ubuntu 20 LTS; it's mainly the same as the 18 LTS
doc, with a couple of extra notes.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-05-27 08:49:36 -04:00