proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-13 23:32:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
18,604 Commits 4 Branches 191 Tags 125 MiB
1f713948c6
Commit Graph

18604 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donald Sharp
4dcc227611 zebra: Dissallow a /32 or /128 through itself 
Do not allow an upper level protocol to send a route to
zebra that is a /32 or a /128 that recurses through itself.

Current behavior:
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 01:05:28
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:01:50
C>* 192.168.209.0/24 is directly connected, enp0s8, 01:05:28
C>* 192.168.210.0/24 is directly connected, enp0s9, 01:05:28
D>* 192.168.210.43/32 [150/0] via 192.168.210.44, enp0s9, 01:01:57
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 01:05:15
C>* 192.168.212.0/24 is directly connected, enp0s10, 01:05:28
donna.cumulusnetworks.com# sharp install routes 40.0.0.1 nexthop 192.168.210.44
% Command incomplete: sharp install routes 40.0.0.1 nexthop 192.168.210.44
donna.cumulusnetworks.com# sharp install routes 40.0.0.1 nexthop 192.168.210.44 1
donna.cumulusnetworks.com# end
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 01:05:51
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:00:12
D>* 40.0.0.1/32 [150/0] via 192.168.210.44, enp0s9, 00:00:03
C>* 192.168.209.0/24 is directly connected, enp0s8, 01:05:51
C>* 192.168.210.0/24 is directly connected, enp0s9, 01:05:51
D>* 192.168.210.43/32 [150/0] via 192.168.210.44, enp0s9, 01:02:20
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 01:05:38
C>* 192.168.212.0/24 is directly connected, enp0s10, 01:05:51
donna.cumulusnetworks.com#

Fixed behavior:

donna.cumulusnetworks.com# sharp install routes 192.168.210.44 nexthop 192.168.210.44 1
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 00:00:15
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:00:15
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:00:15
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:00:15
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 00:00:03
C>* 192.168.212.0/24 is directly connected, enp0s10, 00:00:15
donna.cumulusnetworks.com# sharp install routes 40.0.0.1 nexthop 192.168.210.44 1
donna.cumulusnetworks.com# show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

K>* 0.0.0.0/0 [0/104] via 10.0.2.2, enp0s3, 00:00:24
C>* 10.0.2.0/24 is directly connected, enp0s3, 00:00:24
D>* 40.0.0.1/32 [150/0] via 192.168.210.44, enp0s9, 00:00:02
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:00:24
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:00:24
D   192.168.210.44/32 [150/0] via 192.168.210.44 inactive, 00:00:12
C>* 192.168.212.0/24 is directly connected, enp0s10, 00:00:24
donna.cumulusnetworks.com#

This behavior came up from discussion around issue #5159.  Where
OSPF was receiving a route through itself as part of the router link
lsa.  I currently think that ospf should probably dissallow this in ospf
but we should also do the right thing in zebra.  If we do not allow this
change we can have situations where ordering of routes into zebra suddenly
matters.

Fixes: #5159
Signed-off-by: Donald Sharp <sharpd@cumulsunetworks.com>
 2019-10-18 10:37:28 -04:00
Renato Westphal
dfd7b62ddd
Merge pull request #5172 from donaldsharp/sa_clean_and_clean 
Sa clean and clean
 2019-10-17 23:14:31 -03:00
Renato Westphal
ca83094d26
Merge pull request #5182 from qlyoung/fix-doc-index-read-quanta 
doc: fix read-quanta .. index copy-paste err
 2019-10-17 23:11:05 -03:00
Quentin Young
2e6c9a1db5
Merge pull request #5181 from ghasemnaddaf/vrrp_updates 
vrrpd: use CS2MS instead of constant 10 everywhere
 2019-10-17 18:55:08 -04:00
Ghasem Naddaf
de7fe61e10 vrrpd: use CS2MS instead of constant 10 everywhere 
Signed-off-by: Ghasem Naddaf <ghasem.naddaf@gmail.com>

vrrpd: use CS2MS instead of constant 10 everywhere

Signed-off-by: Ghasem Naddaf <ghasem.naddaf@gmail.com>
 2019-10-17 15:54:04 -07:00
Mark Stapp
123ea351a4 nhrpd: clean up SA warning 
Try to signal to SA/clang more clearly to clean up an SA warning
in the nhrp-specific linkedlist code.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-10-17 16:08:47 -04:00
Quentin Young
dad83b6745 doc: fix read-quanta .. index copy-paste err 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-17 19:53:19 +00:00
Donald Sharp
0997ca9669
Merge pull request #5179 from ashish12pant/large_comm 
tests: bgp community and bgp large-community
 2019-10-17 13:47:20 -04:00
Sri Mohana Singamsetty
03e484aafa
Merge pull request #5165 from donaldsharp/evpn_fixup 
bgpd: return created bgp_path_info
 2019-10-17 10:15:01 -07:00
Mark Stapp
5b724d424b
Merge pull request #5171 from donaldsharp/remove_getrusage 
*: Allow disabling of `getrusage` calls
 2019-10-17 12:26:28 -04:00
Mark Stapp
10e75ceb6a
Merge pull request #5150 from qlyoung/bgp-vector-io-4 
BGP vector I/O - Redux
 2019-10-17 10:57:47 -04:00
Mark Stapp
da1cf7f2e8
Merge pull request #5161 from sworleys/Fix-Rule-Dbl-Free 
lib,zebra: Fix PBR Rule Ifp Reference if Interface is Deleted
 2019-10-17 10:31:40 -04:00
Mark Stapp
9cd06d69ad
Merge pull request #5175 from opensourcerouting/debug-nb-yang 
lib, vtysh: add new libyang option to the "debug northbound" command
 2019-10-17 10:07:05 -04:00
Sri Mohana Singamsetty
e75bbefa0e
Merge pull request #5167 from mjstapp/test_nhrp_list_sa 
nhrpd: be more careful in linkedlist macro
 2019-10-16 22:22:05 -07:00
Donatas Abraitis
5307ffd0fd
Merge pull request #5176 from qlyoung/alpine-update-mpfr-dep 
fix alpine 🎿🎿🎿 docker build 🛠️
 2019-10-17 08:13:01 +03:00
Ashish Pant
85d4777301 tests: Add test cases for bgp community and large community 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Test cases to check functionality of bgp large community and
bgp community path attribute
 2019-10-17 09:19:26 +05:30
Ashish Pant
6d32a6a18a tests: Update cli error list and retry function 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Add cli error returned for invalid bgp-community-list command

Fix retry function to avoid retries when expected is False
 2019-10-17 09:17:03 +05:30
Ashish Pant
06e693f11b tests: Update bgp api for community and aggregate address 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Add support for not sending community data in bgp and update
aggregate address configuration code
 2019-10-17 09:17:03 +05:30
Ashish Pant
ca2ef9e6ff tests: Add verify community list api 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Api checks if community list is present in the system or not
 2019-10-17 09:17:03 +05:30
Ashish Pant
287d692409 tests: Add step api in topojson 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Print messages with a step number to log from test case
 2019-10-17 09:17:03 +05:30
Quentin Young
338728fb71 alpine: clean up dep block 
Wrap to 80 cols...

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-16 20:38:27 +00:00
Quentin Young
7d29ff567c alpine: update mpfr3 -> mpfr4 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-16 20:37:44 +00:00
Renato Westphal
07705c8b8a lib: silence compiler warning in the gRPC plugin 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2019-10-16 17:13:28 -03:00
Renato Westphal
62ae9adeef lib, vtysh: add new libyang option to the "debug northbound" command 
Guard the libyang debug messages under this command so that only
people interested on those messages will see them.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2019-10-16 17:11:41 -03:00
Renato Westphal
21f5aade3d vtysh: remove DEFPY variable names 
Some DEFPY commands were copied to vtysh without being cleaned up
properly. Fix this.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2019-10-16 17:09:09 -03:00
Russ White
718804149e
Merge pull request #5078 from lkrishnamoor/advertise-routes 
bgpd: Fix "show bgp l2vpn evpn neighbors x.x.x.x advertised-routes json"
 2019-10-16 15:05:23 -04:00
Russ White
b42d15054d
Merge pull request #5118 from lkrishnamoor/routes_json 
bgpd: Fix in "show bgp l2vpn evpn neighbors X.X.X.X routes json"
 2019-10-16 15:01:13 -04:00
Donald Sharp
401b063670 bgpd: In redistribution aspath cannot be NULL 
Coverity has found a path where the attr.aspath may be NULL.

assert that the aspath is non-null so we can make this go away.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 13:38:29 -04:00
Donald Sharp
8f79e2cf65 zebra: zrt->table cannot crash here 
If we have a zrt data structure then we have a table pointer
as well.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 13:38:29 -04:00
Donald Sharp
d06244b7d4 lib: Coverity SA doesn't trust the CLI 
Fix with some asserts to show Coverity SA that we mean
real(:trademark:) business.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 13:38:29 -04:00
Donald Sharp
05864da791 bgpd: struct bgp_path_info *->attr must not be NULL 
We make the assumption that ->attr is not NULL throughout
the code base.  We are totally inconsistent about application
of this though.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 13:38:29 -04:00
Donald Sharp
e10dda5773 doc: Add MRAI timer documentation to bgp docs 
We were missing the bgp MRAI timer documentation.  Add it in.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 13:38:29 -04:00
Donald Sharp
d38c6bb1b0 bgpd: Check setsockopt return codes 
Let end user know that a setsockopt failed and we may
be experiencing degraded performance.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 13:38:29 -04:00
Donald Sharp
f75e802d8a *: Allow disabling of getrusage calls 
getrusage, in a heavily stressed system, can account for
signficant running time due to process switching to the kernel.
Allow the end-operator to specify `--disable-cpu-time` to
avoid this call.  Additionally we cause `show thread cpu` to
not show up if this is selected.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 13:34:59 -04:00
Mark Stapp
bd2b75a21e nhrpd: be more careful with linked lists 
NHRPD has its own linked-list implementation, and one of the
apis is a little free and easy with pointers. Also be safer
with one list iteration operation.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-10-16 11:01:41 -04:00
Quentin Young
e312b6c6c7 doc: add documentation for write- and read-quanta 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-10-16 14:41:54 +00:00
Donald Sharp
30c9a17229
Merge pull request #5155 from GalaxyGorilla/libyang_debug_logging 
lib: Let libyang log everything possible
 2019-10-16 09:11:48 -04:00
Donald Sharp
11a9a23664 doc: Add cli options for bgp to documentation 
Document the bgp cli options.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 07:42:45 -04:00
Donald Sharp
c2d020ad71 bgpd: Add ability to set tcp socket buffer size 
Add -s X or --socket_size X to the bgp cli to allow
the end user to specify the outgoing bgp tcp kernel
socket buffer size.

It is recommended that this option is only used on
large scale operations.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 07:42:05 -04:00
Donald Sharp
772aae8b1d lib: Add getsockopt_so_recvbuf 
Add a new function getsockopt_so_recvbuf which tells you the
operating systems receive buffer size.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 07:42:05 -04:00
Donatas Abraitis
3f93a5d301
Merge pull request #5139 from donaldsharp/zebra_write_cmd_missing 
lib, zebra: Fix last write command written
 2019-10-16 14:18:17 +03:00
Donald Sharp
c011a88bb5 bgpd: return created bgp_path_info 
In bgp_create_evpn_bgp_path_info we create a bgp_path_info
that should be returned since we need it later.

Found by Coverity Scan.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-10-16 07:02:55 -04:00
GalaxyGorilla
966799385e lib: Let libyang log everything possible 
Currently libyang logs errors only (LY_LLERR by default), independent of
FRR's log level. This commit lets libyang log everything including all
sorts of debug logs (when libyang is built in 'Debug' mode). FRR's
logging infrastructure filters logs out according to the configured log
level.

There is a very small performance overhead involved, even when libyang
is build in 'Release' mode. This overhead is mainly affecting config
processing and barely measurable being around 0-3% of the processing
time without this change.

Signed-off-by: Sascha Kattelmann <sascha@netdef.org>
 2019-10-16 08:59:53 +00:00
Donald Sharp
b60afd5c38
Merge pull request #5097 from ton31337/fix/do_not_reconnect_if_prefix_overflow 
bgpd: Keep the session down if maximum-prefix is reached
 2019-10-15 16:18:19 -04:00
Donald Sharp
36c9027ac7
Merge pull request #5088 from pogojotz/revert-asm-equiv-in-MTYPE 
lib: Revert usage of asm-code in MTYPE definitions
 2019-10-15 15:49:31 -04:00
Stephen Worley
b19d55d048 zebra: Don't bother ref'ing ifp in zebra_pbr_rule 
If we only really use the ifp for the name, then
don't bother referencing the ifp. If that ifp is
freed, we don't expect zebra to handle the rules that
use it (that's pbrd's job), so it is going to be
pointing to unintialized memory when we decide to remove
that rule later. Thus, just keep the name in the data
and dont mess with pointer refs.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-15 15:39:49 -04:00
Quentin Young
e5ab18eb08
Merge pull request #5134 from sudhanshukumar22/bgp-snmp-issue 
lib: changes for making snmp socket non-blocking
 2019-10-15 15:33:38 -04:00
Quentin Young
11c6d7bd4f
Merge pull request #5145 from Spantik/2796 
lib: Clean up the index that is being used for storing FD and events.
 2019-10-15 15:27:51 -04:00
Stephen Worley
b77a69bdc6 zebra: Use the rule ifindex as a hash key, not ifp 
Use the ifindex value as a primary hash key/identifier, not
the ifp pointer. It is possible for that data to be freed
and then we would not be able to hash and find the rule entry
anymore. Using the ifindex, we can still find the rule even
if the interface is removed.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-15 15:03:46 -04:00
Stephen Worley
3dabc387a6 lib: Use ifindex_t for struct pbr_rule 
We should be using the ifindex_t typedef here for the
type, not uint32_t.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
 2019-10-15 15:03:45 -04:00