Donatas Abraitis
8f5e706a2f
Merge pull request #11201 from donaldsharp/unused_in_netlink_compiles
...
Remove some unused functions in zebra
2022-05-16 09:57:30 +03:00
anlan_cs
f33bf7c0eb
bgpd: remove unnecessary check for evpn
...
Since `bgp->vnihash` is naturally non-NULL, remove check for this field.
Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-05-15 01:32:14 -04:00
Donatas Abraitis
c03ba18417
doc: Add RFC8538 to our supported RFC list
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-05-14 21:46:01 +03:00
Donatas Abraitis
20170775da
bgpd: Activate Graceful-Restart when receiving CEASE/HOLDTIME notifications
...
If we receive CEASE Notification or HOLDTIME notification, retain STALE
routes if it's not a CEASE/Hard Reset.
When doing `clear ip bgp PEER`, we can control if this would be CEASE/Hard Reset
or not by using `bgp hard-administrative-reset` knob.
When `bgp graceful-restart notification` is disabled, STALE routes won't be
retained when receiving Notification message.
Co-authored-by: Biswajit Sadhu <biswajit.sadhu@gmail.com>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-05-14 21:43:55 +03:00
Donatas Abraitis
64643ba79a
Merge pull request #11180 from fdumontet6WIND/flag_pre_post
...
BMP fix invalid bmp POST POLICY flag
2022-05-14 21:16:19 +03:00
Donatas Abraitis
9845703603
Merge pull request #11135 from donaldsharp/bgp_rpki_no_forms
...
bgpd: Fix no form of rpki commands to take values
2022-05-14 21:15:54 +03:00
Donatas Abraitis
e78ec23c02
Merge pull request #11149 from donaldsharp/update_group_debugging
...
Update group debugging
2022-05-14 21:15:03 +03:00
Donald Sharp
14faecad14
Merge pull request #11202 from anlancs/fix/check_zebra_vrf_get_evpn
...
zebra: remove unnecessary check for "zevpn_vrf"
2022-05-14 09:53:42 -04:00
anlan_cs
81157cbd10
zebra: remove unnecessary check for "zevpn_vrf"
...
The global vrf in zebra is always non-NULL. In general, it is bound to
default vrf by `zebra_vrf_init()`, at other times bound to some specific
vrf. Anyway, non-NULL.
So remove all redundant checkings for the returned value of
`zebra_vrf_get_evpn()`.
Additionally, remove the unnecessary check for `zvrf` in
`zebra_vxlan_cleanup_tables()`.
Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-05-13 23:31:52 -04:00
Donald Sharp
20ceb5475d
zebra: Remove unused function route_entry_copy_nexthops
...
This function is no longer used.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-05-13 16:11:09 -04:00
Donald Sharp
388907d53c
zebra: Remove unused functions in netlink compiles
...
When compiling with netlink, Remove the usage of these
functions.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-05-13 15:58:33 -04:00
Pavel Shirshov
425bd64be8
bgpd: Allow bgp to control the DSCP session TOS value
...
Allow BGP to control the TOS DSCP value in the tcp header
via a new command at the bgp global level `bgp session-dscp <0-63>`
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Pavel Shirhov <pavelsh@microsoft.com>
2022-05-13 14:14:35 -04:00
Donald Sharp
3743e0c300
Merge pull request #11198 from opensourcerouting/fix/show_ip_bgp_l2vpn_evpn_rd_neighbor_routes_unint
...
bgpd: Initialize prd for show_ip_bgp_l2vpn_evpn_rd_neighbor_routes()
2022-05-13 14:01:33 -04:00
Donald Sharp
64b43136b9
Merge pull request #11195 from anlancs/fix/lib-qsort
...
lib: add one check in "list_sort()"
2022-05-13 11:49:51 -04:00
Donald Sharp
c30c607027
zebra: Add encap and group type decoding to nexthop dump
...
Add the ability to give data about the nexthop group type
and encap type so that it is human readable.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-05-13 10:37:30 -04:00
Jafar Al-Gharaibeh
a17ced5243
Merge pull request #10958 from patrasar/pim_passive
...
pimd: introduce ip pim passive command
2022-05-13 08:39:12 -05:00
Donald Sharp
34d8aff15b
bgpd: Add a bit of debug to give us data about how an update group is formed
...
The creation of the update group is a tiny bit of a black box and is hard
to figure out by hand if it is correct. Add a bit of code so that FRR
operators/developers can determine if the update group categorization
makes us happy.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-05-13 08:48:32 -04:00
Donatas Abraitis
3d2b35c40b
bgpd: Initialize prd for show_ip_bgp_l2vpn_evpn_rd_neighbor_routes()
...
*** CID 1517751: Uninitialized variables (UNINIT)
/bgpd/bgp_evpn_vty.c: 1648 in show_ip_bgp_l2vpn_evpn_rd_neighbor_routes()
1642
1643
1644 if (rd_all)
1645 return bgp_show_ethernet_vpn(vty, NULL, bgp_show_type_neighbor,
1646 peer, SHOW_DISPLAY_STANDARD, uj);
1647 else
>>> CID 1517751: Uninitialized variables (UNINIT)
>>> Using uninitialized element of array "prd.val" when calling "bgp_show_ethernet_vpn".
1648 return bgp_show_ethernet_vpn(vty, &prd, bgp_show_type_neighbor,
1649 peer, SHOW_DISPLAY_STANDARD, uj);
1650 }
1651
1652 DEFUN(show_ip_bgp_l2vpn_evpn_neighbor_advertised_routes,
1653 show_ip_bgp_l2vpn_evpn_neighbor_advertised_routes_cmd,
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-05-13 15:41:16 +03:00
Donald Sharp
d032ddcedc
bgpd: Make bgp_debug.[ch] take const struct peer *
and return bool
...
Several functions in bgp_debug.[ch] take a const struct peer *
and also return a bool instead of an int.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-05-13 08:40:41 -04:00
Donald Sharp
4dc6d51122
Merge pull request #11197 from opensourcerouting/feature/gr_notification_docs
...
doc: Add some more documentation about Notification support for GR
2022-05-13 08:36:41 -04:00
Donald Sharp
e9f709e5ea
bgpd: Fix no form of rpki commands to take values
...
Fix the no forms of some rpki commands to take variable
values on the no form. So that people cut-n-pasting while
adding a no works.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-05-13 07:44:55 -04:00
Donatas Abraitis
ef013a6985
Merge pull request #11194 from donaldsharp/untrusted
...
Some more Coverity issues solved
2022-05-13 14:43:11 +03:00
Donald Sharp
f205a2309c
Merge pull request #11177 from opensourcerouting/fix/memset_memcpy
...
*: memcpy/memset zeroing
2022-05-13 07:40:58 -04:00
Donald Sharp
69df174216
Merge pull request #11188 from opensourcerouting/fix/argv_find
...
bgpd: Cleanup
2022-05-13 07:35:57 -04:00
Igor Ryzhov
a4df11489c
Merge pull request #9454 from anlancs/fix-ospf6-gr-length
...
ospf6d: suppress coverity warnings of insecure data handling
2022-05-13 14:25:06 +03:00
Loganaden Velvindron
0c99696f30
zebra: Add startup message and display netlink buffer size.
...
Add startup message and display netlink buffer size.
Signed-off-by: Loganaden Velvindron <logan@cyberstorm.mu>
2022-05-13 14:58:18 +04:00
Donatas Abraitis
19f980551c
doc: Add some more documentation about Notification support for GR
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-05-13 12:45:25 +03:00
sarita patra
c28e6ef53c
tests: Inroduced pim passive test cases
...
Co-authored-by: Vijay Kumar Gupta <vijayg@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:22 -07:00
sarita patra
9726536d1d
pimd: Northbound support for pim passive enable
...
Added nothbound callbacks for pim-passive-enable
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
fd3eb43d76
pimd: Disable receiving BSM on passive interface
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
c473c7452a
pimd: Disable receiving assert msg on passive interface
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
b9695c6d04
pimd: Disable receiving join/prune on passive interface
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
1e8f260cd4
pimd: Disable receiving register-stop on passive interface
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
b4afc283e9
pimd: Disable receiving register msg on passive interface
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
39c2130e82
pimd: Disable receiving hello on passive interface
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
11e771be61
pimd: Handling hello send statistics for passive interface
...
Increment pim_ifstat_hello_sent only when interface is
passive disabled.
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
6dd493b80b
pimd: Handling reg and reg_stop send statistics for passive interface
...
Increment pim_ifstat_reg_stop_send & pim_ifstat_reg_send when
interface is passive disabled.
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
2287056228
pimd: Handling Join/Prune statistics for passive interface
...
Increment pim_ifstat_prune_send only when interface is
passive disabled.
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
ac5c9346b7
pimd: Handling BSM send statistics for passive interface
...
Increment pim_ifstat_bsm_tx only when interface is
passive disabled.
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
51660af8ff
pimd: Handling assert send statistics for passive interface
...
Increment pim_ifstat_assert_send only when interface is
passive disabled.
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
650d901347
doc: add ip[v6] pim passive support
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
7be33c5b4a
pimd: display passive in show ip pim interface cmd
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
2a66cf6309
pimd: show ip[v6] pim passive in show running config
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
03c106bf30
pimd: Disable sending of control packets on passive interface
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
78039cb25d
pimd: introduced flags for pim_passive_enable
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
51491fdc13
pim6d: introduce ipv6 pim passive command
...
Added a new cli command "ip pim passive" in the interface context,
to disable sending of pim control packets on the interface.
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:51:21 -07:00
sarita patra
d017bf3cb0
pimd: introduce ip pim passive command
...
Added a new cli command "ip pim passive" in the interface context,
to disable sending of pim control packets on the interface.
Signed-off-by: sarita patra <saritap@vmware.com>
2022-05-12 23:50:06 -07:00
Donatas Abraitis
6189cb3cf5
Merge pull request #11190 from donaldsharp/bgp_data
...
Fix #11178 and various other cleanup
2022-05-13 09:00:08 +03:00
anlan_cs
2f58dc31e8
lib: add one check in "list_sort()"
...
Add one check in `list_sort()`:
Immediatly return if no any items in this list.
Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-05-12 22:36:54 -04:00
Donald Sharp
e51c0f771d
bfdd: Prevent coverity from thinking values are uninited
...
Coverity is claiming that bfdd is able got have bglobal.bg_use_dplane
can be true, while dplane_addr can be uninitialized. Not really
possible since global variables are initialized to all 0's. In
any event. Force it to think it can't go there.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-05-12 16:58:29 -04:00