proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-16 04:50:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
31,581 Commits 4 Branches 191 Tags 125 MiB
0de7b43308
Commit Graph

31581 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donald Sharp
48055cc48e
Merge pull request #13237 from LabNConsulting/chopps/fixriptest 
tests: fix cause of intermittent failure
 2023-04-08 09:23:22 -04:00
Christian Hopps
8d6765aa6d tests: fix cause of intermittent failure 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-08 04:03:11 +00:00
Mark Stapp
a63fecfb56 ospf,ospf6: fix json key typo supoort 
Fix json key 'supoort' -> 'support'; add 1-year deprecation
notice; fix topotests to use corrected json key.

Signed-off-by: Mark Stapp <mjs@labn.net>
 2023-04-07 16:19:01 -04:00
Mark Stapp
c42ac5f64b tests: replace deprecated ospf json keys 
Replace many deprecated json keys in topotests after removing
those keys from ospfd.

Signed-off-by: Mark Stapp <mjs@labn.net>
 2023-04-07 16:17:59 -04:00
Mark Stapp
f5419bf927 ospfd: remove deprecated json attrs for neighbor show 
The date for removing some deprecated json attributes from
'show neighbor' has arrived, so remove the attrs (and the
CPP_NOTICE block).

Signed-off-by: Mark Stapp <mjs@labn.net>
 2023-04-07 16:17:59 -04:00
Jafar Al-Gharaibeh
d5243675f2
Merge pull request #13109 from LabNConsulting/topotest-cleanup 
minor topotest cleanup
 2023-04-07 14:45:33 -05:00
Igor Ryzhov
083369e16a
Merge pull request #13228 from LabNConsulting/chopps/json-via-yang 
Update ripd YANG operational state (ECMP routes)
 2023-04-07 17:56:54 +03:00
Donatas Abraitis
83c78d54c2 tests: Check if RIP allow-ecmp command works correctly 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 04:21:25 -04:00
Christian Hopps
7fd2ffb96c ripd: implement new YANG operational state 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 04:21:17 -04:00
Christian Hopps
0b7f0e3548 ripd: yang: extend nexthops functionality in YANG model - skeleton 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 04:20:51 -04:00
Keelan10
c123d2dee0 lib: Fix link state memory leak 
Free link message data when a delete event is recorded.

Signed-off-by: Keelan Cannoo <keelan.cannoo@icloud.com>
 2023-04-07 11:41:21 +04:00
Donatas Abraitis
0633fb7856
Merge pull request #13162 from donaldsharp/pass_by_value_no_no_no 
*: Use a `struct prefix *p` instead of a `struct prefix` in functions
 2023-04-07 10:19:09 +03:00
Donatas Abraitis
9261fbdc6e
Merge pull request #13222 from donaldsharp/limit_scope 
Limit scope
 2023-04-07 10:14:54 +03:00
Christian Hopps
19003d6e99 tests: don't warn with expected results 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 05:58:15 +00:00
Christian Hopps
fa773d1109 tests: initialize parent test namespace too 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 05:56:12 +00:00
Christian Hopps
66707495d9 tests: cleanup infra 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 05:56:12 +00:00
Christian Hopps
cd453c23f6 tests: create 8 link, switch pairs, not 8 links on one switch 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 05:56:12 +00:00
Christian Hopps
eb9e801f8b tests: don't flush ipv6 addresses 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-07 05:56:12 +00:00
Christian Hopps
01bdc91ef5 yang: fix YANG lint 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-06 21:47:20 -04:00
Donald Sharp
b589466918 *: Use a struct prefix *p instead of a struct prefix in functions 
When passing a prefix into a function let's pass by address instead
of pass by value.  Let's save our stack space.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-04-06 18:00:09 -04:00
Donald Sharp
aa056a2a64 bgpd: Treat withdraw variable as a bool 
Used as a bool, treated as a bool.  Make it a bool

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-04-06 17:41:32 -04:00
Mark Stapp
6e6e1020dd ospfd: support configuration of socket buffer sizes 
Add configurable socket send and receive buffer sizes,
configured at the instance level.

Signed-off-by: Mark Stapp <mjs@labn.net>
 2023-04-06 14:16:43 -04:00
anlan_cs
d3ec0066e5 ripd: Fix memory leak for ripd's route-map 
When cleaning `ripd`, it should free `ctx->name` of `struct if_rmap_ctx`,
not `ctx` itself.  Otherwise, it will lead to memory leak.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
 2023-04-06 21:30:08 +08:00
Donald Sharp
cfd04dcb3e bgpd: Limit flowspec to no attribute means a implicit withdrawal 
All other parsing functions done from bgp_nlri_parse() assume
no attributes == an implicit withdrawal.  Let's move
bgp_nlri_parse_flowspec() into the same alignment.

Reported-by: Matteo Memelli <mmemelli@amazon.it>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-04-06 07:13:30 -04:00
Donald Sharp
78745b8700 bgpd: Conform bgp_packet.h with coding standards 
FRR's standards state that function declarations should
have actual variable names for parameters passed in.
Let's make this so for bgp_packet.h

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-04-06 07:13:29 -04:00
Donatas Abraitis
cf35e49354
Merge pull request #13214 from chiragshah6/fdev2 
zebra:return empty dict in json when evpn is disabled
 2023-04-06 12:48:52 +03:00
Jafar Al-Gharaibeh
02619b5522
Merge pull request #13220 from mjstapp/fix_zebra_gr_client 
zebra: null-check client pointer during GR processing
 2023-04-05 22:53:00 -05:00
Mark Stapp
27552b48ab zebra: null-check client pointer during GR processing 
Add a null check.

Signed-off-by: Mark Stapp <mjs@labn.net>
 2023-04-05 12:30:52 -04:00
rgirada
83b78f43f4 mgmtd: Fixing style warnings 
Description:
	Fixing the style warnings in the mgmtd code.

Signed-off-by: Rajesh Girada <rgirada@vmware.com>
 2023-04-05 10:30:24 +00:00
rgirada
93d4e355d8 mgmtd: Fixing code coverity issues in mgmtd 
Description:
	the following list of coverity issues seen in mgmtd code.
	1. CID 1536832:  Memory - corruptions  (OVERLAPPING_COPY)
	   /mgmtd/mgmt_history.c: 85 in mgmt_history_create_cmt_rec()
	2. CID 1536831:  Error handling issues  (NEGATIVE_RETURNS)
	   /mgmtd/mgmt_be_server.c: 123 in mgmt_be_server_start()
	3. CID 1536830:  Resource leaks  (RESOURCE_LEAK)
	   /mgmtd/mgmt_history.c: 146 in mgmt_history_read_cmt_record_index()
	4. CID 1536829:  Error handling issues  (NEGATIVE_RETURNS)
	   /mgmtd/mgmt_fe_server.c: 123 in mgmt_fe_server_start()
	5. CID 1536828:  Possible Control flow issues  (DEADCODE)
	   /mgmtd/mgmt_txn.c: 1859 in mgmt_txn_get_config()
	6. CID 1536827:  Null pointer dereferences  (NULL_RETURNS)
           /mgmtd/mgmt_ds.c: 526 in mgmt_ds_delete_data_nodes()

Signed-off-by: Rajesh Girada <rgirada@vmware.com>
 2023-04-05 10:29:14 +00:00
Donatas Abraitis
27a0311fcc
Merge pull request #13194 from Keelan10/sharpd-memory-leak 
[WIP] sharpd: fix leak
 2023-04-05 10:05:49 +03:00
Sindhu Parvathi Gopinathan
61f3a6c353 zebra:return empty dict when evpn is disabled 
"show evpn json" returns nothing when evpn is disabled.

Code has been fixed to return {} when evpn is disabled or no entry
available.

Before Fix:-
```
cumulus@r2:mgmt:~$ sudo vtysh -c "show evpn json"
cumulus@r2:mgmt:~$
```

After Fix:-
```
cumulus@r1:mgmt:~$ sudo vtysh -c "show evpn json"
{
}
cumulus@r1:mgmt:~$
```

Ticket:#3417955

Issue:3417955

Testing: UT done

Signed-off-by: Chirag Shah <chirag@nvidia.com>
Signed-off-by: Sindhu Parvathi Gopinathan <sgopinathan@nvidia.com>
 2023-04-04 19:41:25 -07:00
Jafar Al-Gharaibeh
92c4494ce5
Merge pull request #13145 from donaldsharp/do_delete 
Improve and fix zebra GR
 2023-04-04 21:10:54 -05:00
Mark Stapp
38a2e2cb26 zebra: fix race during shutdown 
During shutdown, the main pthread stops the dplane pthread
before exiting. Don't try to clean up any events scheduled
to the dplane pthread at that point - just let the thread
exit and clean up.

Signed-off-by: Mark Stapp <mjs@labn.net>
 2023-04-04 16:37:38 -04:00
Jafar Al-Gharaibeh
117bc6ba2b
Merge pull request #13206 from opensourcerouting/fix/docker_build_alpine_protobuf 
docker: Install missing dependencies for Alpine build
 2023-04-04 13:36:28 -05:00
Jafar Al-Gharaibeh
f25a43ad12
Merge pull request #13200 from kuldeepkash/socat_cleanup 
tests: [topojson] multicast pimv6 socat cleanup
 2023-04-04 13:36:03 -05:00
Jafar Al-Gharaibeh
bfea578df1
Merge pull request #13209 from LabNConsulting/chopps/log-redux 
tests: lower logging level on some infra logs
 2023-04-04 13:34:51 -05:00
Isabella de Leon
bb6ef345ad doc: Add CLI documentation for new log-pdu-drops config 
Update isisd docs with log-pdu-drops config.

Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
 2023-04-04 09:25:34 -07:00
Isabella de Leon
4b24eae01d isisd: Add log-pdu-drops log functionality 
If log-pdu-drops is configured, create an INFO log that displays the PDU type and drop counts when a PDU drop is detected.

Example logs:

2023/03/30 23:54:59.749 ISIS: [VAS9N-1JNNR] PDU drop detected of type: P2P IIH. 1 Total Drops; 0 L1 IIH drops;  0 L2 IIH drops; 1 P2P IIH drops; 0 L1 LSP drops; 0 L2 LSP drops; 0 FS LSP drops; 0 L1 CSNP drops; 0 L2 CSNP drops; 0 L1 PSNP drops; 0 L2 PSNP drops.
2023/03/30 23:54:59.848 ISIS: [VAS9N-1JNNR] PDU drop detected of type: P2P IIH. 2 Total Drops; 0 L1 IIH drops;  0 L2 IIH drops; 2 P2P IIH drops; 0 L1 LSP drops; 0 L2 LSP drops; 0 FS LSP drops; 0 L1 CSNP drops; 0 L2 CSNP drops; 0 L1 PSNP drops; 0 L2 PSNP drops.

Code changes:
Add a new PDU counter function that increments the drop counter and runs the logging functionality if log-pdu-drops is configured.

Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
 2023-04-04 09:23:21 -07:00
Isabella de Leon
9ace83b952 isisd: Add log-pdu-drops CLI/YANG support 
New config functionality:

r1# conf
r1(config)# router isis 1
r1(config-router)# log-
  log-adjacency-changes  Log changes in adjacency state
  log-pdu-drops          Log any dropped PDUs
r1(config-router)# log-pdu-drops
r1(config-router)# end

Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
 2023-04-04 09:23:16 -07:00
Russ White
4d0f3e819d
Merge pull request #13160 from chiragshah6/fdev2 
ospfd:display correct DR-BDR router-id in nbr cmd
 2023-04-04 10:02:48 -04:00
Russ White
204e450a72
Merge pull request #13192 from anlancs/fix/ripd-wrong-routemap 
ripd: Fix malformed route-map
 2023-04-04 09:50:02 -04:00
Russ White
0ed503f4c1
Merge pull request #13199 from pguibert6WIND/isis_ipv4_linklocal 
isisd: consider link local ipv4 addresses as valid
 2023-04-04 09:48:11 -04:00
Jafar Al-Gharaibeh
3b28a5ef6b
Merge pull request #13131 from LabNConsulting/chopps/no-startup-file 
mgmtd: remove startup config feature for now
 2023-04-04 08:42:04 -05:00
Russ White
4af5e39b2c
Merge pull request #12969 from opensourcerouting/ospfd-nssa 
ospfd: implement NSSA default routes & ranges
 2023-04-04 09:38:55 -04:00
Russ White
c0656e9040
Merge pull request #12837 from donaldsharp/unlikely_routemap 
Unlikely routemap
 2023-04-04 08:20:25 -04:00
Christian Hopps
e8f7a22f76 tests: lower logging level on some infra logs 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-04-04 11:41:51 +00:00
Donatas Abraitis
381c6d1e5e docker: Install missing dependencies for Alpine build 
protobuf-c-compiler
protobuf-c-dev

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2023-04-04 11:18:30 +03:00
Donatas Abraitis
6fc9bfb11d
Merge pull request #13198 from mxyns/bmp-fix-peerup-port 
bgpd: bmp fix peer-up ports byte order
 2023-04-04 10:49:09 +03:00
Donatas Abraitis
d8492cf31a
Merge pull request #13181 from taspelund/route_origin_extcom_parse_fix 
bgpd: fix ecommunity parsing for AS4
 2023-04-04 10:24:44 +03:00