proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-05 19:55:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
12,511 Commits 4 Branches 191 Tags 125 MiB
093033e7cc
Commit Graph

1200 Commits

Author SHA1 Message Date
David Lamparter
9e32cce03f
Merge pull request #2876 from donaldsharp/lsa_new_and_data 
ospfd: Add ospf_lsa_new_and_data function and abstract away
 2018-08-21 21:22:45 +02:00
Donald Sharp
19c0412aad ospfd: Remove unused function 
The ospf_external_route_lookup function was not
being used so let's just remove it.

Unfortunately the removal was not quite so simple as
that ospf_asbr.h was being used to generate a reference
for the `struct ospf_route` data structure, so we
need to fix up the compile by fixing up header
inclusions so that ospf_route.h is actually included

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-08-21 08:40:51 -04:00
Donald Sharp
5b3d4186de ospfd: Add ospf_lsa_new_and_data function and abstract away 
In all but one instance we were following this pattern
with ospf_lsa_new:

ospf_lsa_new()
ospf_lsa_data_new()

so let's create a ospf_lsa_new_and_data to abstract
this bit of fun and cleanup all the places where
it assumes these function calls can fail.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-08-20 20:41:37 -04:00
Russ White
4b0d7894cb
Merge pull request #2846 from donaldsharp/backet_data 
Backet data
 2018-08-16 11:32:41 -04:00
Donald Sharp
c4dddf32d3 ospfd: trust backet->data 
The backet->data cannot be NULL, no need to check for it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-08-15 17:53:09 -04:00
David Lamparter
6bb30c2cba *: use frr_elevate_privs() (2/2: manual) 
Signed-off-by: David Lamparter <equinox@diac24.net>
 2018-08-14 20:02:05 +00:00
Quentin Young
85cd2f9f9a *: rename ferr_ref -> log_ref 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-08-14 20:02:05 +00:00
Quentin Young
af4c27286d *: rename zlog_fer -> flog_err 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-08-14 20:02:05 +00:00
Quentin Young
5e1e0166cb *: correct typos in error reference cards 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-08-14 20:02:05 +00:00
Quentin Young
5ad4c39ce4 *: stop double initialization of ferr 
* Stop double init of ferr
* Fixup bugs in zebra ferr
* Add missing init in ospfd

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-08-14 20:02:05 +00:00
Quentin Young
247dcce2b5 *: fix source file headers & includes for errcodes 
* Use the correct license header
* Stop headers from including themselves
* Use uniform relative include conventions
* Ensure that sources include what they use
* Turn off clang-format around struct array blocks

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-08-14 20:02:05 +00:00
Chirag Shah
313d7993a3 ospfd: zlog_ferr facility 
Ticket:CM-21333

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-08-14 20:02:05 +00:00
Donald Sharp
d6853655b5
Merge branch 'master' into bfd-final 2018-08-14 08:16:10 -04:00
Donald Sharp
0ce1ca805d *: ALLOC calls cannot fail 
There is no need to check for failure of a ALLOC call
as that any failure to do so will result in a assert
happening.  So we can safely remove all of this code.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-08-11 17:14:58 +02:00
Rafael Zalamena
64dc4b2d7a bgpd/ospf(6)d/pimd: hide BFD commands with timers 
Don't show BFD commands with timers since it might confuse users
("show running-config" won't display timers in client daemons anymore),
but keep accepting this command from previous configurations.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2018-08-08 18:25:08 -03:00
Rafael Zalamena
a0841732ab bgpd/ospf(6)d/pimd: don't show BFD timers 
When BFD timers are configured, don't show it anymore in the daemon
side. This will help us migrate the timers command from daemons to
`bfdd`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2018-08-08 18:25:04 -03:00
Russ White
8669b45833
Merge pull request #2778 from donaldsharp/pim_leaks_and_invalids 
Pim leaks and invalids
 2018-08-04 11:30:15 -04:00
F. Aragon
84542f3903
ospfd: dead code (Coverity 1472227) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-08-03 15:51:05 +02:00
Donald Sharp
8619629ada lib, bgpd, ospf6d, ospfd, pimd: Allow finish to cleanup a bit more 
When calling route_map_finish, every place that we do we must
first set the deletion event to NULL, or we will create an infinite
loop, if we are using the delayed route-map application code.
As such we might as well just make the route_map_finish code
do this work, as that there is really no viable alternative here
and route_map_finish should only be called on shutdown.

This fixes an infinite loop in zebra on shutdown when there
are route-maps.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-08-03 08:22:45 -04:00
Mark Stapp
123214efb8 libs, daemons: use const in route-map apply 
Use 'const prefix *' in route-map apply apis; led to some
corresponding changes in several daemons.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2018-07-23 10:34:35 -04:00
Donald Sharp
ec50871f91 ospfd: Remove deprecated code 
This code has been deprecated for over a year, let's remove it now.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-07-09 12:37:54 -04:00
F. Aragon
2ffc213bf8
ospfd pimd: null check (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-06 00:49:24 +02:00
Quentin Young
4adc8f6852
Merge pull request #2620 from pacovn/PVS-Studio_null_check_2 
bgpd lib ospfd pimd ripngd: null chk (PVS-Studio)
 2018-07-03 17:38:09 -04:00
Lou Berger
b99af60a40
Merge pull request #2599 from pacovn/PVS-Studio_Array_overrun 
ospfd zebra: array overrun fixes (PVS-Studio)
 2018-07-03 11:37:34 -04:00
F. Aragon
b575a12c87
bgpd lib ospfd pimd ripngd: null chk (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-03 15:39:50 +02:00
F. Aragon
e1fa928d22
ospfd zebra: array overrun fixes (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-03 11:34:40 +02:00
F. Aragon
0651460e00
eigrpd nhrpd ospfd pimd: fomat fixes (PVS-Studio) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-07-02 17:50:21 +02:00
paco
4adf00f765
ospfd: null check (Coverity 23110) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-27 14:41:50 +02:00
Quentin Young
81ef2361a3
Merge pull request #2559 from pacovn/Coverity_1302503_Logically_dead_code 
lib ospfd: dead code (Coverity 1302503 1302502)
 2018-06-26 16:48:54 -04:00
paco
39050c7e0d
lib ospfd: dead code (Coverity 1302503 1302502) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 21:39:56 +02:00
Quentin Young
045a178c13
Merge pull request #2560 from pacovn/Coverity_1302500_Constant_variable_guards_dead_code 
ospfd: dead code (Coverity 1302500)
 2018-06-26 15:05:53 -04:00
paco
9df48e81ee
ospfd: dead code (Coverity 1302500) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 20:33:47 +02:00
Russ White
884cc57a96
Merge pull request #2547 from pacovn/Coverity_1458168_Dereference_null_return_value 
eigrpd ospfd: null check (Coverity 1458168 1455335)
 2018-06-26 11:14:07 -04:00
Jafar Al-Gharaibeh
6bb6f26c4e
Merge pull request #2550 from pacovn/Coverity_1399284_Dereference_null_return_value 
ospfd: null check (Coverity 1399284)
 2018-06-25 12:40:02 -04:00
Jafar Al-Gharaibeh
433b146e25
Merge pull request #2543 from pacovn/Coverity_1399304_Out-of-bounds_access 
ospfd: out-of-bounds access (Coverity 1399304 1399286)
 2018-06-25 12:38:44 -04:00
paco
162dbe419d
ospfd: null check (Coverity 1399284) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 17:18:17 +02:00
paco
13f0e43443
ospfd: OoB access (Coverity 1399304 1399286) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 17:07:31 +02:00
paco
a2d7fdfeb0
eigrpd ospfd: null chk (Coverity 1458168 1455335) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 16:37:04 +02:00
paco
c23bc38a9f
ospfd: OoB access (Coverity 1221445 1221448) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 11:22:20 +02:00
Quentin Young
0a8990d5f8
Merge pull request #2501 from pacovn/infer_unused1 
bgpd isisd ldpd lib ospfd pimd: redundancy (infer, grouped)
 2018-06-21 15:12:33 -04:00
Donald Sharp
eab268594a
Merge pull request #2504 from pacovn/Coverity_23110_Dereference_after_null_check 
ospfd: null check (Coverity 23110)
 2018-06-21 07:30:21 -04:00
paco
a2b6e694b1
bgpd isisd ldpd lib ospfd pimd: redundancy (infer) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 22:25:28 +02:00
paco
ed35fc0593
ospfd: null check (Coverity 23110) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 18:35:20 +02:00
Russ White
96be948bcd
Merge pull request #2495 from pacovn/fixme_all_digit 
bgpd, lib, ospfd, zebra: all_digit moved to frrstr
 2018-06-20 07:38:19 -04:00
Russ White
9dbaf129b2
Merge pull request #2446 from pacovn/Coverity_1452454_1452455_1452456_Out-of-bounds_access 
ospfd: OoB access (Cov 1452454 1452455 1452456)
 2018-06-20 07:14:49 -04:00
paco
5d5ba0185d
bgpd, lib, ospfd, zebra: all_digit moved to frrstr 
This solves a pending FIXME

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 17:59:53 +02:00
paco
5f18adf01b
eigrpd, isisd, lib, ospfd: no effect (cppcheck) 
Assignment of function parameter has no effect outside the function.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 10:19:05 +02:00
Donald Sharp
6f32955ec3
Merge pull request #2486 from pacovn/cppcheck_fmt_validation 
babeld, lib, ospfd, tests: fmt fixes (cppcheck)
 2018-06-18 15:23:49 -04:00
Donald Sharp
b49bc6b010
Merge pull request #2487 from pacovn/cppcheck_redundant_memset 
ospfd, pimd: redundant memset (cppcheck)
 2018-06-18 15:15:46 -04:00
paco
d11c6941dc
babeld, eigrpd, ospfd: unsigned negative check 
After Cppcheck 1.72 feedback

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 19:07:24 +02:00