Commit Graph

22412 Commits

Author SHA1 Message Date
Mark Stapp
08b17099f2
Merge pull request #7684 from donaldsharp/metric_doc
doc: Add some notes about RR semantics and the Linux Kernel
2020-12-08 12:16:43 -05:00
kuldeepkash
3732ea226a tests: Enhanced auto-rd verification as per changes done in #7652
1. As per recent changes done in PR #7652, we have modified the auto-rd verification logic
2. Dev PR link: https://github.com/FRRouting/frr/pull/7652

Signed-off-by: kuldeepkash <kashyapk@vmware.com>
2020-12-08 15:53:20 +00:00
Mark Stapp
e5773617af nhrpd: fix SA warning in nhrp_interface
Clear SA warning from recent nhrp cache code changes.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-12-08 09:10:10 -05:00
Donald Sharp
9a06c15792 doc: Update sharpd and bgpd documentation
Update these two daemons to include the new
ability for both bgp and sharpd to send extra informational
data to zebra.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:07:21 -05:00
Donald Sharp
e46723a50e bgpd, zebra: Add ability for bgp to send AS-Path information to zebra
Add a bit of code to allow bgp to send the AS-Path associated with
the route being installed to zebra so it can be displayed and
used as part of the `show ip route A` command in zebra.

eva# show ip route 20.0.0.0/11
Routing entry for 20.0.0.0/11
  Known via "bgp", distance 20, metric 0, best
  Last update 00:00:00 ago
  * 192.168.161.1, via enp39s0, weight 1
    AS-Path: 60000 64539 15096 6939 8075

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:07:21 -05:00
Donald Sharp
cfa2a35d8d sharpd, zebra: Pass and display opaque data as PoC
Pass data from sharpd to zebra as opaque data and display
it as part of the detailed route data.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:06:09 -05:00
Donald Sharp
80a6ee90c3 zebra: Setup structure for opaque data to be displayed
Setup the output mechanism for opaque data to be displayed
to the end operator.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:06:08 -05:00
Donald Sharp
a29a60016e zebra: Gather opaque data into the route entry for storage
Just gather the opaque data into the route entry.  Later
commits will display this data for end users as well as
to send it down.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:06:08 -05:00
Donald Sharp
71c4870b2c lib: Add encode/decode of opaque data
Add a bit of code that allows for opaque data to be
sent from an upper level protocol to zebra.  This is just
pass through data that will be used as part of displaying
useful data about a route in a `show ip route` command
in future commits.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:06:08 -05:00
Donald Sharp
aab4eca1c0 lib, zebra: Fix overlapping message types
We had duplicate message id's.  Shit's broke yo.

Fix.  I have no idea how this properly worked.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:06:08 -05:00
Donald Sharp
b64e173374
Merge pull request #7683 from volta-networks/feat_zapi_client_close
zebra: Adding zapi client close notification
2020-12-08 09:05:00 -05:00
Donald Sharp
ba5e7ae2e0 doc: Add some notes about RR semantics and the Linux Kernel
Add doc about RR semantics for Linux Kernel and why it works
the way it does.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-08 09:02:02 -05:00
Karen Schoener
581e797e02 zebra: Adding zapi client close notification
When zebra detects a client close, send a zapi client close
notification.

Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-12-07 18:22:36 -05:00
Russ White
6a684109ae
Merge pull request #7681 from chiragshah6/mdev
bgpd: fix distance for aggregate route
2020-12-07 17:19:09 -05:00
Russ White
bd32345be3
Merge pull request #7582 from AnuradhaKaruppiah/frr-reload-cleanup
frr reload fixes for mac and ip normalization
2020-12-07 16:19:04 -05:00
Russ White
c0f5b038b6
Merge pull request #7501 from pguibert6WIND/nhrp_map_fix
nhrpd: cache config may disappear if iface not present at startup
2020-12-07 16:17:39 -05:00
Chirag Shah
801bb996a4 bgpd: fix distance for aggregate route
bgp aggregate address installs route with self peer which
can have peer->su of unspecifed type.
bgp_distance_apply bailed out as it fails to parse
sockunion2hostprefix for af type unspec.

config:
 address-family ipv4 unicast
  aggregate-address 50.1.0.0/16 summary-only

Testing Done:

Before:
B>* 50.1.0.0/16 [20/0] unreachable (blackhole), weight 1, 00:00:02

After:
B>* 50.1.0.0/16 [200/0] unreachable (blackhole), weight 1, 00:01:28

Signed-off-by: Chirag Shah <chirag@nvidia.com>
2020-12-07 08:31:04 -08:00
Rafael Zalamena
866f48f2df lib: silently ignore duplicated values
Keep the previous CLI behavior of silently ignoring access lists which
contain the same value.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-07 12:20:22 -03:00
Rafael Zalamena
54d153f786 lib: disallow prefix list duplicated values
Don't allow users to create multiple entries in the same list with the
same value to keep the behavior previously to northbound migration.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-07 12:08:44 -03:00
Rafael Zalamena
f1ca1dde81
Merge pull request #7671 from idryzhov/bfd-fix-session-lookup
bfd: fix session lookup
2020-12-07 10:09:34 -03:00
Donatas Abraitis
e8678e2c51
Merge pull request #7679 from donaldsharp/topo_fixes
tests: Close some open handles
2020-12-07 11:14:09 +02:00
Donald Sharp
46a0656f7a tests: Close some open handles
I accidently installed something that is telling me about
unlosed handles in the tests.  Let's clean them up.

<and yes I have no idea wtf I did>

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-05 20:05:52 -05:00
Rafael Zalamena
208dc372cd lib: silently ignore duplicated values
Keep the previous CLI behavior of silently ignoring access lists which
contain the same value.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-04 18:12:58 -03:00
Rafael Zalamena
f414129b0c lib: disallow access list duplicated values
Don't allow users to create multiple rules in the same list with the
same value to keep the behavior previously to northbound migration.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-04 18:11:45 -03:00
Mark Stapp
f017e7312e
Merge pull request #7675 from donaldsharp/bgp_nh
bgpd: Let's actually track if the nh was updated
2020-12-04 15:36:27 -05:00
Donald Sharp
f1df19a841
Merge pull request #7669 from ranjanyash54/2370
ospf6d: Router-ID filter is not filtering the show command "do show i…
2020-12-04 10:39:53 -05:00
Donald Sharp
bc23c57d7b
Merge pull request #7673 from idryzhov/isisd-sa
isisd: fix SA warning
2020-12-04 10:39:14 -05:00
Mark Stapp
0114e2edc9
Merge pull request #7667 from donaldsharp/vtysh_more_useful_data
Vtysh more useful data
2020-12-04 08:14:23 -05:00
Donald Sharp
06f16b2c25 bgpd: Let's actually track if the nh was updated
In bgp_zebra_announce when iterating over multipath
we were checking to ensure that the nexthop was updated
but never initially clearing the nh_updated variable.
Thus leading to a situation where we could crash.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-04 08:01:31 -05:00
Yash Ranjan
786b76d03a ospf6d: Router-ID filter is not filtering the show command "do show ipv6 ospf6 neighbour A.B.C.D"
Compare the neighbour id string from the arguments to the router_id of
the neighbor. If equal then call the show function.

Signed-off-by: Yash Ranjan <ranjany@vmware.com>
2020-12-04 04:15:30 -08:00
Igor Ryzhov
1d99019d84 isisd: fix SA warning
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-12-04 15:11:20 +03:00
Igor Ryzhov
0a731a72ee bfd: fix session lookup
local-address is optional for both IPv4 and IPv6.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-12-04 14:38:30 +03:00
Donatas Abraitis
057edd2e84
Merge pull request #7663 from donaldsharp/vtysh_history_display
doc, vtysh: Add a `show history` command
2020-12-04 10:25:18 +02:00
Donald Sharp
1400069124 vtysh: Have help dump the how FRR was built
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-03 22:23:57 -05:00
Donald Sharp
dce33234c7 vtysh: Display version w/ vtysh --help
Add a bit of useful data to know what version of FRR we
are playing with in this vtysh instance.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-03 22:21:43 -05:00
Donald Sharp
d3e79428d7
Merge pull request #7618 from ckishimo/nssa_role
ospfd: fix cosmetic show ip ospf when NSSA
2020-12-03 16:24:21 -05:00
Donald Sharp
bd8ee808f8
Merge pull request #7661 from volta-networks/fix_ldpsync_hello_timeout
isisd, ospfd: increase timeout to fix intermittent LDP Sync test failure
2020-12-03 16:14:17 -05:00
Mark Stapp
e0ea4d0349
Merge pull request #7656 from donaldsharp/bgp_convergence
tests: Wait for convergence first
2020-12-03 14:17:09 -05:00
Donald Sharp
a65f4b5dc0 doc, vtysh: Add a show history command
Dump the cli history to the user in vtysh when a `show history`
command is entered.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-12-03 12:36:29 -05:00
Patrick Ruddy
dd662ca570
Merge pull request #7399 from AnuradhaKaruppiah/mh-mac-ecmp-fixes
evpn-mh: miscellaneous fixes in MAC-sync and MAC-ECMP handling
2020-12-03 16:27:49 +00:00
Karen Schoener
32cfb544e9 isisd, ospfd: increase timeout to fix intermittent LDP Sync test failure
Currently, IGPs are coded to receive a 'hello' message from LDP every second.
Intermittently, LDP Sync topotests are failing because the IGPs fail to
receive this 'hello' message every second.
When the LDP Sync topotests fail, LDP logs show that LDP is processing
zapi messages for 1-2 seconds.

This is a shortterm fix, in order to prevent CI pipeline failures.
The longterm fix is in progress.

Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-12-03 11:23:59 -05:00
Donald Sharp
d96610aa2d
Merge pull request #7660 from rampxxxx/master
doc: add building steps for openSUSE
2020-12-03 08:29:02 -05:00
Javier Garcia
f5b17d200f doc: add building steps for openSUSE
Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
2020-12-03 11:59:01 +01:00
Rafael Zalamena
f584de526d fpm: reset/walk data structures on connection
Don't attempt to walk data structures while not connected so we can
save some CPU usage when FPM server is offline.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-03 07:30:23 -03:00
Rafael Zalamena
1f9193c1f0 fpm: simplify reset logic
Instead of checking for next group reset, always do it and skip sending
if next hop group support is disabled.

Also remove unused `*_complete` variables.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-03 07:30:23 -03:00
Rafael Zalamena
a3adec468e zebra,fpm: fix configuration display
Use `pI4` and `pI6` to format addresses and fix a bug when displaying
IPv6 addresses.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-03 07:30:23 -03:00
Rafael Zalamena
2a437850fd tools: make frr-reload handle fpm commands
Instruct `frr-reload.py` to not use `fpm` commands as configuration
node.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-12-03 07:30:23 -03:00
Donatas Abraitis
3cc92134a3
Merge pull request #7349 from opensourcerouting/bgp-delayopen
bgpd: RFC 4271 optional session attribute DelayOpenTimer
2020-12-03 08:26:44 +02:00
Donatas Abraitis
c49042b407
Merge pull request #7638 from donaldsharp/reduce_warn
zebra: Reduce warn -> debug
2020-12-03 08:17:59 +02:00
Donald Sharp
0fb4ab0388
Merge pull request #6950 from opensourcerouting/bfd-distributed-v3
bfdd: distributed BFD
2020-12-02 20:50:47 -05:00