Commit Graph

7663 Commits

Author SHA1 Message Date
Martin Winter
01aff72e26 redhat: On CentOS/RedHat 6, use python27-devel from iuscommunity.org
FRR requires now Python 2.7 development libraries, but CentOS 6
does not provide this (not in main and not in EPEL library)
This is only a build limitation.

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-06-27 19:49:38 -07:00
Martin Winter
6f59986bd4 redhat: python-devel is now a build requirement for main package
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-06-27 18:10:29 -07:00
Martin Winter
4448b4daec debian: python3-dev is now a build requirement for main package
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-06-27 18:09:38 -07:00
Martin Winter
8400033687 doc: Update to reflect Python Development Library dependency for all builds
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-06-27 18:08:55 -07:00
David Lamparter
4d85f868a5 lib: fix CLI parser memleak
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:27 +02:00
David Lamparter
f787d7a0b3 bgpd: (demo) apply some DEFPY()
(This was intended as further demonstration of the DEFPY code, but it
might as well go into the tree.)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
6cdff32196 lib: use DEFPY() for plist.c
Shorten lib/plist.c by combining the various command variants...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
ae56903ca7 doc: CLI: document DEFPY() usage
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
169e541c28 tests: cli: unit test DEFPY() + clidef.py
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
5578a14d94 python: clidef.py
Adds "DEFPY()" which invokes an additional layer of preprocessing, so
that we get pre-parsed and named function arguments for the CLI.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:26 +02:00
David Lamparter
29ad6f6882 lib: clippy the assistant
Wraps the command parsing code for Python, so we can use it to do fancy
preprocessing and replace extract.pl.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 19:29:23 +02:00
David Lamparter
92e5026146 build: fix some cross-compilation issues
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 15:46:36 +02:00
David Lamparter
645bb0b10e Merge branch 'stable/3.0'
Dropped:
	redhat/README.rpm_build.md
	redhat/daemons
	redhat/frr.init
	redhat/frr.logrotate
	redhat/frr.spec.in

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:37:58 +02:00
David Lamparter
98f65fda88 Merge pull request #681 (ASAN warnings)
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:16:24 +02:00
David Lamparter
fb82c3dbb2 Merge pull request #687 (nexthop refactoring)
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:22:29 +02:00
David Lamparter
e885ed85bb Merge pull request #624 "Babel"
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:11:32 +02:00
David Lamparter
e763afa507 babeld/eigrpd: flip VTY ports & fix rpm
babeld was 2609 previously, and this was still marked in SERVICES.
Let's flip it back before we have a release out with it.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 14:36:55 +02:00
David Lamparter
5da670a08b Merge pull request #703 from donaldsharp/nl_pid
zebra: When calling netlink, set the nl_pid as appropriate
2017-06-13 10:08:43 +02:00
David Lamparter
063221b5ad Merge pull request #700 "Coverity high"
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 10:05:51 +02:00
David Lamparter
ea00fb03f0 Merge pull request #678
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 10:03:01 +02:00
David Lamparter
3565d9ac83 babeld: install directly connected IPv4 as such
babeld would install "1.2.3.4 on eth0" as "1.2.3.4 via 1.2.3.4 on eth0".
Remove the superfluous nexthop and send to zebra as directly-connected
route.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 09:45:16 +02:00
David Lamparter
97bd5c48de Merge remote-tracking branch 'frr/master' into pull-624 2017-06-13 09:18:14 +02:00
Donald Sharp
a55ba23ff7 zebra: When calling netlink, set the nl_pid as appropriate
This will allow us to further know that we originated the message.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-12 13:38:51 -04:00
Donald Sharp
d722f26e09 zebra: Fix memory leak
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:39:41 -04:00
Donald Sharp
43cb4d1106 zebra: Fix uninitialized memory access with src_p
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:36:32 -04:00
Donald Sharp
4dfa484627 eigrpd: Correctly size the dump data
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:31:49 -04:00
Donald Sharp
73d11e2ec1 eigrpd: Use correct memory operation
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:18:54 -04:00
Donald Sharp
d52ecaa1de eigrpd: Fix leak of ep
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:13:51 -04:00
Donald Sharp
60805e322e eigrpd: Cleanup leaked dest_addr
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:09:29 -04:00
Donald Sharp
4af0ab6d7d eigrpd: Fix use after free
Signed-off-by: Donald Sharp <sharpd@Cumulusnetworks.com>
2017-06-10 15:53:27 -04:00
Donald Sharp
6201488ab3 zebra: Fix possible buffer overrun
Use the correct size of the string.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 15:42:13 -04:00
Donald Sharp
29c60afb6b bgpd: Free allocated stream in error code
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 15:37:02 -04:00
Quentin Young
47332bd02b bgpd: fix memleak with 'show ip bgp vrf ...'
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-09 20:18:56 +00:00
Russ White
ad2e2470f6 Merge pull request #679 from dslicenc/cm16513
bgpd: add "set label-index" route-map option
2017-06-09 14:01:36 -04:00
Russ White
991da9b149 Merge pull request #694 from qlyoung/event-loop
*: remove THREAD_BACKGROUND
2017-06-09 13:54:43 -04:00
Quentin Young
5fe70a7176 isisd: fix heap uaf, round 2
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-09 14:53:11 +00:00
Jafar Al-Gharaibeh
ce7fce36bd Merge pull request #692 from donaldsharp/meta_queue_fix
zebra: Fix the metaq to be aware of all routing protocols we could see
2017-06-08 10:41:57 -05:00
Renato Westphal
50b7b58488 Merge pull request #693 from donaldsharp/more_newlines_missing
bgpd: Fix missing newline
2017-06-08 12:33:45 -03:00
Jafar Al-Gharaibeh
b61246cacf Merge pull request #697 from donaldsharp/rt_proto_fixes
tools, zebra: Fix netlink notification of who owns the routes
2017-06-08 10:28:35 -05:00
Jafar Al-Gharaibeh
e676bf62a8 Merge pull request #696 from donaldsharp/disable_rtadv
zebra: Fix --disable-rtadv to actually compile
2017-06-08 09:48:00 -05:00
Donald Sharp
cea34723da zebra: In which RTPROT_BABEL is hard
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 09:33:54 -04:00
Donald Sharp
fb533f22b5 zebra: For older distributions RTPROT_BABEL might not be defined
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 09:16:28 -04:00
Donald Sharp
40078ccb05 tools, zebra: Allow zebra to insert babel routes as babel
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 08:56:36 -04:00
Donald Sharp
1f047d8d2c tools, zebra: Fix netlink notification of who owns the routes
For NHRP, EIGRP and LDP( This is for consistency as opposed to correctness )
assign some new values to routes to be installed into the kernel
so we can know who owns them later.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 08:51:25 -04:00
Alex Couloumbis
9c3bf1cee7 zebra: Fix --disable-rtadv to actually compile
Signed-off-by: Alex Couloumbis <alex@ozo.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 07:57:25 -04:00
Quentin Young
a587d00bac *: remove THREAD_BACKGROUND
it's just an alias for a millisecond timer used in exactly nine places
and serves only to complicate

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-08 01:53:50 +00:00
Donald Sharp
f0725ca87c bgpd: Fix missing newline
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 18:57:46 -04:00
Donald Sharp
8dab78d7d4 zebra: Add babel routes to the proper meta-Q for processing
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 15:57:25 -04:00
Donald Sharp
1152f48669 lib: Add some breadcrumbs for new route types
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 15:47:35 -04:00
Donald Sharp
43cf4ba452 zebra: Fix the metaq to be aware of all routing protocols we could see
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 15:43:23 -04:00