Merge pull request #6913 from ton31337/feature/dump_attributes_for_debugging_if_malformed

bgpd: Dump attributes before returning from bgp_attr_malformed()
This commit is contained in:
Donald Sharp 2020-08-13 18:35:27 -04:00 committed by GitHub
commit ff35d21a1c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1150,6 +1150,7 @@ bgp_attr_malformed(struct bgp_attr_parser_args *args, uint8_t subcode,
bgp_size_t length)
{
struct peer *const peer = args->peer;
struct attr *const attr = args->attr;
const uint8_t flags = args->flags;
/* startp and length must be special-cased, as whether or not to
* send the attribute data with the NOTIFY depends on the error,
@ -1157,6 +1158,14 @@ bgp_attr_malformed(struct bgp_attr_parser_args *args, uint8_t subcode,
*/
uint8_t *notify_datap = (length > 0 ? args->startp : NULL);
if (bgp_debug_update(peer, NULL, NULL, 1)) {
char attr_str[BUFSIZ] = {0};
bgp_dump_attr(attr, attr_str, BUFSIZ);
zlog_debug("%s: attributes: %s", __func__, attr_str);
}
/* Only relax error handling for eBGP peers */
if (peer->sort != BGP_PEER_EBGP) {
bgp_notify_send_with_data(peer, BGP_NOTIFY_UPDATE_ERR, subcode,