From fd9a1d5afe1c8bcfacb808249e3a1658fc944a0a Mon Sep 17 00:00:00 2001 From: David Lamparter Date: Mon, 29 Jul 2019 14:04:06 +0200 Subject: [PATCH] Revert "ospfd: default route got flushed after lsa refresh timer." This reverts commit a6b4e1fdedb290e8d86f73b0d7f842f7042b26af. This fix is wrong too. The zclient->redist & ->mi_redist arrays are accessed past their size for any external route that is not 0.0.0.0/0. Also, it is incorrect to check default_information for DEFAULT_ROUTE since that's "originate always". Signed-off-by: David Lamparter --- ospfd/ospf_flood.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ospfd/ospf_flood.c b/ospfd/ospf_flood.c index 6d1e44996e..168dcee449 100644 --- a/ospfd/ospf_flood.c +++ b/ospfd/ospf_flood.c @@ -91,7 +91,7 @@ struct external_info *ospf_external_info_check(struct ospf *ospf, p.prefix = lsa->data->id; p.prefixlen = ip_masklen(al->mask); - for (type = 0; type <= ZEBRA_ROUTE_MAX; type++) { + for (type = 0; type < ZEBRA_ROUTE_MAX; type++) { int redist_on = 0; redist_on =