proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-09 11:18:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: backpressure - fix ret value evpn_route_select_install

Browse Source 
The return value of evpn_route_select_install is ignored in all cases
except during vni route table install/uninstall and based on the
returned value, an error is logged. Fixing this.

Ticket :#3992392

Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
This commit is contained in:
Rajasekar Raja 2024-07-16 23:34:15 -07:00 committed by Donatas Abraitis
parent c717390e8e
commit f9a9d424f9
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bgpd/bgp_evpn.c
View File

@ -1487,8 +1487,9 @@ int evpn_route_select_install(struct bgp *bgp, struct bgpevpn *vpn,
&& !bgp_addpath_is_addpath_used(&bgp->tx_addpath, afi, safi)) { && !bgp_addpath_is_addpath_used(&bgp->tx_addpath, afi, safi)) {
if (bgp_zebra_has_route_changed(old_select)) { if (bgp_zebra_has_route_changed(old_select)) {
if (CHECK_FLAG(bgp->flags, BGP_FLAG_DELETE_IN_PROGRESS)) if (CHECK_FLAG(bgp->flags, BGP_FLAG_DELETE_IN_PROGRESS))
evpn_zebra_install(bgp, vpn, ret = evpn_zebra_install(bgp, vpn,
(const struct prefix_evpn *) (const struct prefix_evpn
*)
bgp_dest_get_prefix( bgp_dest_get_prefix(
dest), dest),
old_select); old_select);
@ -1529,9 +1530,10 @@ int evpn_route_select_install(struct bgp *bgp, struct bgpevpn *vpn,
&& (new_select->sub_type == BGP_ROUTE_IMPORTED || && (new_select->sub_type == BGP_ROUTE_IMPORTED ||
bgp_evpn_attr_is_sync(new_select->attr))) { bgp_evpn_attr_is_sync(new_select->attr))) {
if (CHECK_FLAG(bgp->flags, BGP_FLAG_DELETE_IN_PROGRESS)) if (CHECK_FLAG(bgp->flags, BGP_FLAG_DELETE_IN_PROGRESS))
evpn_zebra_install(bgp, vpn, ret = evpn_zebra_install(bgp, vpn,
(const struct prefix_evpn *) (const struct prefix_evpn *)
bgp_dest_get_prefix(dest), bgp_dest_get_prefix(
dest),
new_select); new_select);
else else
bgp_zebra_route_install(dest, new_select, bgp, true, bgp_zebra_route_install(dest, new_select, bgp, true,
@ -1556,8 +1558,9 @@ int evpn_route_select_install(struct bgp *bgp, struct bgpevpn *vpn,
old_select->sub_type == BGP_ROUTE_IMPORTED) { old_select->sub_type == BGP_ROUTE_IMPORTED) {
if (CHECK_FLAG(bgp->flags, BGP_FLAG_DELETE_IN_PROGRESS) || if (CHECK_FLAG(bgp->flags, BGP_FLAG_DELETE_IN_PROGRESS) ||
CHECK_FLAG(bgp->flags, BGP_FLAG_VNI_DOWN)) CHECK_FLAG(bgp->flags, BGP_FLAG_VNI_DOWN))
evpn_zebra_uninstall(bgp, vpn, ret = evpn_zebra_uninstall(bgp, vpn,
(const struct prefix_evpn *) (const struct prefix_evpn
*)
bgp_dest_get_prefix( bgp_dest_get_prefix(
dest), dest),
old_select, false); old_select, false);