proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-08 11:18:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: fix "use of uninitialised value" valgrind warning

Browse Source 
When FRR is built without the --enable-config-rollbacks option,
the nb_db_transaction_save() function does nothing and the
"transaction_id" output parameter is left uninitialized. For
this reason, all northbound clients should initialize the
"transaction_id" argument before calling nb_candidate_commit() or
nb_candidate_commit_apply() (except when a NULL pointer is given,
which is the case of the confd and sysrepo plugins).

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
This commit is contained in:
Renato Westphal 2019-01-14 16:29:18 -02:00
parent ec348d4344
commit f65fb6b4b4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/northbound_cli.c
View File

@ -261,7 +261,7 @@ static int nb_cli_confirmed_commit_timeout(struct thread *thread)
static int nb_cli_commit(struct vty *vty, bool force, static int nb_cli_commit(struct vty *vty, bool force,
unsigned int confirmed_timeout, char *comment) unsigned int confirmed_timeout, char *comment)
{ {
uint32_t transaction_id; uint32_t transaction_id = 0;
int ret; int ret;
/* Check if there's a pending confirmed commit. */ /* Check if there's a pending confirmed commit. */