From f5c44adb738a16b72ea33c1bb102eefb705424a2 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Sat, 1 Jul 2023 13:30:12 -0400 Subject: [PATCH] tests: isis_tilfa_topo1 fails sometimes due to insufficient time The isis_tilfa_topo1 test is failing because insufficient time was given for isis to converge on the system under system load. Extend the time and decrease the hello-interval timers to give it more of a chance to converge. Signed-off-by: Donald Sharp --- tests/topotests/isis_tilfa_topo1/rt1/isisd.conf | 1 + .../rt1/step1/show_yang_interface_isis_adjacencies.ref | 4 ++-- tests/topotests/isis_tilfa_topo1/rt2/isisd.conf | 3 +++ .../rt2/step1/show_yang_interface_isis_adjacencies.ref | 8 ++++---- tests/topotests/isis_tilfa_topo1/rt3/isisd.conf | 3 +++ .../rt3/step1/show_yang_interface_isis_adjacencies.ref | 8 ++++---- tests/topotests/isis_tilfa_topo1/rt4/isisd.conf | 4 ++++ .../rt4/step1/show_yang_interface_isis_adjacencies.ref | 8 ++++---- tests/topotests/isis_tilfa_topo1/rt5/isisd.conf | 4 ++++ .../rt5/step1/show_yang_interface_isis_adjacencies.ref | 8 ++++---- tests/topotests/isis_tilfa_topo1/rt6/isisd.conf | 2 ++ .../rt6/step1/show_yang_interface_isis_adjacencies.ref | 4 ++-- tests/topotests/isis_tilfa_topo1/test_isis_tilfa_topo1.py | 3 ++- 13 files changed, 39 insertions(+), 21 deletions(-) diff --git a/tests/topotests/isis_tilfa_topo1/rt1/isisd.conf b/tests/topotests/isis_tilfa_topo1/rt1/isisd.conf index 955bd5caa0..620523512a 100644 --- a/tests/topotests/isis_tilfa_topo1/rt1/isisd.conf +++ b/tests/topotests/isis_tilfa_topo1/rt1/isisd.conf @@ -16,6 +16,7 @@ interface lo interface eth-sw1 ip router isis 1 ipv6 router isis 1 + isis hello-interval 1 isis hello-multiplier 3 isis priority 100 isis fast-reroute ti-lfa diff --git a/tests/topotests/isis_tilfa_topo1/rt1/step1/show_yang_interface_isis_adjacencies.ref b/tests/topotests/isis_tilfa_topo1/rt1/step1/show_yang_interface_isis_adjacencies.ref index 26f0dffa7a..d86f9ef658 100644 --- a/tests/topotests/isis_tilfa_topo1/rt1/step1/show_yang_interface_isis_adjacencies.ref +++ b/tests/topotests/isis_tilfa_topo1/rt1/step1/show_yang_interface_isis_adjacencies.ref @@ -11,14 +11,14 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0003", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 64, "state": "up" }, { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0002", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 64, "state": "up" } diff --git a/tests/topotests/isis_tilfa_topo1/rt2/isisd.conf b/tests/topotests/isis_tilfa_topo1/rt2/isisd.conf index f971c658d4..9c4b86208b 100644 --- a/tests/topotests/isis_tilfa_topo1/rt2/isisd.conf +++ b/tests/topotests/isis_tilfa_topo1/rt2/isisd.conf @@ -15,6 +15,7 @@ interface lo interface eth-sw1 ip router isis 1 ipv6 router isis 1 + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -22,6 +23,7 @@ interface eth-rt4-1 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -29,6 +31,7 @@ interface eth-rt4-2 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! diff --git a/tests/topotests/isis_tilfa_topo1/rt2/step1/show_yang_interface_isis_adjacencies.ref b/tests/topotests/isis_tilfa_topo1/rt2/step1/show_yang_interface_isis_adjacencies.ref index 1ea72a528b..69b6159d62 100644 --- a/tests/topotests/isis_tilfa_topo1/rt2/step1/show_yang_interface_isis_adjacencies.ref +++ b/tests/topotests/isis_tilfa_topo1/rt2/step1/show_yang_interface_isis_adjacencies.ref @@ -11,7 +11,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0004", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -30,7 +30,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0004", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -49,14 +49,14 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0001", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 100, "state": "up" }, { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0003", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 64, "state": "up" } diff --git a/tests/topotests/isis_tilfa_topo1/rt3/isisd.conf b/tests/topotests/isis_tilfa_topo1/rt3/isisd.conf index 64f091cfed..1883575b7b 100644 --- a/tests/topotests/isis_tilfa_topo1/rt3/isisd.conf +++ b/tests/topotests/isis_tilfa_topo1/rt3/isisd.conf @@ -15,6 +15,7 @@ interface lo interface eth-sw1 ip router isis 1 ipv6 router isis 1 + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -22,6 +23,7 @@ interface eth-rt5-1 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -29,6 +31,7 @@ interface eth-rt5-2 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! diff --git a/tests/topotests/isis_tilfa_topo1/rt3/step1/show_yang_interface_isis_adjacencies.ref b/tests/topotests/isis_tilfa_topo1/rt3/step1/show_yang_interface_isis_adjacencies.ref index d174b4a475..e75d5fe859 100644 --- a/tests/topotests/isis_tilfa_topo1/rt3/step1/show_yang_interface_isis_adjacencies.ref +++ b/tests/topotests/isis_tilfa_topo1/rt3/step1/show_yang_interface_isis_adjacencies.ref @@ -11,7 +11,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0005", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -30,7 +30,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0005", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -49,14 +49,14 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0001", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 100, "state": "up" }, { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0002", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 64, "state": "up" } diff --git a/tests/topotests/isis_tilfa_topo1/rt4/isisd.conf b/tests/topotests/isis_tilfa_topo1/rt4/isisd.conf index 9223852f79..94f80d39d5 100644 --- a/tests/topotests/isis_tilfa_topo1/rt4/isisd.conf +++ b/tests/topotests/isis_tilfa_topo1/rt4/isisd.conf @@ -16,6 +16,7 @@ interface eth-rt2-1 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -23,6 +24,7 @@ interface eth-rt2-2 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -30,6 +32,7 @@ interface eth-rt5 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -37,6 +40,7 @@ interface eth-rt6 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! diff --git a/tests/topotests/isis_tilfa_topo1/rt4/step1/show_yang_interface_isis_adjacencies.ref b/tests/topotests/isis_tilfa_topo1/rt4/step1/show_yang_interface_isis_adjacencies.ref index 2eb64b6fc9..1d2c559588 100644 --- a/tests/topotests/isis_tilfa_topo1/rt4/step1/show_yang_interface_isis_adjacencies.ref +++ b/tests/topotests/isis_tilfa_topo1/rt4/step1/show_yang_interface_isis_adjacencies.ref @@ -11,7 +11,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0002", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -30,7 +30,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0002", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -49,7 +49,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0005", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -68,7 +68,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0006", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } diff --git a/tests/topotests/isis_tilfa_topo1/rt5/isisd.conf b/tests/topotests/isis_tilfa_topo1/rt5/isisd.conf index a08534cf30..e83ae9677b 100644 --- a/tests/topotests/isis_tilfa_topo1/rt5/isisd.conf +++ b/tests/topotests/isis_tilfa_topo1/rt5/isisd.conf @@ -16,6 +16,7 @@ interface eth-rt3-1 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -23,6 +24,7 @@ interface eth-rt3-2 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -30,6 +32,7 @@ interface eth-rt4 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -37,6 +40,7 @@ interface eth-rt6 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! diff --git a/tests/topotests/isis_tilfa_topo1/rt5/step1/show_yang_interface_isis_adjacencies.ref b/tests/topotests/isis_tilfa_topo1/rt5/step1/show_yang_interface_isis_adjacencies.ref index 1ff8c2cd4e..f94b09e161 100644 --- a/tests/topotests/isis_tilfa_topo1/rt5/step1/show_yang_interface_isis_adjacencies.ref +++ b/tests/topotests/isis_tilfa_topo1/rt5/step1/show_yang_interface_isis_adjacencies.ref @@ -11,7 +11,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0003", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -30,7 +30,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0003", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -49,7 +49,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0004", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -68,7 +68,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0006", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } diff --git a/tests/topotests/isis_tilfa_topo1/rt6/isisd.conf b/tests/topotests/isis_tilfa_topo1/rt6/isisd.conf index d92f822b8d..462492e909 100644 --- a/tests/topotests/isis_tilfa_topo1/rt6/isisd.conf +++ b/tests/topotests/isis_tilfa_topo1/rt6/isisd.conf @@ -16,6 +16,7 @@ interface eth-rt4 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! @@ -23,6 +24,7 @@ interface eth-rt5 ip router isis 1 ipv6 router isis 1 isis network point-to-point + isis hello-interval 1 isis hello-multiplier 3 isis fast-reroute ti-lfa ! diff --git a/tests/topotests/isis_tilfa_topo1/rt6/step1/show_yang_interface_isis_adjacencies.ref b/tests/topotests/isis_tilfa_topo1/rt6/step1/show_yang_interface_isis_adjacencies.ref index 734832358f..9d4d47b2af 100644 --- a/tests/topotests/isis_tilfa_topo1/rt6/step1/show_yang_interface_isis_adjacencies.ref +++ b/tests/topotests/isis_tilfa_topo1/rt6/step1/show_yang_interface_isis_adjacencies.ref @@ -11,7 +11,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0004", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } @@ -30,7 +30,7 @@ { "neighbor-sys-type": "level-1", "neighbor-sysid": "0000.0000.0005", - "hold-timer": 9, + "hold-timer": 3, "neighbor-priority": 0, "state": "up" } diff --git a/tests/topotests/isis_tilfa_topo1/test_isis_tilfa_topo1.py b/tests/topotests/isis_tilfa_topo1/test_isis_tilfa_topo1.py index 1ed52ab76d..f0724b9da6 100755 --- a/tests/topotests/isis_tilfa_topo1/test_isis_tilfa_topo1.py +++ b/tests/topotests/isis_tilfa_topo1/test_isis_tilfa_topo1.py @@ -1021,7 +1021,8 @@ def test_rt6_step14(): rname, "show ipv6 route isis json", outputs[rname][11]["show_ipv6_route.ref"], - count=10, + count=20, + wait=2, ) router_compare_json_output( rname,