proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 23:53:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: backpressure - Fix to withdraw evpn type-5 routes immediately

Browse Source 
As part of backpressure changes, there is a bug where immediate withdraw
is to be sent for evpn imported type-5 prefix to clear the nh neigh and
RMAC entry.

Fixing this by sending withdraw immediately to keep it inline with the
code today

Ticket: #3905571

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
This commit is contained in:
Rajasekar Raja 2024-05-17 12:36:31 -07:00
parent e41b4a755e
commit f4ba47238e
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bgpd/bgp_route.c
View File

@ -3810,8 +3810,7 @@ static void bgp_process_main_one(struct bgp *bgp, struct bgp_dest *dest,
*/ */
if (old_select && if (old_select &&
is_route_parent_evpn(old_select)) is_route_parent_evpn(old_select))
bgp_zebra_route_install(dest, old_select, bgp, bgp_zebra_withdraw_actual(dest, old_select, bgp);
false, NULL, false);
bgp_zebra_route_install(dest, new_select, bgp, true, bgp_zebra_route_install(dest, new_select, bgp, true,
NULL, false); NULL, false);

9
bgpd/bgp_zebra.c
View File

@ -1891,11 +1891,9 @@ static void bgp_zebra_buffer_write_ready(void)
* save new pi, mark as going to be * save new pi, mark as going to be
* withdrawan, remove install flag * withdrawan, remove install flag
* *
* Withdrawal Install Special case, send withdrawal immediately * Withdrawal Install Leave dest on list, release old pi,
* Leave dest on list, release old pi,
* save new pi, mark as going to be * save new pi, mark as going to be
* installed. <see note about evpn * installed.
* in bgp_route.c in bgp_process_main_one>
* Withdrawal Withdrawal Leave dest on list, release old pi, * Withdrawal Withdrawal Leave dest on list, release old pi,
* save new pi, mark as going to be * save new pi, mark as going to be
* withdrawn. * withdrawn.
@ -1950,9 +1948,6 @@ void bgp_zebra_route_install(struct bgp_dest *dest, struct bgp_path_info *info,
dest->za_bgp_pi = info; dest->za_bgp_pi = info;
} else if (CHECK_FLAG(dest->flags, BGP_NODE_SCHEDULE_FOR_DELETE)) { } else if (CHECK_FLAG(dest->flags, BGP_NODE_SCHEDULE_FOR_DELETE)) {
assert(dest->za_bgp_pi); assert(dest->za_bgp_pi);
if (install & !is_evpn)
bgp_zebra_withdraw_actual(dest, dest->za_bgp_pi, bgp);
bgp_path_info_unlock(dest->za_bgp_pi); bgp_path_info_unlock(dest->za_bgp_pi);
bgp_path_info_lock(info); bgp_path_info_lock(info);
dest->za_bgp_pi = info; dest->za_bgp_pi = info;