tests: Test if BGP AGGREGATOR attribute is discarded if ASN comes as 0

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

tests/topotests/bgp-aggregator-zero/exabgp.env

@@ -0,0 +1,53 @@
+[exabgp.api]
+encoder = text
+highres = false
+respawn = false
+socket = ''
+
+[exabgp.bgp]
+openwait = 60
+
+[exabgp.cache]
+attributes = true
+nexthops = true
+
+[exabgp.daemon]
+daemonize = true
+pid = '/var/run/exabgp/exabgp.pid'
+user = 'exabgp'
+##daemonize = false
+
+[exabgp.log]
+all = false
+configuration = true
+daemon = true
+destination = '/var/log/exabgp.log'
+enable = true
+level = INFO
+message = false
+network = true
+packets = false
+parser = false
+processes = true
+reactor = true
+rib = false
+routes = false
+short = false
+timers = false
+
+[exabgp.pdb]
+enable = false
+
+[exabgp.profile]
+enable = false
+file = ''
+
+[exabgp.reactor]
+speed = 1.0
+
+[exabgp.tcp]
+acl = false
+bind = ''
+delay = 0
+once = false
+port = 179

tests/topotests/bgp-aggregator-zero/peer1/exabgp.cfg

@@ -0,0 +1,18 @@
+neighbor 10.0.0.1 {
+  router-id 10.0.0.2;
+  local-address 10.0.0.2;
+  local-as 65001;
+  peer-as 65534;
+
+  static {
+    route 192.168.100.101/32 {
+      aggregator (0:10.0.0.2);
+      next-hop 10.0.0.2;
+    }
+
+    route 192.168.100.102/32 {
+      aggregator (65001:10.0.0.2);
+      next-hop 10.0.0.2;
+    }
+  }
+}

tests/topotests/bgp-aggregator-zero/r1/bgpd.conf

@@ -0,0 +1,6 @@
+!
+router bgp 65534
+  no bgp ebgp-requires-policy
+  neighbor 10.0.0.2 remote-as external
+  neighbor 10.0.0.2 timers 3 10
+!

tests/topotests/bgp-aggregator-zero/r1/zebra.conf

@@ -0,0 +1,6 @@
+!
+interface r1-eth0
+ ip address 10.0.0.1/24
+!
+ip forwarding
+!

tests/topotests/bgp-aggregator-zero/test_bgp_aggregator_zero.py

@@ -0,0 +1,139 @@
+#!/usr/bin/env python
+
+#
+# Copyright (c) 2021 by
+# Donatas Abraitis <donatas.abraitis@gmail.com>
+#
+# Permission to use, copy, modify, and/or distribute this software
+# for any purpose with or without fee is hereby granted, provided
+# that the above copyright notice and this permission notice appear
+# in all copies.
+#
+# THE SOFTWARE IS PROVIDED "AS IS" AND NETDEF DISCLAIMS ALL WARRANTIES
+# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL NETDEF BE LIABLE FOR
+# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY
+# DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS,
+# WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS
+# ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE
+# OF THIS SOFTWARE.
+#
+
+"""
+Test if BGP UPDATE with AGGREGATOR AS attribute with value zero (0)
+is continued to be processed, but AGGREGATOR attribute is discarded.
+"""
+
+import os
+import sys
+import json
+import time
+import pytest
+import functools
+
+CWD = os.path.dirname(os.path.realpath(__file__))
+sys.path.append(os.path.join(CWD, "../"))
+
+# pylint: disable=C0413
+from lib import topotest
+from lib.topogen import Topogen, TopoRouter, get_topogen
+from lib.topolog import logger
+from mininet.topo import Topo
+
+
+class BgpAggregatorAsnZero(Topo):
+    def build(self, *_args, **_opts):
+        tgen = get_topogen(self)
+
+        r1 = tgen.add_router("r1")
+        peer1 = tgen.add_exabgp_peer(
+            "peer1", ip="10.0.0.2", defaultRoute="via 10.0.0.1"
+        )
+
+        switch = tgen.add_switch("s1")
+        switch.add_link(r1)
+        switch.add_link(peer1)
+
+
+def setup_module(mod):
+    tgen = Topogen(BgpAggregatorAsnZero, mod.__name__)
+    tgen.start_topology()
+
+    router = tgen.gears["r1"]
+    router.load_config(TopoRouter.RD_ZEBRA, os.path.join(CWD, "r1/zebra.conf"))
+    router.load_config(TopoRouter.RD_BGP, os.path.join(CWD, "r1/bgpd.conf"))
+    router.start()
+
+    peer = tgen.gears["peer1"]
+    peer.start(os.path.join(CWD, "peer1"), os.path.join(CWD, "exabgp.env"))
+
+
+def teardown_module(mod):
+    tgen = get_topogen()
+    tgen.stop_topology()
+
+
+def test_bgp_aggregator_zero():
+    tgen = get_topogen()
+
+    if tgen.routers_have_failure():
+        pytest.skip(tgen.errors)
+
+    def _bgp_converge():
+        output = json.loads(
+            tgen.gears["r1"].vtysh_cmd("show ip bgp neighbor 10.0.0.2 json")
+        )
+        expected = {
+            "10.0.0.2": {
+                "bgpState": "Established",
+                "addressFamilyInfo": {"ipv4Unicast": {"acceptedPrefixCounter": 2}},
+            }
+        }
+        return topotest.json_cmp(output, expected)
+
+    test_func = functools.partial(_bgp_converge)
+    success, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
+
+    assert result is None, 'Failed bgp convergence in "{}"'.format(tgen.gears["r1"])
+
+    def _bgp_has_correct_aggregator_route_with_asn_0():
+        output = json.loads(
+            tgen.gears["r1"].vtysh_cmd("show ip bgp 192.168.100.101/32 json")
+        )
+
+        if "aggregatorAs" in output["paths"][0].keys():
+            return False
+        else:
+            return True
+
+    assert (
+        _bgp_has_correct_aggregator_route_with_asn_0() is True
+    ), 'Aggregator AS attribute with ASN 0 found in "{}"'.format(tgen.gears["r1"])
+
+    def _bgp_has_correct_aggregator_route_with_good_asn():
+        output = json.loads(
+            tgen.gears["r1"].vtysh_cmd("show ip bgp 192.168.100.102/32 json")
+        )
+        expected = {"paths": [{"aggregatorAs": 65001, "aggregatorId": "10.0.0.2"}]}
+        return topotest.json_cmp(output, expected)
+
+    test_func = functools.partial(_bgp_has_correct_aggregator_route_with_good_asn)
+    success, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
+
+    assert result is None, 'Aggregator AS attribute not found in "{}"'.format(
+        tgen.gears["r1"]
+    )
+
+
+def test_memory_leak():
+    "Run the memory leak test and report results."
+    tgen = get_topogen()
+    if not tgen.is_memleak_enabled():
+        pytest.skip("Memory leak test/report is disabled")
+
+    tgen.report_memory_leaks()
+
+
+if __name__ == "__main__":
+    args = ["-s"] + sys.argv[1:]
+    sys.exit(pytest.main(args))