proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-06 06:14:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Do not process workqueue upon instance delete

Browse Source 
During instance cleanup, an earlier patch walked the workqueue in order
to process queued routes of the instance. However, since the workqueue
is not per instance, the code walks and immediately processes all routes
across all instances.

This may not be ideal in the presence of VRFs, when multiple instances
will be a fact. Revert that part of the change from earlier patch. This
needs to be revisited later for a better solution.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Updates: bb86c6017e
This commit is contained in:
vivek 2016-06-08 18:14:17 -07:00
parent b828b71f06
commit f23a7bf289
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bgpd/bgpd.c
View File

@ -2035,9 +2035,6 @@ peer_delete (struct peer *peer)
peer->domainname = NULL;
}
if (CHECK_FLAG(bgp->flags, BGP_FLAG_DELETING))
bgp_peer_clear_node_queue_drain_immediate(peer);
peer_unlock (peer); /* initial reference */
return 0;
@ -3100,15 +3097,6 @@ bgp_delete (struct bgp *bgp)
/* TODO - Other memory may need to be freed - e.g., NHT */
/*
* Free pending deleted routes. Unfortunately, it also has to process
* all the pending activity for other instances of struct bgp.
*
* This call was added to achieve clean memory allocation at exit,
* for the sake of valgrind.
*/
bgp_process_queues_drain_immediate();
/* Remove visibility via the master list - there may however still be
* routes to be processed still referencing the struct bgp.
*/