proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-07 01:40:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pimd: Remove some impossible error conditions.

Browse Source 
It is impossible that we can hit these error conditions.
Remove them from the code.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2016-08-09 14:25:12 -04:00
parent 856eb2535b
commit f0ce50d470
1 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pimd/pim_mroute.c
View File

@ -435,27 +435,14 @@ int pim_mroute_msg(int fd, const char *buf, int buf_size)
static int mroute_read_msg(int fd) static int mroute_read_msg(int fd)
{ {
const int msg_min_size = MAX(sizeof(struct ip), sizeof(struct igmpmsg)); char buf[2000];
char buf[1000];
int rd; int rd;
if (((int) sizeof(buf)) < msg_min_size) {
zlog_err("%s: fd=%d: buf size=%zu lower than msg_min=%d",
__PRETTY_FUNCTION__, fd, sizeof(buf), msg_min_size);
return -1;
}
rd = read(fd, buf, sizeof(buf)); rd = read(fd, buf, sizeof(buf));
if (rd < 0) { if (rd < 0) {
zlog_warn("%s: failure reading fd=%d: errno=%d: %s", zlog_warn("%s: failure reading fd=%d: errno=%d: %s",
__PRETTY_FUNCTION__, fd, errno, safe_strerror(errno)); __PRETTY_FUNCTION__, fd, errno, safe_strerror(errno));
return -2; return -1;
}
if (rd < msg_min_size) {
zlog_warn("%s: short message reading fd=%d: read=%d msg_min=%d",
__PRETTY_FUNCTION__, fd, rd, msg_min_size);
return -3;
} }
return pim_mroute_msg(fd, buf, rd); return pim_mroute_msg(fd, buf, rd);