proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-04-28 11:50:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pimd: replace CPP_NOTICE lines with TODO comments

Browse Source 
Replace the noisy CPP_NOTICE lines with TODO comments.

Signed-off-by: Mark Stapp <mjs@labn.net>
This commit is contained in:
Mark Stapp 2023-05-04 10:26:33 -04:00
parent abecbc3df1
commit efa2a5f8ad
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pimd/pim6_mld.c
View File

@ -344,7 +344,8 @@ static const char *const gm_states[] = {
};
/* clang-format on */
CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
/* TODO: S,G entries in EXCLUDE (i.e. prune) unsupported" */
/* tib_sg_gm_prune() below is an "un-join", it doesn't prune S,G when *,G is
* joined. Whether we actually want/need to support this is a separate
* question - it is almost never used. In fact this is exactly what RFC5790
@ -645,7 +646,7 @@ static void gm_handle_v2_pass1(struct gm_packet_state *pkt,
*/
gm_packet_sg_drop(old_grp);
gm_sg_update(grp, false);
CPP_NOTICE("need S,G PRUNE => NO_INFO transition here");
/* TODO "need S,G PRUNE => NO_INFO transition here" */
}
break;
@ -793,7 +794,8 @@ static void gm_handle_v2_pass2_excl(struct gm_packet_state *pkt, size_t offs)
gm_sg_update(sg_grp, false);
}
CPP_NOTICE("TODO: QRV/QQIC are not copied from queries to local state");
/* TODO: QRV/QQIC are not copied from queries to local state" */
/* on receiving a query, we need to update our robustness/query interval to
* match, so we correctly process group/source specific queries after last
* member leaves
@ -949,7 +951,8 @@ static void gm_handle_v1_report(struct gm_if *gm_ifp,
item = gm_packet_sg_setup(pkt, grp, true, false);
item->n_exclude = 0;
CPP_NOTICE("set v1-seen timer on grp here");
/* TODO "set v1-seen timer on grp here" */
/* } */
@ -1012,7 +1015,9 @@ static void gm_handle_v1_leave(struct gm_if *gm_ifp,
if (old_grp) {
gm_packet_sg_drop(old_grp);
gm_sg_update(grp, false);
CPP_NOTICE("need S,G PRUNE => NO_INFO transition here");
/* TODO "need S,G PRUNE => NO_INFO transition here" */
}
}