proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-09 09:22:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: call filter delete hook before freeing access list

Browse Source 
The delete_hook was being run after calling access list delete function.
This would cause ospf to dereference a NULL, in ospf_filter_update
because 'access->name' was already freed.

See also:
    https://bugzilla.vyatta.com/show_bug.cgi?id=7654
This commit is contained in:
Stephen Hemminger 2011-12-06 14:04:12 +04:00 committed by Denis Ovsienko
parent ce77002e90
commit ed269db39a
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/filter.c
View File

@ -1337,13 +1337,13 @@ DEFUN (no_access_list_all,
master = access->master; master = access->master;
/* Delete all filter from access-list. */
access_list_delete (access);
/* Run hook function. */ /* Run hook function. */
if (master->delete_hook) if (master->delete_hook)
(*master->delete_hook) (access); (*master->delete_hook) (access);
/* Delete all filter from access-list. */
access_list_delete (access);
return CMD_SUCCESS; return CMD_SUCCESS;
} }
@ -1508,13 +1508,13 @@ DEFUN (no_ipv6_access_list_all,
master = access->master; master = access->master;
/* Delete all filter from access-list. */
access_list_delete (access);
/* Run hook function. */ /* Run hook function. */
if (master->delete_hook) if (master->delete_hook)
(*master->delete_hook) (access); (*master->delete_hook) (access);
/* Delete all filter from access-list. */
access_list_delete (access);
return CMD_SUCCESS; return CMD_SUCCESS;
} }