proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 11:44:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Treat numbered community-list only if it's in a range 1-500

Browse Source 
Before this patch, if we set something like:

```
bgp extcommunity-list expanded 1234 permit admin
```

In running config we have:

```
bgp extcommunity-list 1234 seq 5 permit admin
```

That leads to incorrect rendering, even more the line can't be deleted.

With this fix we treat numbered community-list only if it's inside the range
1-500, otherwise it's a non-numbered clist.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit 4c1ee29116)
This commit is contained in:
Donatas Abraitis 2024-10-30 10:45:28 +02:00 committed by Mergify
parent 73765eda41
commit e8cf0e581b
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bgpd/bgp_clist.c
View File

@ -182,7 +182,7 @@ community_list_insert(struct community_list_handler *ch, const char *name,
} }
/* In case of name is all digit character */ /* In case of name is all digit character */
if (i == strlen(name)) { if (i == strlen(name) && number <= COMMUNITY_LIST_NUMBER_MAX) {
new->sort = COMMUNITY_LIST_NUMBER; new->sort = COMMUNITY_LIST_NUMBER;
/* Set access_list to number list. */ /* Set access_list to number list. */

4
bgpd/bgp_clist.h
View File

@ -20,6 +20,10 @@
/* Number and string based community-list name. */ /* Number and string based community-list name. */
#define COMMUNITY_LIST_STRING 0 #define COMMUNITY_LIST_STRING 0
#define COMMUNITY_LIST_NUMBER 1 #define COMMUNITY_LIST_NUMBER 1
/* The numbered community-list (including large/ext communities)
* have a range between 1-500.
*/
#define COMMUNITY_LIST_NUMBER_MAX 500
#define COMMUNITY_SEQ_NUMBER_AUTO -1 #define COMMUNITY_SEQ_NUMBER_AUTO -1