proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 13:06:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Treat as4-path (17) attribute as withdraw if malformed

Browse Source 
rfc7606 defines:

Attributes 17 (AS4_PATH), 18 (AS4_AGGREGATOR), 22 (PMSI_TUNNEL), 23 (Tunnel
   Encapsulation Attribute), 26 (AIGP), 27 (PE Distinguisher Labels),
   and 29 (BGP-LS Attribute) do have error handling consistent with
   Section 8 and thus are not further discussed herein.

Section 8 defines:

The "treat-as-withdraw" approach is generally
   preferred and the "session reset" approach is discouraged.
For any malformed attribute that is handled by the "attribute
   discard" instead of the "treat-as-withdraw" approach, it is critical
   to consider the potential impact of doing so.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2023-09-01 17:10:12 +03:00
parent 8ef655c249
commit e8cac071fb
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
bgpd/bgp_attr.c
View File

@ -1396,6 +1396,7 @@ bgp_attr_malformed(struct bgp_attr_parser_args *args, uint8_t subcode,
*/ */
case BGP_ATTR_ORIGIN: case BGP_ATTR_ORIGIN:
case BGP_ATTR_AS_PATH: case BGP_ATTR_AS_PATH:
case BGP_ATTR_AS4_PATH:
case BGP_ATTR_NEXT_HOP: case BGP_ATTR_NEXT_HOP:
case BGP_ATTR_MULTI_EXIT_DISC: case BGP_ATTR_MULTI_EXIT_DISC:
case BGP_ATTR_LOCAL_PREF: case BGP_ATTR_LOCAL_PREF: