proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 02:53:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: reject leading 0 in ipv4 decimal quad

Browse Source 
inet_pton() is used to parse ipv4 addresses internally, therefore FRR
does not support octal notation for quads. The ipv4 cli token validator
should make sure that str2prefix() can parse tokens it allows, and
str2prefix uses inet_pton, so we have to disallow leading zeros in ipv4
quads.

In short, 1.1.1.01 is no longer valid and must be expressed as 1.1.1.1.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
This commit is contained in:
Quentin Young 2019-10-07 15:36:39 +00:00
parent 7310aae9ae
commit e843208299
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/command_match.c
View File

@ -724,7 +724,12 @@ static enum match_type match_ipv4(const char *str)
return no_match;
memcpy(buf, sp, str - sp);
if (atoi(buf) > 255)
int v = atoi(buf);
if (v > 255)
return no_match;
if (v > 0 && buf[0] == '0')
return no_match;
nums++;
@ -775,7 +780,12 @@ static enum match_type match_ipv4_prefix(const char *str)
return no_match;
memcpy(buf, sp, str - sp);
if (atoi(buf) > 255)
int v = atoi(buf);
if (v > 255)
return no_match;
if (v > 0 && buf[0] == '0')
return no_match;
if (dots == 3) {