proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-01 03:36:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

isisd zebra: dead code (Clang scan)

Browse Source 
This correction fixes two bugs detected by Clang scan:

Bug Group: Dead store

Bug Type: Dead assignment
File: zebra/kernel_netlink.c
Function: netlink_parse_extended_ack
Line: 548

Bug Type: Dead increment
File: isisd/isis_lsp.c
Function: lsp_bits2string
Line: 625

Signed-off-by: F. Aragon <paco@voltanet.io>
This commit is contained in:
F. Aragon 2018-06-29 17:01:29 +02:00
parent 62a9c814e1
commit e36e5b569c
No known key found for this signature in database
GPG Key ID: FD112A8C7E6A5E4A
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
isisd/isis_lsp.c
View File

@ -622,7 +622,7 @@ static const char *lsp_bits2string(uint8_t lsp_bits, char *buf, size_t buf_size)
pos += sprintf(pos, "%d/", pos += sprintf(pos, "%d/",
ISIS_MASK_LSP_PARTITION_BIT(lsp_bits) ? 1 : 0); ISIS_MASK_LSP_PARTITION_BIT(lsp_bits) ? 1 : 0);
pos += sprintf(pos, "%d", ISIS_MASK_LSP_OL_BIT(lsp_bits) ? 1 : 0); sprintf(pos, "%d", ISIS_MASK_LSP_OL_BIT(lsp_bits) ? 1 : 0);
return buf; return buf;
} }

1
zebra/kernel_netlink.c
View File

@ -545,7 +545,6 @@ static void netlink_parse_extended_ack(struct nlmsghdr *h)
if (off > h->nlmsg_len) { if (off > h->nlmsg_len) {
zlog_err("Invalid offset for NLMSGERR_ATTR_OFFS\n"); zlog_err("Invalid offset for NLMSGERR_ATTR_OFFS\n");
off = 0;
} else if (!(h->nlmsg_flags & NLM_F_CAPPED)) { } else if (!(h->nlmsg_flags & NLM_F_CAPPED)) {
/* /*
* Header of failed message * Header of failed message