proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 16:04:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: remove some useless initializations

Browse Source 
* bgp_attr.c: (bgp_attr_default_intern) bgp_attr_default_set() already
  initializes the memory. Fixes a struct attr_extra leak.
* bgp_route.c: Remove useless on stack struct initializations.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This commit is contained in:
Jorge Boncompte [DTI2] 2012-05-07 16:52:57 +00:00 committed by David Lamparter
parent 8ff56318a8
commit e16a413313
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bgpd/bgp_attr.c
View File

@ -560,9 +560,6 @@ bgp_attr_default_intern (u_char origin)
struct attr attr; struct attr attr;
struct attr *new; struct attr *new;
memset (&attr, 0, sizeof (struct attr));
bgp_attr_extra_get (&attr);
bgp_attr_default_set(&attr, origin); bgp_attr_default_set(&attr, origin);
new = bgp_attr_intern (&attr); new = bgp_attr_intern (&attr);

10
bgpd/bgp_route.c
View File

@ -2465,7 +2465,7 @@ void
bgp_default_originate (struct peer *peer, afi_t afi, safi_t safi, int withdraw) bgp_default_originate (struct peer *peer, afi_t afi, safi_t safi, int withdraw)
{ {
struct bgp *bgp; struct bgp *bgp;
struct attr attr = { 0 }; struct attr attr;
struct aspath *aspath = { 0 }; struct aspath *aspath = { 0 };
struct prefix p; struct prefix p;
struct bgp_info binfo; struct bgp_info binfo;
@ -3270,8 +3270,8 @@ bgp_static_update_rsclient (struct peer *rsclient, struct prefix *p,
struct bgp_info *new; struct bgp_info *new;
struct bgp_info info; struct bgp_info info;
struct attr *attr_new; struct attr *attr_new;
struct attr attr = {0 }; struct attr attr;
struct attr new_attr = { .extra = 0 }; struct attr new_attr = { 0 };
struct bgp *bgp; struct bgp *bgp;
int ret; int ret;
char buf[SU_ADDRSTRLEN]; char buf[SU_ADDRSTRLEN];
@ -3423,7 +3423,7 @@ bgp_static_update_main (struct bgp *bgp, struct prefix *p,
struct bgp_info *ri; struct bgp_info *ri;
struct bgp_info *new; struct bgp_info *new;
struct bgp_info info; struct bgp_info info;
struct attr attr = { 0 }; struct attr attr;
struct attr *attr_new; struct attr *attr_new;
int ret; int ret;
@ -5352,7 +5352,7 @@ bgp_redistribute_add (struct prefix *p, const struct in_addr *nexthop,
struct bgp_info *bi; struct bgp_info *bi;
struct bgp_info info; struct bgp_info info;
struct bgp_node *bn; struct bgp_node *bn;
struct attr attr = { 0 }; struct attr attr;
struct attr attr_new = { 0 }; struct attr attr_new = { 0 };
struct attr *new_attr; struct attr *new_attr;
afi_t afi; afi_t afi;