proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 08:32:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: fix churn of aggregate routes from duplicate config

Browse Source 
Currently when an aggregate-address is configured, the existing
entry is always removed regardless whether any change is involved.
This would create unnecessary churn of the aggregate route when
the same config is applied for the aggregate address.

The fix is to check for duplicate aggregate-address config.

Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
This commit is contained in:
Enke Chen 2025-01-11 14:01:36 -08:00
parent a962ff7833
commit daf749e934
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
bgpd/bgp_route.c
View File

@ -8874,6 +8874,27 @@ static int bgp_aggregate_unset(struct vty *vty, const char *prefix_str,
return CMD_SUCCESS; return CMD_SUCCESS;
} }
static bool bgp_aggregate_cmp_params(struct bgp_aggregate *aggregate, const char *rmap,
uint8_t summary_only, uint8_t as_set, uint8_t origin,
bool match_med, const char *suppress_map)
{
if ((aggregate->origin != origin) || (aggregate->as_set != as_set) ||
(aggregate->match_med != match_med) || (aggregate->summary_only != summary_only))
return false;
if ((!rmap && aggregate->rmap.name) || (rmap && !aggregate->rmap.name) ||
(rmap && aggregate->rmap.name && !strmatch(rmap, aggregate->rmap.name)))
return false;
if ((!suppress_map && aggregate->suppress_map_name) ||
(suppress_map && !aggregate->suppress_map_name) ||
(suppress_map && aggregate->suppress_map_name &&
!strmatch(suppress_map, aggregate->suppress_map_name)))
return false;
return true;
}
static int bgp_aggregate_set(struct vty *vty, const char *prefix_str, afi_t afi, static int bgp_aggregate_set(struct vty *vty, const char *prefix_str, afi_t afi,
safi_t safi, const char *rmap, safi_t safi, const char *rmap,
uint8_t summary_only, uint8_t as_set, uint8_t summary_only, uint8_t as_set,
@ -8913,6 +8934,11 @@ static int bgp_aggregate_set(struct vty *vty, const char *prefix_str, afi_t afi,
aggregate = bgp_dest_get_bgp_aggregate_info(dest); aggregate = bgp_dest_get_bgp_aggregate_info(dest);
if (aggregate) { if (aggregate) {
/* Check for duplicate configs */
if (bgp_aggregate_cmp_params(aggregate, rmap, summary_only, as_set, origin,
match_med, suppress_map))
return CMD_SUCCESS;
vty_out(vty, "There is already same aggregate network.\n"); vty_out(vty, "There is already same aggregate network.\n");
/* try to remove the old entry */ /* try to remove the old entry */
ret = bgp_aggregate_unset(vty, prefix_str, afi, safi); ret = bgp_aggregate_unset(vty, prefix_str, afi, safi);