proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 02:43:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ospfd: invalid MD5 auth_key?

Browse Source 
This looks fishy in ospf_make_md5_digest()
if (list_isempty (OSPF_IF_PARAM (oi, auth_crypt)))
    auth_key = (const u_int8_t *) "";
...
MD5Update(&ctx, auth_key, OSPF_AUTH_MD5_SIZE);
auth_key points to a "" string of len 1 which is a lot
smaller that OSPF_AUTH_MD5_SIZE. Is this intentional to
get some random data or just a plain bug?

Anyone using MD5 should have a closer look and decide
what to do.
Acked-by: Feng Lu <lu.feng@6wind.com>

(cherry picked from commit ea2a598411cc7bd20456849e56bbc9e93c9916e7)
This commit is contained in:
Joakim Tjernlund 2009-11-26 12:23:07 +00:00 committed by Daniel Walton
parent 1a0aa36f25
commit daa4981e60
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ospfd/ospf_packet.c
View File

@ -383,7 +383,7 @@ static int
ospf_make_md5_digest (struct ospf_interface *oi, struct ospf_packet *op) ospf_make_md5_digest (struct ospf_interface *oi, struct ospf_packet *op)
{ {
struct ospf_header *ospfh; struct ospf_header *ospfh;
unsigned char digest[OSPF_AUTH_MD5_SIZE]; unsigned char digest[OSPF_AUTH_MD5_SIZE] = {0};
MD5_CTX ctx; MD5_CTX ctx;
void *ibuf; void *ibuf;
u_int32_t t; u_int32_t t;
@ -410,7 +410,7 @@ ospf_make_md5_digest (struct ospf_interface *oi, struct ospf_packet *op)
/* Get MD5 Authentication key from auth_key list. */ /* Get MD5 Authentication key from auth_key list. */
if (list_isempty (OSPF_IF_PARAM (oi, auth_crypt))) if (list_isempty (OSPF_IF_PARAM (oi, auth_crypt)))
auth_key = (const u_int8_t *) ""; auth_key = (const u_int8_t *) digest;
else else
{ {
ck = listgetdata (listtail(OSPF_IF_PARAM (oi, auth_crypt))); ck = listgetdata (listtail(OSPF_IF_PARAM (oi, auth_crypt)));