proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-04 09:00:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Soft reconfig-in should find the right bgp_path_info

Browse Source 
When using soft reconfiguration inbound we are storing packet
data on the side for replaying when necessary.  The problem here
is that we are just grabbing the first bgp_path_info and using
that as the base.  What happens when we have soft-reconfig turned
on with multiple bgp_path_info's for a path?  This was introduced
in commit 8692c50652, yes back
in 2012!  I would argue, though, that it was just broken
in a different way before this.

Choose the correct bgp_path_info that corresponds to the peer
we received the data from for rethinking.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2019-10-15 08:27:22 -04:00
parent 4e2313d8ee
commit d7d158892a
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bgpd/bgp_route.c
View File

@ -3934,12 +3934,16 @@ static void bgp_soft_reconfig_table(struct peer *peer, afi_t afi, safi_t safi,
if (ain->peer != peer) if (ain->peer != peer)
continue; continue;
struct bgp_path_info *pi = struct bgp_path_info *pi;
bgp_node_get_bgp_path_info(rn);
uint32_t num_labels = 0; uint32_t num_labels = 0;
mpls_label_t *label_pnt = NULL; mpls_label_t *label_pnt = NULL;
struct bgp_route_evpn evpn; struct bgp_route_evpn evpn;
for (pi = bgp_node_get_bgp_path_info(rn); pi;
pi = pi->next)
if (pi->peer == peer)
break;
if (pi && pi->extra) if (pi && pi->extra)
num_labels = pi->extra->num_labels; num_labels = pi->extra->num_labels;
if (num_labels) if (num_labels)