proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-21 15:32:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #8104 from qlyoung/fix-clang-sa-feb2021

Browse Source 
lib: fix some misc SA warnings
This commit is contained in:
Donatas Abraitis 2021-02-18 13:30:26 +02:00 committed by GitHub
commit d30260ee9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/clippy.c
View File

@ -51,7 +51,8 @@ int main(int argc, char **argv)
#if PY_VERSION_HEX >= 0x03040000 /* 3.4 */
Py_SetStandardStreamEncoding("UTF-8", NULL);
#endif
Py_SetProgramName(wconv(argv[0]));
char *name = wconv(argv[0]);
Py_SetProgramName(name);
PyImport_AppendInittab("_clippy", command_py_init);
Py_Initialize();
@ -93,6 +94,7 @@ int main(int argc, char **argv)
for (int i = 1; i < argc; i++)
free(wargv[i - 1]);
#endif
free(name);
free(wargv);
return 0;
}

4
lib/defun_lex.l
View File

@ -80,6 +80,8 @@ static void extendbuf(char **what, const char *arg)
}
#define extend(x) extendbuf(&value, x)
#ifndef __clang_analyzer__
%}
ID [A-Za-z0-9_]+
@ -157,6 +159,8 @@ SPECIAL [(),]
%%
#endif /* __clang_analyzer__ */
static int yylex_clr(char **retbuf)
{
int rv = def_yylex();

12
lib/northbound_cli.c
View File

@ -600,7 +600,19 @@ void nb_cli_show_dnode_cmds(struct vty *vty, struct lyd_node *root,
(*nb_node->cbs.cli_show_end)(vty, parent);
}
/*
* There is a possible path in this macro that ends up
* dereferencing child->parent->parent. We just null checked
* child->parent by checking (ly_iter_next_up(child) != NULL)
* above.
*
* I am not sure whether it is possible for the other
* conditions within this macro guarding the problem
* dereference to be satisfied when child->parent == NULL.
*/
#ifndef __clang_analyzer__
LY_TREE_DFS_END(root, next, child);
#endif
}
}