proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-16 08:32:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

zebra/interface.c: allow link-param delay min <= avg <= max

Browse Source 
RFC 7471 Section 4.2.7:
	It is possible for min delay and max delay to be the same value.

    Prior to this change, the code required min < avg < max. This
    change allows min == avg and avg == max.

    test case:

    interface eth-rt1
      link-params
        delay 8000 min 8000 max 8000

Signed-off-by: G. Paul Ziemba <paulz@labn.net>
This commit is contained in:
G. Paul Ziemba 2022-05-06 14:32:49 -07:00
parent 00b0b74847
commit d029fe275c
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
zebra/interface.c
View File

@ -3557,12 +3557,20 @@ DEFUN (link_params_delay,
uint8_t update = 0;
if (argc == 2) {
/* Check new delay value against old Min and Max delays if set
/*
* Check new delay value against old Min and Max delays if set
*
* RFC 7471 Section 4.2.7:
* It is possible for min delay and max delay to be
* the same value.
*
* Therefore, it is also allowed that the average
* delay be equal to the min delay or max delay.
*/
if (IS_PARAM_SET(iflp, LP_MM_DELAY)
&& (delay <= iflp->min_delay || delay >= iflp->max_delay)) {
&& (delay < iflp->min_delay || delay > iflp->max_delay)) {
vty_out(vty,
"Average delay should be comprise between Min (%d) and Max (%d) delay\n",
"Average delay should be in range Min (%d) - Max (%d) delay\n",
iflp->min_delay, iflp->max_delay);
return CMD_WARNING_CONFIG_FAILED;
}
@ -3580,10 +3588,13 @@ DEFUN (link_params_delay,
update = 1;
}
} else {
/* Check new delays value coherency */
if (delay <= low || delay >= high) {
/*
* Check new delays value coherency. See above note
* regarding average delay equal to min/max allowed
*/
if (delay < low || delay > high) {
vty_out(vty,
"Average delay should be comprise between Min (%d) and Max (%d) delay\n",
"Average delay should be in range Min (%d) - Max (%d) delay\n",
low, high);
return CMD_WARNING_CONFIG_FAILED;
}