From 3fa12343391fca7a80fe26f5d2c801765b3bd953 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 10 Jan 2018 15:07:05 -0500 Subject: [PATCH 1/3] bgpd: bgp_afi_node_get is listed 2 times in bgp_route.h Remove the extra. Signed-off-by: Donald Sharp --- bgpd/bgp_route.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/bgpd/bgp_route.h b/bgpd/bgp_route.h index ae4759aad0..fc15720ebc 100644 --- a/bgpd/bgp_route.h +++ b/bgpd/bgp_route.h @@ -418,8 +418,6 @@ extern void bgp_peer_clear_node_queue_drain_immediate(struct peer *peer); extern void bgp_process_queues_drain_immediate(void); /* for encap/vpn */ -extern struct bgp_node *bgp_afi_node_get(struct bgp_table *, afi_t, safi_t, - struct prefix *, struct prefix_rd *); extern struct bgp_node *bgp_afi_node_lookup(struct bgp_table *table, afi_t afi, safi_t safi, struct prefix *p, struct prefix_rd *prd); From 8ef6371e1f426cd75aec70c8bf3b061f46c40e13 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Fri, 12 Jan 2018 09:51:18 -0500 Subject: [PATCH 2/3] bgpd: Fix bgp_vty.h to conform to coding standard The function declarations were missing some parameter names as is our standard. Signed-off-by: Donald Sharp --- bgpd/bgp_vty.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bgpd/bgp_vty.h b/bgpd/bgp_vty.h index e456f7caed..cbb41f0840 100644 --- a/bgpd/bgp_vty.h +++ b/bgpd/bgp_vty.h @@ -44,9 +44,9 @@ struct bgp; "Address Family modifier\n" extern void bgp_vty_init(void); -extern const char *afi_safi_print(afi_t, safi_t); -extern const char *afi_safi_json(afi_t, safi_t); -extern void bgp_config_write_update_delay(struct vty *, struct bgp *); +extern const char *afi_safi_print(afi_t afi, safi_t safi); +extern const char *afi_safi_json(afi_t afi, safi_t safi); +extern void bgp_config_write_update_delay(struct vty *vty, struct bgp *bgp); extern void bgp_config_write_wpkt_quanta(struct vty *vty, struct bgp *bgp); extern void bgp_config_write_rpkt_quanta(struct vty *vty, struct bgp *bgp); extern void bgp_config_write_listen(struct vty *vty, struct bgp *bgp); From 5a1b3fb5ae7a7a1253de8039eb6d5f9798c55c82 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Fri, 12 Jan 2018 09:55:28 -0500 Subject: [PATCH 3/3] bgpd: Fix some evpn hash key creation The creation of a hash key should use a jhash function instead of adding the char's together. Signed-off-by: Donald Sharp --- bgpd/bgp_evpn.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/bgpd/bgp_evpn.c b/bgpd/bgp_evpn.c index 12cc425bd3..824b72b240 100644 --- a/bgpd/bgp_evpn.c +++ b/bgpd/bgp_evpn.c @@ -99,19 +99,8 @@ static unsigned int vrf_import_rt_hash_key_make(void *p) { struct vrf_irt_node *irt = p; char *pnt = irt->rt.val; - unsigned int key = 0; - int c = 0; - key += pnt[c]; - key += pnt[c + 1]; - key += pnt[c + 2]; - key += pnt[c + 3]; - key += pnt[c + 4]; - key += pnt[c + 5]; - key += pnt[c + 6]; - key += pnt[c + 7]; - - return key; + return jhash(pnt, 8, 0x5abc1234); } /* @@ -224,19 +213,8 @@ static unsigned int import_rt_hash_key_make(void *p) { struct irt_node *irt = p; char *pnt = irt->rt.val; - unsigned int key = 0; - int c = 0; - key += pnt[c]; - key += pnt[c + 1]; - key += pnt[c + 2]; - key += pnt[c + 3]; - key += pnt[c + 4]; - key += pnt[c + 5]; - key += pnt[c + 6]; - key += pnt[c + 7]; - - return (key); + return jhash(pnt, 8, 0xdeadbeef); } /*