proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-11-04 10:07:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

zebra: Fix valgrind report of unintialized data

Browse Source 
When calling the kernel we are not properly initializing
iov and msg on function startup.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2017-10-02 10:42:53 -04:00
parent 51dcd4c376
commit cbaca6a144
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
zebra/kernel_netlink.c
View File

@ -676,16 +676,21 @@ int netlink_talk(int (*filter)(struct sockaddr_nl *, struct nlmsghdr *, ns_id_t,
{
int status;
struct sockaddr_nl snl;
struct iovec iov = {.iov_base = (void *)n, .iov_len = n->nlmsg_len};
struct msghdr msg = {
.msg_name = (void *)&snl,
.msg_namelen = sizeof snl,
.msg_iov = &iov,
.msg_iovlen = 1,
};
struct iovec iov;
struct msghdr msg;
int save_errno;
memset(&snl, 0, sizeof snl);
memset(&iov, 0, sizeof iov);
memset(&msg, 0, sizeof msg);
iov.iov_base = n;
iov.iov_len = n->nlmsg_len;
msg.msg_name = (void *)&snl;
msg.msg_namelen = sizeof snl;
msg.msg_iov = &iov;
msg.msg_iovlen = 1;
snl.nl_family = AF_NETLINK;
n->nlmsg_seq = ++nl->seq;