proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-10-18 19:41:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bfdd: Remove useless check for ECHO packet

Browse Source 
The check with `ip->daddr == ip->saddr` in `bfd_recv_ipv4_fp()` is
useless, instead of it the ECHO packets should simply exit with
TTL checking failure regardless of this condition check.

Just remove the check.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
This commit is contained in:
anlan_cs 2023-03-02 17:57:17 +08:00
parent a91520cfaf
commit c9aac2c38a
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bfdd/bfd_packet.c
View File

@ -140,7 +140,7 @@ int _ptm_bfd_send(struct bfd_session *bs, uint16_t *port, const void *data,
* sizeof(*pkt)
*
* ip
* IP address that pkt will be transmitted from and too.
* IP address that pkt will be transmitted from and to.
*
* Returns:
* Checksum in network byte order.
@ -481,12 +481,6 @@ ssize_t bfd_recv_ipv4_fp(int sd, uint8_t *msgbuf, size_t msgbuflen,
*ttl = ip->ttl;
if (*ttl != 254) {
/* Echo should be looped in peer's forwarding plane, but it also
* comes up to BFD so silently drop it
*/
if (ip->daddr == ip->saddr)
return -1;
if (bglobal.debug_network)
zlog_debug("%s: invalid TTL: %u", __func__, *ttl);
return -1;