From c65e7e7c3fc382c19415b602514fa5e236636c93 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Thu, 29 Jun 2023 10:42:11 -0400 Subject: [PATCH] tests: Fix broken check_ping run_and_expect semantics *again*. Signed-off-by: Donald Sharp --- tests/topotests/bgp_vpnv4_asbr/test_bgp_vpnv4_asbr.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/topotests/bgp_vpnv4_asbr/test_bgp_vpnv4_asbr.py b/tests/topotests/bgp_vpnv4_asbr/test_bgp_vpnv4_asbr.py index 7b0dc1cff9..c47822614b 100644 --- a/tests/topotests/bgp_vpnv4_asbr/test_bgp_vpnv4_asbr.py +++ b/tests/topotests/bgp_vpnv4_asbr/test_bgp_vpnv4_asbr.py @@ -250,7 +250,8 @@ def check_ping(name, dest_addr, expect_connected): tgen = get_topogen() output = tgen.gears[name].run("ping {} -c 1 -w 1".format(dest_addr)) logger.info(output) - assert match in output, "ping fail" + if match not in output: + return "ping fail" match = ", {} packet loss".format("0%" if expect_connected else "100%") logger.info("[+] check {} {} {}".format(name, dest_addr, match))