proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-29 21:23:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: fix possible freeing of libyang data

Browse Source 
mgmtd frees all non-NULL change->value variables at the end of every
commit. We shouldn't assign change->value with data returned by libyang
to prevent freeing of library-allocated memory.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
(cherry picked from commit 814b9fb772)
This commit is contained in:
Igor Ryzhov 2023-11-11 02:06:11 +02:00 committed by Mergify
parent 3fba3d5d4f
commit c720f9cdb7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/northbound.c
View File

@ -842,6 +842,7 @@ void nb_candidate_edit_config_changes(
struct nb_cfg_change *change = &cfg_changes[i]; struct nb_cfg_change *change = &cfg_changes[i];
struct nb_node *nb_node; struct nb_node *nb_node;
char xpath[XPATH_MAXLEN]; char xpath[XPATH_MAXLEN];
const char *value;
struct yang_data *data; struct yang_data *data;
int ret; int ret;
@ -879,9 +880,10 @@ void nb_candidate_edit_config_changes(
} }
/* If the value is not set, get the default if it exists. */ /* If the value is not set, get the default if it exists. */
if (change->value == NULL) value = change->value;
change->value = yang_snode_get_default(nb_node->snode); if (value == NULL)
data = yang_data_new(xpath, change->value); value = yang_snode_get_default(nb_node->snode);
data = yang_data_new(xpath, value);
/* /*
* Ignore "not found" errors when editing the candidate * Ignore "not found" errors when editing the candidate