proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-05 04:40:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib/trivial: str2prefix checks return of inet_pton in fragile way

Browse Source 
* prefix.c: (str2prefix_ipv6) inet_pton succesful return is presumed to be
  1, rather than the "not zero" the man page describes - seemed fragile.
This commit is contained in:
Paul Jakma 2009-08-08 20:41:39 +01:00
parent fab7f89dcf
commit c4cf095e95
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/prefix.c
View File

@ -379,7 +379,7 @@ str2prefix_ipv6 (const char *str, struct prefix_ipv6 *p)
if (pnt == NULL)
{
ret = inet_pton (AF_INET6, str, &p->prefix);
if (ret != 1)
if (ret == 0)
return 0;
p->prefixlen = IPV6_MAX_BITLEN;
}
@ -392,7 +392,7 @@ str2prefix_ipv6 (const char *str, struct prefix_ipv6 *p)
*(cp + (pnt - str)) = '\0';
ret = inet_pton (AF_INET6, cp, &p->prefix);
free (cp);
if (ret != 1)
if (ret == 0)
return 0;
plen = (u_char) atoi (++pnt);
if (plen > 128)