proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 14:17:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #5672 from qlyoung/fix-zebra-pbr-iptable-heap-uaf

Browse Source 
zebra: fix iptable install heap UAF
This commit is contained in:
David Lamparter 2020-01-16 10:14:45 +01:00 committed by GitHub
commit c36fbd565e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
zebra/zebra_pbr.c
View File

@ -652,12 +652,22 @@ static void *pbr_iptable_alloc_intern(void *arg)
{ {
struct zebra_pbr_iptable *zpi; struct zebra_pbr_iptable *zpi;
struct zebra_pbr_iptable *new; struct zebra_pbr_iptable *new;
struct listnode *ln;
char *ifname;
zpi = (struct zebra_pbr_iptable *)arg; zpi = (struct zebra_pbr_iptable *)arg;
new = XCALLOC(MTYPE_TMP, sizeof(struct zebra_pbr_iptable)); new = XCALLOC(MTYPE_TMP, sizeof(struct zebra_pbr_iptable));
/* Deep structure copy */
memcpy(new, zpi, sizeof(*zpi)); memcpy(new, zpi, sizeof(*zpi));
new->interface_name_list = list_new();
if (zpi->interface_name_list) {
for (ALL_LIST_ELEMENTS_RO(zpi->interface_name_list, ln, ifname))
listnode_add(new->interface_name_list,
XSTRDUP(MTYPE_PBR_IPTABLE_IFNAME, ifname));
}
return new; return new;
} }