proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-11 16:02:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bfdd: fix coverity warnings

Browse Source 
show/clear DEFUNs always require either peer label or IP address to be
specified, so if `label` is NULL then `peer_str` is definitely not NULL.
But Coverity doesn't know about that, so it complains about possible
NULL dereference of `peer_str`. This commit should make Coverity happy.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
This commit is contained in:
Igor Ryzhov 2021-11-10 16:36:15 +03:00
parent b6380d60c7
commit c3634e4411
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfdd/bfdd_vty.c
View File

@ -579,7 +579,7 @@ _find_peer_or_error(struct vty *vty, int argc, struct cmd_token **argv,
pl = pl_find(label); pl = pl_find(label);
if (pl) if (pl)
bs = pl->pl_bs; bs = pl->pl_bs;
} else { } else if (peer_str) {
strtosa(peer_str, &psa); strtosa(peer_str, &psa);
if (local_str) { if (local_str) {
strtosa(local_str, &lsa); strtosa(local_str, &lsa);
@ -599,6 +599,9 @@ _find_peer_or_error(struct vty *vty, int argc, struct cmd_token **argv,
} }
bs = bs_peer_find(&bpc); bs = bs_peer_find(&bpc);
} else {
vty_out(vty, "%% Invalid arguments\n");
return NULL;
} }
/* Find peer data. */ /* Find peer data. */